commit | 48f1411837ad49de3f11eaeb924bdadb5c7287bf | [log] [tgz] |
---|---|---|
author | Yang Xu <xuyang2018.jy@cn.fujitsu.com> | Mon Jun 10 16:51:46 2019 +0800 |
committer | Petr Vorel <pvorel@suse.cz> | Thu Jun 20 14:50:51 2019 +0200 |
tree | 7db9593faba1d1f9ee2318e7139c9881e800ff60 | |
parent | 4d0b26d317b671252dddeaaa2f08b4d602bff8a1 [diff] |
sysctl/sysctl02: Add new regression test for overflow file-max On upstream kernel before commit 7f2923c4f73f ("sysctl: handle overflow in proc_get_long") max value in proc_get_long is based on the number of chars(21). It rejects values such as 184467440737095516160 (21 chars) but accepts values such as 18446744073709551616 (20 chars). But both should be rejected as both overflows. 7f2923c4f73f sets max allowed value to 2^64-1. Before commit 32a5ad9c2285 ("sysctl: handle overflow for file-max") writing 18446744073709551616 to /proc/sys/fs/file-max overflows and value is set 0, and this may crash the system. 32a5ad9c2285 sets max allowed value 2^63-1. Unfortunately 32a5ad9c2285 introduced a regression. The minimum value points at the global 'zero' variable which is an int. This results in a KASAN splat when accessed as a long by proc_doulongvec_minmax on 64-bit architectures. This bug has been fixed in 9002b21465fa ("kernel/sysctl.c: fix out-of-bounds access when setting file-max"). We test in sysctl02.sh setting 2^64, 2^64-1, 2^63 and 0. Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com> [ pvorel: partly rewritten to improve shell code, commit message and formatting ] Signed-off-by: Petr Vorel <pvorel@suse.cz>
Linux Test Project is a joint project started by SGI, OSDL and Bull developed and maintained by IBM, Cisco, Fujitsu, SUSE, Red Hat, Oracle and others. The project goal is to deliver tests to the open source community that validate the reliability, robustness, and stability of Linux.
The LTP testsuite contains a collection of tools for testing the Linux kernel and related features. Our goal is to improve the Linux kernel and system libraries by bringing test automation to the testing effort. Interested open source contributors are encouraged to join.
Project pages are located at: http://linux-test-project.github.io/
The latest image is always available at: https://github.com/linux-test-project/ltp/releases
The discussion about the project happens at ltp mailing list: http://lists.linux.it/listinfo/ltp
The git repository is located at GitHub at: https://github.com/linux-test-project/ltp
The patchwork instance is at: https://patchwork.ozlabs.org/project/ltp/list/
Be careful with these tests!
Don't run them on production systems. Growfiles, doio, and iogen in particular stress the I/O capabilities of systems and while they should not cause problems on properly functioning systems, they are intended to find (or cause) problems.
If you have git, autoconf, automake, m4, the linux headers and the common developer packages installed, the chances are the following will work.
$ git clone https://github.com/linux-test-project/ltp.git $ cd ltp $ make autotools $ ./configure
Now you can continue either with compiling and running a single test or with compiling and installing the whole testsuite.
If you need to execute a single test you actually do not need to compile the whole LTP, if you want to run a syscall testcase following should work.
$ cd testcases/kernel/syscalls/foo $ make $ PATH=$PATH:$PWD ./foo01
Shell testcases are a bit more complicated since these need a path to a shell library as well as to compiled binary helpers, but generally following should work.
$ cd testcases/lib $ make $ cd ../commands/foo $ PATH=$PATH:$PWD:$PWD/../../lib/ ./foo01.sh
Open Posix Testsuite has it's own build system which needs Makefiles to be generated first, then compilation should work in subdirectories as well.
$ cd testcases/open_posix_testsuite/ $ make generate-makefiles $ cd conformance/interfaces/foo $ make $ ./foo_1-1.run-test
$ make $ make install
This will install LTP to /opt/ltp
.
doc/mini-howto-building-ltp-from-git.txt
.INSTALL
and ./configure --help
.Some tests will be disabled if the configure script can not find their build dependencies.
TCONF
due to a missing component, check the ./configure
output.INSTALL
.To run all the test suites
$ cd /opt/ltp $ ./runltp
Note that many test cases have to be executed as root.
To run a particular test suite
$ ./runltp -f syscalls
To run all tests with madvise
in the name
$ ./runltp -f syscalls -s madvise
Also see
$ ./runltp --help
Test suites (e.g. syscalls) are defined in the runtest directory. Each file contains a list of test cases in a simple format, see doc/ltp-run-files.txt.
Each test case has its own executable or script, these can be executed directly
$ testcases/bin/abort01
Some have arguments
$ testcases/bin/fork13 -i 37
The vast majority of test cases accept the -h (help) switch
$ testcases/bin/ioctl01 -h
Many require certain environment variables to be set
$ LTPROOT=/opt/ltp PATH="$PATH:$LTPROOT/testcases/bin" testcases/bin/wc01.sh
Most commonly, the path variable needs to be set and also LTPROOT
, but there are a number of other variables, runltp
usually sets these for you.
Note that all shell scripts need the PATH
to be set. However this is not limited to shell scripts, many C based tests need environment variables as well.
Before you start you should read following documents:
doc/test-writing-guidelines.txt
doc/build-system-guide.txt
There is also a step-by-step tutorial:
doc/c-test-tutorial-simple.txt
If something is not covered there don't hesitate to ask on the LTP mailing list. Also note that these documents are available online at:
Although we accept GitHub pull requests, the preferred way is sending patches to our mailing list.
It's a good idea to test patches on Travis CI before posting to mailing list. Our travis setup covers various architectures and distributions in order to make sure LTP compiles cleanly on most common configurations. For testing you need to sign up to Travis CI, enable running builds on your LTP fork on https://travis-ci.org/account/repositories and push your branch.