tree 479bebab94ff24da9f6d4f101d3f14493ce4ebf5
parent 232a7f18cf8ecbd92a8cc6ca7feee4f6aab668fe
author Nishka Dasgupta <nishkadg.linux@gmail.com> 1563956169 +0530
committer Vinod Koul <vkoul@kernel.org> 1565267210 +0530

dmaengine: qcom: hidma_mgmt: Add of_node_put() before goto

Each iteration of for_each_available_child_of_node puts the previous
node, but in the case of a goto from the middle of the loop, there is
no put, thus causing a memory leak.
Hence add an of_node_put under the label that the gotos point to.
In order to avoid decrementing an already-decremented refcount, copy the
original contents of the label (including the return statement) to just
above the label, so that the code under the label is executed only when
a goto exit from the loop occurs.
Additionally, remove an unnecessary get/put pair from the loop, as the
loop itself already keeps track of refcount.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Acked-by: Sinan Kaya <okaya@kernel.org>
Link: https://lore.kernel.org/r/20190724081609.9724-1-nishkadg.linux@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>