tree 05945031406518463e6cbf336b43affbde93451b
parent b0c873282b27a62ede57288397c346f7941f9454
author Max Moroz <mmoroz@chromium.org> 1528309743 -0700
committer Tom Finegan <tomfinegan@google.com> 1528310527 -0700

Move definition of IMkvReader::~IMkvReader() to mkvparser.h.

In order to get UBSan's vptr check to work with sancov instrumentation,
an abstract class should have its methods to be defined in the same
translation unit OR to be declared as pure virtual. Otherwise, typeinfo
causes undefined symbol error during linking.

For this particular case, the issue happens due to mkvmuxer/mkvmuxer.cc
file using mkvparser::IMkvReader* type, while its destructor is neither
pure virtual nor defined in the header file, i.e. it is outside of the
mkvmuxer.o translation unit.

See https://bugs.chromium.org/p/chromium/issues/detail?id=849812

Change-Id: I881ab87d62e15d648a2c29656f1db228fdef6b42