Plug some memory leaks.

We allocate memory for the user name and password when using
username/password authentication; free it if the authentication succeeds
or fails.

Fixes Coverity CIDs 1419022 and 1419023.

While we're at it, rename variables to indicate what they're doing
(they're not just two random strings, they're a user name and password),
and put the string pointers into the scope of the "username/password
authentication" case, just as the string lengths are.
1 file changed
tree: f35631e0f892fd355973b458c33d5294077087ae
  1. .github/
  2. bpf/
  3. ChmodBPF/
  4. cmake/
  5. lbl/
  6. missing/
  7. msdos/
  8. pcap/
  9. rpcapd/
  10. SUNOS4/
  11. tests/
  12. Win32/
  13. .appveyor.yml
  14. .gitattributes
  15. .gitignore
  16. .travis-coverity-scan-build.sh
  17. .travis.yml
  18. aclocal.m4
  19. arcnet.h
  20. atmuni31.h
  21. bpf_dump.c
  22. bpf_image.c
  23. CHANGES
  24. chmod_bpf
  25. cmake_uninstall.cmake.in
  26. cmakeconfig.h.in
  27. CMakeLists.txt
  28. config.guess
  29. config.h.in
  30. config.sub
  31. configure
  32. configure.ac
  33. CONTRIBUTING
  34. CREDITS
  35. dlpisubs.c
  36. dlpisubs.h
  37. etherent.c
  38. ethertype.h
  39. extract.h
  40. fad-getad.c
  41. fad-gifc.c
  42. fad-glifc.c
  43. ftmacros.h
  44. gencode.c
  45. gencode.h
  46. grammar.y
  47. ieee80211.h
  48. install-sh
  49. INSTALL.txt
  50. LICENSE
  51. llc.h
  52. Makefile-devel-adds
  53. Makefile.in
  54. mkdep
  55. nametoaddr.c
  56. nametoaddr.h
  57. nlpid.h
  58. optimize.c
  59. org.tcpdump.chmod_bpf.plist
  60. pcap-bpf.c
  61. pcap-bpf.h
  62. pcap-bt-linux.c
  63. pcap-bt-linux.h
  64. pcap-bt-monitor-linux.c
  65. pcap-bt-monitor-linux.h
  66. pcap-common.c
  67. pcap-common.h
  68. pcap-config.1
  69. pcap-config.in
  70. pcap-dag.c
  71. pcap-dag.h
  72. pcap-dbus.c
  73. pcap-dbus.h
  74. pcap-dll.rc
  75. pcap-dlpi.c
  76. pcap-dos.c
  77. pcap-dos.h
  78. pcap-enet.c
  79. pcap-filter.manmisc.in
  80. pcap-int.h
  81. pcap-libdlpi.c
  82. pcap-linktype.manmisc.in
  83. pcap-linux.c
  84. pcap-namedb.h
  85. pcap-netfilter-linux.c
  86. pcap-netfilter-linux.h
  87. pcap-netmap.c
  88. pcap-netmap.h
  89. pcap-new.c
  90. pcap-nit.c
  91. pcap-npf.c
  92. pcap-null.c
  93. pcap-pf.c
  94. pcap-rdmasniff.c
  95. pcap-rdmasniff.h
  96. pcap-rpcap-int.h
  97. pcap-rpcap.c
  98. pcap-rpcap.h
  99. pcap-savefile.manfile.in
  100. pcap-septel.c
  101. pcap-septel.h
  102. pcap-sita.c
  103. pcap-sita.h
  104. pcap-sita.html
  105. pcap-snf.c
  106. pcap-snf.h
  107. pcap-snit.c
  108. pcap-snoop.c
  109. pcap-tc.c
  110. pcap-tc.h
  111. pcap-tstamp.manmisc.in
  112. pcap-types.h
  113. pcap-usb-linux.c
  114. pcap-usb-linux.h
  115. pcap.3pcap.in
  116. pcap.c
  117. pcap.h
  118. pcap_activate.3pcap
  119. pcap_breakloop.3pcap
  120. pcap_can_set_rfmon.3pcap
  121. pcap_close.3pcap
  122. pcap_compile.3pcap.in
  123. pcap_create.3pcap
  124. pcap_datalink.3pcap.in
  125. pcap_datalink_name_to_val.3pcap
  126. pcap_datalink_val_to_name.3pcap
  127. pcap_dump.3pcap
  128. pcap_dump_close.3pcap
  129. pcap_dump_file.3pcap
  130. pcap_dump_flush.3pcap
  131. pcap_dump_ftell.3pcap
  132. pcap_dump_open.3pcap.in
  133. pcap_file.3pcap
  134. pcap_fileno.3pcap
  135. pcap_findalldevs.3pcap
  136. pcap_freecode.3pcap
  137. pcap_get_selectable_fd.3pcap
  138. pcap_get_tstamp_precision.3pcap.in
  139. pcap_geterr.3pcap
  140. pcap_inject.3pcap
  141. pcap_is_swapped.3pcap
  142. pcap_lib_version.3pcap
  143. pcap_list_datalinks.3pcap.in
  144. pcap_list_tstamp_types.3pcap.in
  145. pcap_lookupdev.3pcap
  146. pcap_lookupnet.3pcap
  147. pcap_loop.3pcap
  148. pcap_major_version.3pcap
  149. pcap_next_ex.3pcap
  150. pcap_offline_filter.3pcap
  151. pcap_open_dead.3pcap.in
  152. pcap_open_live.3pcap
  153. pcap_open_offline.3pcap.in
  154. pcap_set_buffer_size.3pcap
  155. pcap_set_datalink.3pcap
  156. pcap_set_immediate_mode.3pcap
  157. pcap_set_promisc.3pcap
  158. pcap_set_protocol.3pcap
  159. pcap_set_rfmon.3pcap
  160. pcap_set_snaplen.3pcap
  161. pcap_set_timeout.3pcap
  162. pcap_set_tstamp_precision.3pcap.in
  163. pcap_set_tstamp_type.3pcap.in
  164. pcap_setdirection.3pcap
  165. pcap_setfilter.3pcap
  166. pcap_setnonblock.3pcap
  167. pcap_snapshot.3pcap
  168. pcap_stats.3pcap
  169. pcap_statustostr.3pcap
  170. pcap_strerror.3pcap
  171. pcap_tstamp_type_name_to_val.3pcap
  172. pcap_tstamp_type_val_to_name.3pcap
  173. portability.h
  174. ppp.h
  175. README
  176. README.aix
  177. README.dag
  178. README.hpux
  179. README.linux
  180. README.macosx
  181. README.septel
  182. README.sita
  183. README.tru64
  184. README.Win32
  185. rpcap-protocol.c
  186. rpcap-protocol.h
  187. savefile.c
  188. scanner.l
  189. sf-pcap-ng.c
  190. sf-pcap-ng.h
  191. sf-pcap.c
  192. sf-pcap.h
  193. sockutils.c
  194. sockutils.h
  195. sunatmpos.h
  196. TODO
  197. VERSION