tree 91533bfb6216082d33506e8924ca24974c3cfd58
parent af961ed8cf29ca8cadce4b96082c350d44e347c2
author Eric Fiselier <eric@efcs.ca> 1439926775 +0000
committer Eric Fiselier <eric@efcs.ca> 1439926775 +0000

[libcxx] Disable -Wnon-virtual-dtor warning in <locale>

Summary:
Normally people won't see warnings in libc++ headers, but if they compile with "-Wsystem-headers -Wnon-virtual-dtor" they will likely see issues in <locale>.

In the libc++ implementation `time_get' has a private base class, `__time_get_c_storage`, with virtual methods but a non-virtual destructor. 
`time_get` itself can safely be used as a polymorphic base class because it inherits a virtual destructor from `locale::facet`. To placate the compiler we change `__time_get_c_storage`'s destructor from public to protected, ensuring that it will never be deleted polymorphically.

Reviewers: mclow.lists

Subscribers: cfe-commits

Differential Revision: http://reviews.llvm.org/D11670

git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@245333 91177308-0d34-0410-b5e6-96231b3b80d8