)]}' { "log": [ { "commit": "5608ecc3d986aff144886e11ba2037f742605a98", "tree": "ed755cb946ba03e074effc5f3f5ccfb0a904aa56", "parents": [ "d6c554f1b2e9fb345ecfacb835fca70611c05c24", "45328a6d6282fecd2c2b06602695a8b93ddb5261" ], "author": { "name": "Xin Li", "email": "delphij@google.com", "time": "Fri Dec 20 13:39:39 2024 -0800" }, "committer": { "name": "Xin Li", "email": "delphij@google.com", "time": "Fri Dec 20 13:39:39 2024 -0800" }, "message": "Empty merge ab/12770256 into aosp-main-future\n\nMerged-In: I8934c43a7733f7afa811a33f5acf0a7945481024\nChange-Id: I280608c4efadb8d6d5d0e6caeccf6303965a2f5b\n" }, { "commit": "d6c554f1b2e9fb345ecfacb835fca70611c05c24", "tree": "ed755cb946ba03e074effc5f3f5ccfb0a904aa56", "parents": [ "eebf20cd61ae7269acb904b5b627d89e679e02da", "821abc49b4855464287e1bd5c3d1dfbe741d68bc" ], "author": { "name": "Sadaf Ebrahimi", "email": "sadafebrahimi@google.com", "time": "Thu Dec 19 13:53:55 2024 -0800" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Dec 19 13:53:55 2024 -0800" }, "message": "Add janitors to the OWNERS file am: 821abc49b4\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/3423782\n\nChange-Id: I42f73f3b91929cb0737494457dc70b3590ff9cda\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "821abc49b4855464287e1bd5c3d1dfbe741d68bc", "tree": "ed755cb946ba03e074effc5f3f5ccfb0a904aa56", "parents": [ "eebf20cd61ae7269acb904b5b627d89e679e02da" ], "author": { "name": "Sadaf Ebrahimi", "email": "sadafebrahimi@google.com", "time": "Wed Dec 18 20:23:07 2024 +0000" }, "committer": { "name": "Sadaf Ebrahimi", "email": "sadafebrahimi@google.com", "time": "Wed Dec 18 20:23:07 2024 +0000" }, "message": "Add janitors to the OWNERS file\n\nTest: TreeHugger\nChange-Id: I5dc106b6a67abcbeb3c1ed54789f0ed88e66e46d\n" }, { "commit": "45328a6d6282fecd2c2b06602695a8b93ddb5261", "tree": "883b41225f5a76e7fcc62db547f593045c3432e8", "parents": [ "e62febbcdf3c6d1dc94cad40941ec7c368efc731", "eebf20cd61ae7269acb904b5b627d89e679e02da" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Thu Oct 24 12:21:14 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Oct 24 12:21:14 2024 +0000" }, "message": "Merge finger lock fix and quality improvements from upstream am: 4939a509c7 am: eebf20cd61\n\nOriginal change: undetermined\n\nChange-Id: I5c0c22c82afc39cd74a993a084779a9508aa502e\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "eebf20cd61ae7269acb904b5b627d89e679e02da", "tree": "883b41225f5a76e7fcc62db547f593045c3432e8", "parents": [ "e62febbcdf3c6d1dc94cad40941ec7c368efc731", "4939a509c7aeaf2c0419fe68f0952f967e160233" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Thu Oct 24 12:02:15 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Oct 24 12:02:15 2024 +0000" }, "message": "Merge finger lock fix and quality improvements from upstream am: 4939a509c7\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/3315652\n\nChange-Id: I9a1ded18eac8a875726c33cc092a83882c57461c\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "4939a509c7aeaf2c0419fe68f0952f967e160233", "tree": "883b41225f5a76e7fcc62db547f593045c3432e8", "parents": [ "1ef73409afe127fa1271f29f25d4f2f3f7a3127b", "3e416e57e0f66cdf8a1dac8d043b96b12b2988a6" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Wed Oct 23 13:27:23 2024 +0000" }, "committer": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Wed Oct 23 13:27:23 2024 +0000" }, "message": "Merge finger lock fix and quality improvements from upstream\n\nThe only functionality change here is a fix for a finger locking issue\naffecting click-and-drag gestures (https://crrev.com/c/5841662). The\nother changes are a move to building with C++20 and improvements to the\nstring representations of Gesture and HardwareState structs.\n\nBug: 245989146\nTest: Treehugger\nFlag: EXEMPT library uprev\nChange-Id: I29f7f6e5ab746e216a4719f38df3bdfdc8a18ee4\n" }, { "commit": "3e416e57e0f66cdf8a1dac8d043b96b12b2988a6", "tree": "64cd25a848bb90021e2d2b50d20fc8b0b35fad2d", "parents": [ "9cd1400773ceccd2cbad3c5d0a2a28015ae1619b" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Fri Oct 18 15:03:00 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Oct 21 11:42:12 2024 +0000" }, "message": "Include is_tap when stringifying buttons gestures\n\nTEST\u003dwith an Android device, run\n $ adb shell \u0027stop \u0026\u0026 setprop log.tag.TouchpadInputMapperGestures DEBUG \u0026\u0026 start\u0027\n then check InputReader \"Gesture ready\" log messages when\n three-finger tapping on the touchpad\nBUG\u003db:245989146\n\nChange-Id: Ibbb9d4a9d88c9bb8d911bd70d8081a67d24965ed\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5938371\nTested-by: Harry Cutts \u003chcutts@chromium.org\u003e\nReviewed-by: Kenneth Albanowski \u003ckenalba@google.com\u003e\nCommit-Queue: Harry Cutts \u003chcutts@chromium.org\u003e\nAuto-Submit: Harry Cutts \u003chcutts@chromium.org\u003e\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\n" }, { "commit": "9cd1400773ceccd2cbad3c5d0a2a28015ae1619b", "tree": "6d376e20c0cf608f22d6413a3014ad9db450b0a9", "parents": [ "0095adf1024d6bbcf047d8cf20df99dde2ba18d1" ], "author": { "name": "Saketh Pothireddy", "email": "spothire@google.com", "time": "Wed Sep 18 23:20:27 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Sep 26 23:28:06 2024 +0000" }, "message": "Enable c++20\n\nBUG\u003db:217226507\nTEST\u003dFEATURES\u003dtest emerge-brya gestures\nTEST\u003dDeploy to fleet dut and click around\nTEST\u003dOn Android:\n $ m libchrome-gestures\n $ atest libchrome-gestures_test\n\nCq-Depend: 5871998\nChange-Id: If2f80c753227dd22f7f41f78d224fd9a09f85c63\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5873886\nTested-by: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nCommit-Queue: Saketh Pothireddy \u003cspothire@google.com\u003e\nReviewed-by: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nTested-by: Harry Cutts \u003chcutts@chromium.org\u003e\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\nCode-Coverage: Saketh Pothireddy \u003cspothire@google.com\u003e\n" }, { "commit": "0095adf1024d6bbcf047d8cf20df99dde2ba18d1", "tree": "1ad6acf2e47c2ba17c1147dd245116d62b36bc95", "parents": [ "f4e03756d993701f63a3d966873c3db90931ac8b" ], "author": { "name": "seobrien", "email": "seobrien@chromium.org", "time": "Fri Sep 06 19:58:00 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Sep 16 20:41:28 2024 +0000" }, "message": "Allow finger lock to switch to a new finger\n\nWhen there are multiple fingers on the touchpad and the user is not\nperforming a multi-finger gesture, we will \"lock on\" to a single finger\nto follow for motion tracking. Sometimes, we will accidentally lock on\nto the wrong finger, such as a thumb that seems to be moving quickly,\nbut really isn\u0027t.\n\nThis CL adds a mechanism to change which finger is being tracked after\nthe initial lock, if another finger is moving fast enough.\n\nBUG\u003db:358206010\nTEST\u003dCQ, manual testing, new touchtest regression tests\n\nChange-Id: I96d69fc392231366f0f06a29db98ffc29d021675\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5841662\nReviewed-by: Henry Barnor \u003chbarnor@chromium.org\u003e\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\nCommit-Queue: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nTested-by: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\n" }, { "commit": "f4e03756d993701f63a3d966873c3db90931ac8b", "tree": "ea8180d02d553a735be3fba338a9691a63e811e8", "parents": [ "b1640b40fe62f9ae9a991e8a4674ee9e991dbc99" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Fri Aug 30 17:15:35 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Sep 02 10:15:07 2024 +0000" }, "message": "Make HardwareState strings nicer to read\n\nPreviously, HardwareState string representations were something of a\nnumber salad, something like this:\n\n { 1.234567, 0, 1, 1, { { 267.000000, 187.000000, 0.000000, 0.000000,\n 26.000000, 86.000000, 992.000000, 706.000000, 220,\n GESTURES_FINGER_POSSIBLE_PALM | GESTURES_FINGER_WARP_X_NON_MOVE } } }\n\nYou just had to remember what number meant what. Now they look like\nthis:\n\n { 1.234567, buttons 0x0, 1 f, 1 t, { { 220: (992.00, 706.00), touch\n 267.00x187.00, width 0.00x0.00, pressure 26.00, orient 86.00,\n POSSIBLE_PALM | WARP_X_NON_MOVE } } }\n\nChanges:\n\n* Related numbers (e.g. X and Y, touch major and minor) are grouped\n together\n* Fields are labelled\n* Numbers take up less space by reducing precision (6 decimal places\n seems a little excessive)\n* Flags no longer have the GESTURES_FINGER_ prefix, which is common to\n all of them anyway\n\nBUG\u003db:245989146\nTEST\u003dOn Android, run:\n $ adb shell \u0027stop \u0026\u0026 setprop log.tag.TouchpadInputMapperGestures\n DEBUG \u0026\u0026 start\u0027\n then check the InputReader log tag for the \"New hardware state\"\n messages. Also run unit tests:\n $ atest libchrome-gestures_test\n\nChange-Id: I89c72b29cfcbbb11c54c25b9bed59fdf9420b321\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5829402\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\nTested-by: Harry Cutts \u003chcutts@chromium.org\u003e\nReviewed-by: William Mahon \u003cwmahon@google.com\u003e\nCommit-Queue: Harry Cutts \u003chcutts@chromium.org\u003e\n" }, { "commit": "e62febbcdf3c6d1dc94cad40941ec7c368efc731", "tree": "8590d67c6d8d9521fdc70dd592e102bb317e7915", "parents": [ "14669b4535bc44f07e3105ff097934f60a801f45", "1ef73409afe127fa1271f29f25d4f2f3f7a3127b" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Mon Sep 02 08:37:44 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Sep 02 08:37:44 2024 +0000" }, "message": "Merge clickdown movement timeout change from upstream am: 1fc7f6b6df am: 1ef73409af\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/3250863\n\nChange-Id: I60d393e7a34195deb5a09d33481f1dc7db065661\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "1ef73409afe127fa1271f29f25d4f2f3f7a3127b", "tree": "8590d67c6d8d9521fdc70dd592e102bb317e7915", "parents": [ "d7761c7570a5eb1ca14fced6810ed19c2ebe1b18", "1fc7f6b6df00450afcea86343e1f34fd6b4afbbd" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Mon Sep 02 08:16:38 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Sep 02 08:16:38 2024 +0000" }, "message": "Merge clickdown movement timeout change from upstream am: 1fc7f6b6df\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/3250863\n\nChange-Id: I9ed1df50bdd649c39bff2c1ba7aaf2ffe809d6bb\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "1fc7f6b6df00450afcea86343e1f34fd6b4afbbd", "tree": "8590d67c6d8d9521fdc70dd592e102bb317e7915", "parents": [ "9646efd8723fb45deb9368f32f96ca5e16776380", "b1640b40fe62f9ae9a991e8a4674ee9e991dbc99" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Fri Aug 30 16:20:49 2024 +0000" }, "committer": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Fri Aug 30 16:24:06 2024 +0000" }, "message": "Merge clickdown movement timeout change from upstream\n\nThis also includes a fix for fling velocity calculation, but that won\u0027t\naffect Android since we don\u0027t use the library\u0027s calculated fling\nvelocities.\n\nBug: 296062250\nBug: 280345884\nTest: manual testing of all gestures (cursor movement, button click,\n tap-to-click, two- to four-finger swipes, pinch) with an Apple\n Magic Trackpad 2 connected to a Pixel Tablet.\nTest: Treehugger\nFlag: EXEMPT library uprev\nChange-Id: I70cf7f046595b6d1e6b3ced65de0b109c1520d2d\n" }, { "commit": "b1640b40fe62f9ae9a991e8a4674ee9e991dbc99", "tree": "1860e1d52750203e4bd5bbeb6cb8f823627a553b", "parents": [ "0d78696da9addfcbbe7c0d625af184c23c4c9038" ], "author": { "name": "seobrien", "email": "seobrien@chromium.org", "time": "Fri Aug 23 20:38:23 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Aug 29 20:45:05 2024 +0000" }, "message": "Fix time delta calculation in scroll buffer\n\nWhen calculating fling velocity, we use the average velocity of the last\nseveral scroll events. However, zero-distance scrolls are not included\nin the buffer, which can skew the velocity, especially if the touchpad\nreports MSC_TIMESTAMP events when no finger has moved.\n\nThis CL addresses that by keeping track of the time delta from the\nlatest scroll event in the scroll buffer for calculating velocity,\ninstead of just the delta between touchpad reports, which will always be\nvery small if the touchpad reports MSC_TIMESTAMP.\n\nBUG\u003db:358209681\nTEST\u003dunittests, touchtests regression suite, manual testing\n\nChange-Id: I41db2867f4d50021f713350470e85f2d453af51e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5806234\nTested-by: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nReviewed-by: Henry Barnor \u003chbarnor@chromium.org\u003e\nAuto-Submit: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nCommit-Queue: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\n" }, { "commit": "0d78696da9addfcbbe7c0d625af184c23c4c9038", "tree": "54790529032ea559eeb9261c6fb9adb20ac3d962", "parents": [ "37ea1f507f33ed85303a3f66b483f16c04593fcf" ], "author": { "name": "seobrien", "email": "seobrien@chromium.org", "time": "Wed Aug 07 20:56:51 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Aug 09 21:41:27 2024 +0000" }, "message": "Change clickdown movement timeout to 250ms\n\nEvidence from user studies indicates that 250ms is a good compromise to\nincrease reactivity for click-drag gestures without introducing many\naccidental click-drags.\n\nBUG\u003db:296062250\nTEST\u003dbuild and deploy, touchtest regression suite.\n\nChange-Id: Ie431680778e06e33da5eab11cd7331bfb9be6716\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5769880\nTested-by: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nReviewed-by: Jingyuan Liang \u003cjingyliang@chromium.org\u003e\nCommit-Queue: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\n" }, { "commit": "14669b4535bc44f07e3105ff097934f60a801f45", "tree": "8cba1661b47b8415533f69a4ef453bc9553c1b9d", "parents": [ "51495cbc148fdee38de16e28e3d81360178ecd16", "d7761c7570a5eb1ca14fced6810ed19c2ebe1b18" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Fri Aug 09 17:55:25 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Fri Aug 09 17:55:25 2024 +0000" }, "message": "Merge clean-ups from upstream am: 9646efd872 am: d7761c7570\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/3213800\n\nChange-Id: I97176ba9ac5e60eaad12beade6fbb2f306728df9\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "d7761c7570a5eb1ca14fced6810ed19c2ebe1b18", "tree": "8cba1661b47b8415533f69a4ef453bc9553c1b9d", "parents": [ "51495cbc148fdee38de16e28e3d81360178ecd16", "9646efd8723fb45deb9368f32f96ca5e16776380" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Fri Aug 09 17:36:01 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Fri Aug 09 17:36:01 2024 +0000" }, "message": "Merge clean-ups from upstream am: 9646efd872\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/3213800\n\nChange-Id: I285acb20434879f0302532618bc77fd347d0d112\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "9646efd8723fb45deb9368f32f96ca5e16776380", "tree": "8cba1661b47b8415533f69a4ef453bc9553c1b9d", "parents": [ "b45a741fc3ff0d736b3412de04c09c5bf5577dd4", "37ea1f507f33ed85303a3f66b483f16c04593fcf" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Fri Aug 09 13:44:53 2024 +0000" }, "committer": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Fri Aug 09 13:47:30 2024 +0000" }, "message": "Merge clean-ups from upstream\n\nBug: 245989146\nBug: 260071241\nTest: Treehugger\n\nChange-Id: I2618659657a7ac50276846388a40e3f246f7c9ca\n" }, { "commit": "37ea1f507f33ed85303a3f66b483f16c04593fcf", "tree": "f3e2569d888136b98bade5dd424b2fa8e99d40be", "parents": [ "57c6e0045e70912a5a0489458b68eb05ec8802e8" ], "author": { "name": "George Burgess IV", "email": "gbiv@google.com", "time": "Wed Jul 31 15:15:48 2024 -0600" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Aug 02 19:25:45 2024 +0000" }, "message": "tests: remove uses of variable length arrays\n\nVLAs are generally discouraged, to the point where Clang now warns about\nthem by default. Since these already have obvious upper-bounds present\nand enforced, leverage those.\n\nBUG\u003db:316021385\nTEST\u003dFEATURES\u003dtest emerge-brya gestures\n\nChange-Id: Iaf3d7ac0198e8ad5894f56fcdf4bcfea3bb45c80\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5754535\nTested-by: George Burgess \u003cgbiv@chromium.org\u003e\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\nReviewed-by: Kenneth Albanowski \u003ckenalba@google.com\u003e\nCommit-Queue: George Burgess \u003cgbiv@chromium.org\u003e\n" }, { "commit": "57c6e0045e70912a5a0489458b68eb05ec8802e8", "tree": "b111cda653496bcebbc980db26592ddcae0d2175", "parents": [ "25e77a6998f90e046117b894016304e2b905042c" ], "author": { "name": "Saketh Pothireddy", "email": "spothire@google.com", "time": "Sat Mar 23 01:06:26 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri May 24 22:28:44 2024 +0000" }, "message": "gestures: remove screen_x/y_dpi\n\nRemove deprecated `screen_x_dpi` and `screen_y_dpi` fields from\n`HardwareProperties` struct.\n\nBUG\u003db:260071241\nTEST\u003d`FEATURES\u003dtest emerge-brya gestures`\n\nCq-Depend: 5434142\nChange-Id: I19dbd33c6430f782445cc7737b498b66114c0767\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5436195\nReviewed-by: Henry Barnor \u003chbarnor@chromium.org\u003e\nCommit-Queue: Saketh Pothireddy \u003cspothire@google.com\u003e\nReviewed-by: Torsha Banerjee \u003ctorsha@google.com\u003e\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\nTested-by: Torsha Banerjee \u003ctorsha@google.com\u003e\nTested-by: Saketh Pothireddy \u003cspothire@google.com\u003e\n" }, { "commit": "51495cbc148fdee38de16e28e3d81360178ecd16", "tree": "80174cb1645877863c3d48298a5683a8adc109a0", "parents": [ "f6d9f879f01775f0e13037195c7a0ee18f31cd5e", "b45a741fc3ff0d736b3412de04c09c5bf5577dd4" ], "author": { "name": "Xin Li", "email": "delphij@google.com", "time": "Mon Apr 29 21:50:05 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Apr 29 21:50:05 2024 +0000" }, "message": "[automerger skipped] Empty merge of Android 24Q2 Release (ab/11526283) to aosp-main-future am: b45a741fc3 -s ours\n\nam skip reason: Merged-In I4a3327068a23c18e123088a5da9a2580ceee83ee with SHA-1 3b1cf4abca is already in history\n\nOriginal change: https://googleplex-android-review.googlesource.com/c/platform/external/libchrome-gestures/+/27144991\n\nChange-Id: I88c3a0aef9d3453c4f4c9288b377cf9e650fbad9\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "b45a741fc3ff0d736b3412de04c09c5bf5577dd4", "tree": "80174cb1645877863c3d48298a5683a8adc109a0", "parents": [ "3b1cf4abca9eadc3d416f9621ddceb38aefdcd59", "d852491a77d2ab9c652977ffae699807d0e8912a" ], "author": { "name": "Xin Li", "email": "delphij@google.com", "time": "Mon Apr 29 11:49:58 2024 -0700" }, "committer": { "name": "Xin Li", "email": "delphij@google.com", "time": "Mon Apr 29 11:49:58 2024 -0700" }, "message": "Empty merge of Android 24Q2 Release (ab/11526283) to aosp-main-future\n\nBug: 337098550\nMerged-In: I4a3327068a23c18e123088a5da9a2580ceee83ee\nChange-Id: I6dea0aa13f681a2568ee0a52a09ca5c650031d62\n" }, { "commit": "25e77a6998f90e046117b894016304e2b905042c", "tree": "2bde7d8bd999998fe2614336278a9450079220c1", "parents": [ "b824af1e782a4e741fbfe4b0c311de3bc161e2fc" ], "author": { "name": "Saketh Pothireddy", "email": "spothire@google.com", "time": "Fri Apr 05 20:16:12 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Apr 08 19:57:31 2024 +0000" }, "message": "gestures: fix chroot path to touchpad-tests\n\nCorrect path to touchpad-tests when installing regression tests. In my\nenvironment this path does not exist, causing `pushd` to fail. However,\nthe following `make` commands run in `gestures` dir creating a few\nobjects. Correcting the path afterwards and re-running this script\ncauses linker issues since `make in-place` is called without a clean.\n\nBUG\u003db:325269580\nTEST\u003dCreate and push a new commit on fresh checkout with this change.\n\nChange-Id: Idcbbb5302fdf98e7abf1e9f47634d2bf645698b6\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5426747\nReviewed-by: Torsha Banerjee \u003ctorsha@google.com\u003e\nCode-Coverage: Saketh Pothireddy \u003cspothire@google.com\u003e\nTested-by: Saketh Pothireddy \u003cspothire@google.com\u003e\nCode-Coverage: William Mahon \u003cwmahon@google.com\u003e\nReviewed-by: William Mahon \u003cwmahon@google.com\u003e\nCommit-Queue: Saketh Pothireddy \u003cspothire@google.com\u003e\n" }, { "commit": "f6d9f879f01775f0e13037195c7a0ee18f31cd5e", "tree": "80174cb1645877863c3d48298a5683a8adc109a0", "parents": [ "cfcbb280d49b5ddc886c3e1e7842ab45ceca5812", "3b1cf4abca9eadc3d416f9621ddceb38aefdcd59" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Wed Mar 13 22:01:23 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Mar 13 22:01:23 2024 +0000" }, "message": "Merge various clean-ups from upstream am: 6ec93b19a1 am: 3b1cf4abca\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/3000361\n\nChange-Id: Idd7d71c077125a479c3032f3ecd703977466b535\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "3b1cf4abca9eadc3d416f9621ddceb38aefdcd59", "tree": "80174cb1645877863c3d48298a5683a8adc109a0", "parents": [ "6778ccd6cff4630e16753538e2b6c51d821401ae", "6ec93b19a1b8ed00a228299db08c33fbed268d7e" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Wed Mar 13 21:44:21 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Mar 13 21:44:21 2024 +0000" }, "message": "Merge various clean-ups from upstream am: 6ec93b19a1\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/3000361\n\nChange-Id: I4a3327068a23c18e123088a5da9a2580ceee83ee\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "6ec93b19a1b8ed00a228299db08c33fbed268d7e", "tree": "80174cb1645877863c3d48298a5683a8adc109a0", "parents": [ "0e7b5cb11ffdf27df6e5ef512fb71a9e134ecc9a", "b824af1e782a4e741fbfe4b0c311de3bc161e2fc" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Wed Mar 13 15:10:32 2024 +0000" }, "committer": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Wed Mar 13 15:26:07 2024 +0000" }, "message": "Merge various clean-ups from upstream\n\nThe only functionality change here is to mouse scroll handling, which\nwon\u0027t affect Android as we don\u0027t use the library for mice. The other\nchanges are assorted cleanups including for variable-length array\nissues, address sanitizer crashes, and various other small code issues.\n\nBug: 314743031\nTest: Treehugger\nChange-Id: I8655f873a13a9ba3b8ef437246c0c368f8bd1b76\n" }, { "commit": "b824af1e782a4e741fbfe4b0c311de3bc161e2fc", "tree": "324e8e9f95bc24aa75c77bbc58186453367e2a47", "parents": [ "8fa2ecca2f4a5f08f58d9a75dc712dcb1d8ba4c8" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Mon Mar 11 15:05:31 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Mar 13 13:08:50 2024 +0000" }, "message": "Upgrade some Log calls to Err\n\nThese all indicate states that we shouldn\u0027t get into, so they should be\nlogged with the higher severity level.\n\nBUG\u003db:314743031\nTEST\u003drun unit tests\nLOW_COVERAGE_REASON\u003donly modifies logging for unexpected cases\n\nChange-Id: If503b726511082d16c52858cf62291cc00926b16\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5358098\nCommit-Queue: Harry Cutts \u003chcutts@chromium.org\u003e\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\nTested-by: Harry Cutts \u003chcutts@chromium.org\u003e\nReviewed-by: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nCode-Coverage: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\n" }, { "commit": "8fa2ecca2f4a5f08f58d9a75dc712dcb1d8ba4c8", "tree": "bc48d2af242716637423a6f891f2df48dfac63c1", "parents": [ "04226b4be33db372a735ccff4c10602c7d349a9f" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Tue Mar 12 16:55:59 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Mar 13 13:08:47 2024 +0000" }, "message": "NonLinearity: don\u0027t try to load data if path unset\n\nPreviously, if no data file path was set in the gesture property, we\u0027d\ntry to load a file called \"None\" (the default property value), and\n(hopefully) that would fail. If there happened to be a file called\n\"None\" in the current directory we\u0027d try to load it as non-linearity\ncorrection data. Otherwise, we\u0027d log an error because of the file\nloading failure even though we hadn\u0027t expected to find a data file.\n\nBUG\u003db:314743031\nTEST\u003dunit tests; add the NonLinearityFilterInterpreter to the Touchpad2\n stack in gestures.cc, add a log line when attempting to load a\n file, and check the line doesn\u0027t appear a touchpad is connected\n\nChange-Id: I010086adbf2b6ca69bda32c8c69fc00a239e5a20\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5365863\nCommit-Queue: Harry Cutts \u003chcutts@chromium.org\u003e\nReviewed-by: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nTested-by: Harry Cutts \u003chcutts@chromium.org\u003e\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\n" }, { "commit": "04226b4be33db372a735ccff4c10602c7d349a9f", "tree": "4122b0619e7bf3184a5566f1346b6806807abc80", "parents": [ "2ad23eb4021a824dd6ae2ca5d84dfa7701a4a4da" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Fri Mar 08 15:03:27 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Mar 12 16:00:41 2024 +0000" }, "message": "ImmediateInterpreter: use range-for loops\n\nThese are less verbose, easier to read, and allow more descriptive\nidentifiers to be used compared to it-\u003efirst and it-\u003esecond.\n\nBUG\u003db:245989146\nTEST\u003dcheck cursor movements and gestures manually; run unit tests\n\nChange-Id: I02d9021faa9818926c8cff4c2d7852f8d416dda0\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5358097\nCommit-Queue: Harry Cutts \u003chcutts@chromium.org\u003e\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\nReviewed-by: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nTested-by: Harry Cutts \u003chcutts@chromium.org\u003e\n" }, { "commit": "cfcbb280d49b5ddc886c3e1e7842ab45ceca5812", "tree": "1a5fbbe0b0b18fc82b95167539cd5b603e1acb64", "parents": [ "d852491a77d2ab9c652977ffae699807d0e8912a", "6778ccd6cff4630e16753538e2b6c51d821401ae" ], "author": { "name": "Xin Li", "email": "delphij@google.com", "time": "Thu Mar 07 10:46:42 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Mar 07 10:46:42 2024 +0000" }, "message": "[automerger skipped] Merge Android 14 QPR2 to AOSP main am: 0e7b5cb11f -s ours am: 6778ccd6cf -s ours\n\nam skip reason: Merged-In I30aaa1cc50a2b92af1cd0f5e54ad252233178c37 with SHA-1 8c8a497e1c is already in history\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2990852\n\nChange-Id: I6043377bcf334ef2139c31c298840316a71f6582\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "6778ccd6cff4630e16753538e2b6c51d821401ae", "tree": "1a5fbbe0b0b18fc82b95167539cd5b603e1acb64", "parents": [ "8c8a497e1c15be2d92fb811243c9aeb5d8d12f2c", "0e7b5cb11ffdf27df6e5ef512fb71a9e134ecc9a" ], "author": { "name": "Xin Li", "email": "delphij@google.com", "time": "Thu Mar 07 09:55:17 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Mar 07 09:55:17 2024 +0000" }, "message": "[automerger skipped] Merge Android 14 QPR2 to AOSP main am: 0e7b5cb11f -s ours\n\nam skip reason: Merged-In I30aaa1cc50a2b92af1cd0f5e54ad252233178c37 with SHA-1 8c8a497e1c is already in history\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2990852\n\nChange-Id: I624eb2a98027d5bb5a8b7e0429e3af80b6feed1a\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "0e7b5cb11ffdf27df6e5ef512fb71a9e134ecc9a", "tree": "1a5fbbe0b0b18fc82b95167539cd5b603e1acb64", "parents": [ "ff1aa200b87ad5497d844a9a41c9756f7deb28b4", "8c8a497e1c15be2d92fb811243c9aeb5d8d12f2c" ], "author": { "name": "Xin Li", "email": "delphij@google.com", "time": "Wed Mar 06 09:29:54 2024 -0800" }, "committer": { "name": "Xin Li", "email": "delphij@google.com", "time": "Wed Mar 06 09:29:54 2024 -0800" }, "message": "Merge Android 14 QPR2 to AOSP main\n\nBug: 319669529\nMerged-In: I30aaa1cc50a2b92af1cd0f5e54ad252233178c37\nChange-Id: I9e92deded4ae33fa880454680ad101b6c5dd0b1d\n" }, { "commit": "2ad23eb4021a824dd6ae2ca5d84dfa7701a4a4da", "tree": "1fe704bb9cffc5ad4a98918d1dfddc0f7d0ca430", "parents": [ "50caac3b9e1a04ca2c67c2f226657c7f90d687b5" ], "author": { "name": "Harry Cutts", "email": "hcutts@chromium.org", "time": "Thu Feb 22 17:14:07 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 04 17:57:38 2024 +0000" }, "message": "string_util: simplify TrimWhitespaceASCII\n\nNo callers of the function passed anything other than TRIM_ALL, looked\nat the return value, or needed to pass a pointer for the output, so\nremove those features and improve the tests.\n\nBUG\u003db:245989146\nTEST\u003dcros_sdk env FEATURES\u003d\"test\" emerge-${BOARD} chromeos-base/gestures\n\nChange-Id: Iec25ef20fdafc16bd5e23dc1e6744fdbc439b865\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5318732\nReviewed-by: Henry Barnor \u003chbarnor@chromium.org\u003e\nReviewed-by: Kenneth Albanowski \u003ckenalba@google.com\u003e\nReviewed-by: Torsha Banerjee \u003ctorsha@google.com\u003e\nTested-by: Harry Cutts \u003chcutts@chromium.org\u003e\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\nCommit-Queue: Harry Cutts \u003chcutts@chromium.org\u003e\n" }, { "commit": "50caac3b9e1a04ca2c67c2f226657c7f90d687b5", "tree": "613a535e99939037ace6c829739a8a9051d3672a", "parents": [ "8cc26f2e4b77a2abd91db5413453eeed737cad28" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Thu Feb 22 16:17:16 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 04 17:57:35 2024 +0000" }, "message": "string_util: Remove StartsWithASCII\n\nThis was used in exactly one location, FingerState::FlagsString, and can\neasily be replaced by a call to std::string::rfind. Also add a new test\ncase to verify the change.\n\nBUG\u003db:245989146\nTEST\u003dcros_sdk env FEATURES\u003d\"test\" emerge-${BOARD} chromeos-base/gestures\n\nChange-Id: I832dd9a7cb61b3a4741d2a3439b4884746274f3b\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5318731\nCommit-Queue: Harry Cutts \u003chcutts@chromium.org\u003e\nTested-by: Harry Cutts \u003chcutts@chromium.org\u003e\nReviewed-by: Aseda Aboagye \u003caaboagye@chromium.org\u003e\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\nReviewed-by: Henry Barnor \u003chbarnor@chromium.org\u003e\n" }, { "commit": "8cc26f2e4b77a2abd91db5413453eeed737cad28", "tree": "b4fb7dfa2e42f72940a31e77183ad405a064f990", "parents": [ "fea3ca4ec92fbbe738b2c6f1fc512c08467fc291" ], "author": { "name": "William Mahon", "email": "wmahon@google.com", "time": "Thu Feb 22 01:45:49 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Feb 26 22:10:36 2024 +0000" }, "message": "gestures: Move metrics finger tracking to std::vector\n\nFingerMetrics currently uses a custom vector with a fixed size to track\ncurrently touching fingers. Replace this customer vector with\nstd::vector to track an indefinite number of fingers.\n\nBUG\u003db:322173064\nTEST\u003dDeployed to DUT and tested with trackpad that would otherwise\ngenerate \"out of space\" error.\n\nChange-Id: I362b75847b6753f2fac9d2e076727cabe129f12a\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5320049\nReviewed-by: Henry Barnor \u003chbarnor@chromium.org\u003e\nCommit-Queue: William Mahon \u003cwmahon@google.com\u003e\nTested-by: William Mahon \u003cwmahon@google.com\u003e\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\nReviewed-by: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\n" }, { "commit": "fea3ca4ec92fbbe738b2c6f1fc512c08467fc291", "tree": "c0bf262d0580af0cfd39fb322442a4466477761d", "parents": [ "51930785d8c96bde83b5a2c6530f793099309449" ], "author": { "name": "Harry Cutts", "email": "hcutts@chromium.org", "time": "Thu Feb 22 20:09:15 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Feb 23 17:47:23 2024 +0000" }, "message": "Include Address Sanitizer when sanitizers are enabled\n\nIn practice, this is just when running unit tests.\n\nBUG\u003db:318520168\nTEST\u003dadd -fsanitize\u003daddress to compiler flags, run unit tests [0], and\n check no address sanitization failures are reported\n\n[0]: cros_sdk env FEATURES\u003d\"test\" emerge-${BOARD} chromeos-base/gestures\n\nChange-Id: Ifd8c335413238a1c0477100532a575d049a76261\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5318358\nTested-by: Harry Cutts \u003chcutts@chromium.org\u003e\nReviewed-by: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nCommit-Queue: Harry Cutts \u003chcutts@chromium.org\u003e\nCode-Coverage: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\n" }, { "commit": "51930785d8c96bde83b5a2c6530f793099309449", "tree": "f32484b6229d74aa41688657800c3c533dda9d88", "parents": [ "8c21303fa6066e51d9de549817ed1ef66943a510" ], "author": { "name": "Harry Cutts", "email": "hcutts@chromium.org", "time": "Thu Feb 22 20:07:14 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Feb 23 17:47:21 2024 +0000" }, "message": "immediate_interpreter_unittest: fix memory leaks\n\nA few pointers held in local variables weren\u0027t getting deallocated after\nuse. The objects don\u0027t need to be on the heap anyway, so put them on the\nstack instead.\n\nBUG\u003db:318520168\nTEST\u003dadd -fsanitize\u003daddress to compiler flags, run unit tests [0], and\n check no address sanitization failures are reported\n\n[0]: cros_sdk env FEATURES\u003d\"test\" emerge-${BOARD} chromeos-base/gestures\n\nChange-Id: I5ec6ef00e2fcc8d050adc9885719d0d1af305c1e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5318357\nTested-by: Harry Cutts \u003chcutts@chromium.org\u003e\nCode-Coverage: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nReviewed-by: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nCommit-Queue: Harry Cutts \u003chcutts@chromium.org\u003e\n" }, { "commit": "8c21303fa6066e51d9de549817ed1ef66943a510", "tree": "1471361400df0ab33750907d044df9a0304c9ddf", "parents": [ "f735f3e2e18c7f1383a742c1bdeec887ebba5670" ], "author": { "name": "Harry Cutts", "email": "hcutts@chromium.org", "time": "Thu Feb 22 18:51:12 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Feb 23 17:47:19 2024 +0000" }, "message": "interpreter_unittest: fix memory leaks\n\nExcept for a few manual changes in SimpleTest around base_interpreter2,\nthis CL was is the result of the following Vim substitutions:\n\n %s/\\([a-zA-Z]\\+\\)\\* base_interpreter \u003d\\n\\?\\s*new \\1(/\\1 base_interpreter(\n %s/base_interpreter();/base_interpreter;\n %s/base_interpreter-\u003e/base_interpreter./g\n %s/TestInterpreterWrapper wrapper(base_interpreter);/TestInterpreterWrapper wrapper(\\\u0026base_interpreter);\n\nBUG\u003db:318520168\nTEST\u003dadd -fsanitize\u003daddress to compiler flags, run unit tests [0], and\n check no address sanitization failures are reported from\n interpreter_unittest.cc\n\n[0]: cros_sdk env FEATURES\u003d\"test\" emerge-${BOARD} chromeos-base/gestures\n\nChange-Id: Id4148d8264e6260bce4b0d16c15d5f54ed944ea6\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5318356\nTested-by: Harry Cutts \u003chcutts@chromium.org\u003e\nReviewed-by: Henry Barnor \u003chbarnor@chromium.org\u003e\nReviewed-by: Kenneth Albanowski \u003ckenalba@google.com\u003e\nCode-Coverage: Henry Barnor \u003chbarnor@chromium.org\u003e\nCommit-Queue: Harry Cutts \u003chcutts@chromium.org\u003e\n" }, { "commit": "f735f3e2e18c7f1383a742c1bdeec887ebba5670", "tree": "9123a834c99614803e174bff86b517aed4acb53e", "parents": [ "a923bceb79cfac0c4e9ee46482c317c004ee0f32" ], "author": { "name": "Harry Cutts", "email": "hcutts@chromium.org", "time": "Thu Feb 22 19:47:48 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Feb 23 17:47:17 2024 +0000" }, "message": "prop_registry: fix memory leak of Json::Values\n\nUsing new in BoolArrayProperty::NewValue was allocating the values on\nthe heap but then immediately casting them to a reference that was\nstd::moved into the list, meaning that there was no way to deallocate\nthe Json::Values later. This appears to have been a one-off mistake, as\nthe similar code in DoubleArrayProperty::NewValue and\nIntArrayProperty::NewValue create Json::Values and pass them as r-value\nreferences, which is the fix here also.\n\nThis was detected by Address Sanitizer running PropRegistryTest\nBoolArrayTest.\n\nBUG\u003db:318520168\nTEST\u003dadd -fsanitize\u003daddress to compiler flags, run unit tests [0], and\n check no address sanitization failures are reported from\n prop_registry_unittest.cc\n\n[0]: cros_sdk env FEATURES\u003d\"test\" emerge-${BOARD} chromeos-base/gestures\n\nChange-Id: Ifb40b04be26521ebb32caacb22376bd471b25f29\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5318355\nTested-by: Harry Cutts \u003chcutts@chromium.org\u003e\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\nCommit-Queue: Harry Cutts \u003chcutts@chromium.org\u003e\nReviewed-by: Kenneth Albanowski \u003ckenalba@google.com\u003e\nReviewed-by: Torsha Banerjee \u003ctorsha@google.com\u003e\n" }, { "commit": "a923bceb79cfac0c4e9ee46482c317c004ee0f32", "tree": "ffa8b2ca6dbcc8cbafe45636612adecf7a7500b4", "parents": [ "89e5629b7f2d92f66b2b15c326355aa7143b8d5f" ], "author": { "name": "Harry Cutts", "email": "hcutts@chromium.org", "time": "Wed Feb 21 17:23:55 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Feb 22 22:21:42 2024 +0000" }, "message": "Move SplitString util into activity_replay_unittest.cc\n\nThe test for SplitString causes crashes deep within the C++ standard\nlibrary when the address sanitizer is enabled. Since it\u0027s only used in\none (disabled-by-default) test method, just move it into that file so\nthat it\u0027s no longer considered \"production\" code that needs test\ncoverage.\n\nIdeally, if we still need this \"test\" (which appears to actually be code\nfor an old developer tool, tools/replay_log) and the ability to pass the\n--only_honor flag, we\u0027d refactor SplitString to use C++ std::string\nmethods, but since I\u0027m not sure the replay_log tool will actually run at\nthe moment, I don\u0027t think it\u0027s worth investing the time unless we decide\nwe want it. I\u0027ve filed https://issuetracker.google.com/326088876 to\ntrack this issue.\n\nBUG\u003db:318520168\nTEST\u003dcros_sdk env FEATURES\u003d\"test\" emerge-${BOARD} chromeos-base/gestures\n\nChange-Id: I24632c2a78fcdba3fed27eadb981f0af5bb737e9\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5318730\nCommit-Queue: Harry Cutts \u003chcutts@chromium.org\u003e\nReviewed-by: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\nTested-by: Harry Cutts \u003chcutts@chromium.org\u003e\n" }, { "commit": "89e5629b7f2d92f66b2b15c326355aa7143b8d5f", "tree": "dc22677f6d7af0007865a04c5e1bb91040bf6da7", "parents": [ "a216de6f779dc917f6f53302c4f353117d6159d2" ], "author": { "name": "Harry Cutts", "email": "hcutts@chromium.org", "time": "Wed Feb 14 12:21:26 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Feb 21 13:09:54 2024 +0000" }, "message": "Enable Undefined Behaviour Sanitizer when running tests\n\nThis sanitizer is already enabled on Android. When Android upgrades to\nthe latest version of the library, we often discover sanitizer crashes\nand have to fix them all at once before we can upgrade. Enabling more\nsanitizers in the ChromeOS build should detect these crashes before\nthey\u0027re submitted into the ChromeOS tree.\n\nWe\u0027d like to enable the sanitizers in all builds, but because of the\ncrashes that could be caused that\u0027ll take a more considered rollout\nstrategy. For now, enabling them when running unit tests is a good\nstart.\n\nBUG\u003db:318520168\nTEST\u003dAdd an integer overflow problem (int32_t k \u003d 0x7fffffff; k++;) in\n the DistSq util function, run the unit tests [0], and check the\n UtilTest DistSqTest crashes with a suitable UBSan error.\n\n[0]: cros_sdk env FEATURES\u003d\"test\" emerge-${BOARD} chromeos-base/gestures\n\nChange-Id: I9677376f5500f5434198e17f540d173e0a9317a9\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5296935\nTested-by: Harry Cutts \u003chcutts@chromium.org\u003e\nCommit-Queue: Harry Cutts \u003chcutts@chromium.org\u003e\nReviewed-by: Aseda Aboagye \u003caaboagye@chromium.org\u003e\nReviewed-by: Henry Barnor \u003chbarnor@chromium.org\u003e\nCode-Coverage: Henry Barnor \u003chbarnor@chromium.org\u003e\n" }, { "commit": "a216de6f779dc917f6f53302c4f353117d6159d2", "tree": "c3600206341cc77fd7357838450ed1f3b2c5f0ed", "parents": [ "4e0bb4587f6193814a8c54bfad689e4de11716d5" ], "author": { "name": "Harry Cutts", "email": "hcutts@chromium.org", "time": "Wed Feb 14 17:16:12 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Feb 20 16:19:27 2024 +0000" }, "message": "Makefile: remove -DXLOGGING compiler flag\n\nThis was added back in 2011 (https://crrev.com/c/4137) in conjunction\nwith moving the library to use the X11 xf86MsgVerb logging function\n(which avoided uses of malloc, a source of issues on X11 at the time).\nWe no longer use this logging function, and the library is no longer\nused with X11 display servers, so we should be able to remove this now.\n\nBUG\u003dNone\nTEST\u003dcros_sdk env FEATURES\u003d\"test\" emerge-${BOARD} chromeos-base/gestures\n\nChange-Id: I24bf883ffde2f488181e767cf0bb4e457f48124b\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5297055\nCommit-Queue: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nReviewed-by: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nTested-by: Harry Cutts \u003chcutts@chromium.org\u003e\nAuto-Submit: Harry Cutts \u003chcutts@chromium.org\u003e\nCode-Coverage: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\n" }, { "commit": "d852491a77d2ab9c652977ffae699807d0e8912a", "tree": "1a5fbbe0b0b18fc82b95167539cd5b603e1acb64", "parents": [ "4db7a3fb3b3970fe67f0c78e9155a74b885671a3", "8c8a497e1c15be2d92fb811243c9aeb5d8d12f2c" ], "author": { "name": "Xin Li", "email": "delphij@google.com", "time": "Wed Jan 31 02:02:51 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Jan 31 02:02:51 2024 +0000" }, "message": "[automerger skipped] Merge Android 24Q1 Release (ab/11220357) am: 8c8a497e1c -s ours\n\nam skip reason: Merged-In Ic7c11e6bab7584bd7acde43ae79f2ea68275333c with SHA-1 db45778f56 is already in history\n\nOriginal change: https://googleplex-android-review.googlesource.com/c/platform/external/libchrome-gestures/+/25973900\n\nChange-Id: I0ecef5270828bd92b55ff2e7f348e39e3b498c5a\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "4e0bb4587f6193814a8c54bfad689e4de11716d5", "tree": "779f927a6df46b95d8abc0e5ed193d660a69e60e", "parents": [ "23b521c6af529a48b8d5d82833cfa2f31ab57219" ], "author": { "name": "seobrien", "email": "seobrien@chromium.org", "time": "Fri Dec 29 22:37:44 2023 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Jan 23 15:07:54 2024 +0000" }, "message": "Add a buffer to smooth mouse scroll acceleration\n\nSometimes a bluetooth mouse will send multiple scroll events in quick\nsuccession when in reality they were generated more slowly. This can\ncause a large spike in scroll velocity. We already make sure that we use\na minimum time delta between events when calculating scroll velocity,\nbut the issue is still noticieable. Increasing this time delta can help,\nbut degrades scroll acceleration when the user intends to scorll fast.\n\nIn this CL, we add a small buffer of scroll events that we use to\ncalculate scroll velocity for the purpose of scroll acceleration. This\nallows us to accelerate scrolls appropriately when the user is\nconsistently scrolling quickly, without spurious spikes in acceleration\nwhen we receive batched bluetooth events.\n\nBUG\u003db:232137263\nTEST\u003dmanual testing, check for degredation in unittests and\ntouchpad-tests, add touchpad-tests regression test.\n\nCq-Depend: chromium:5159508\nChange-Id: I4b72fc0a2649dfc6628008668484e624f335a5e6\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5159108\nReviewed-by: Kenneth Albanowski \u003ckenalba@google.com\u003e\nCommit-Queue: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nReviewed-by: Aseda Aboagye \u003caaboagye@chromium.org\u003e\nReviewed-by: Torsha Banerjee \u003ctorsha@google.com\u003e\nTested-by: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\n" }, { "commit": "8c8a497e1c15be2d92fb811243c9aeb5d8d12f2c", "tree": "1a5fbbe0b0b18fc82b95167539cd5b603e1acb64", "parents": [ "41fcfd8bf0c39b28617f0bbfe94a68f90e565a51", "4db7a3fb3b3970fe67f0c78e9155a74b885671a3" ], "author": { "name": "Xin Li", "email": "delphij@google.com", "time": "Wed Jan 17 22:13:53 2024 -0800" }, "committer": { "name": "Xin Li", "email": "delphij@google.com", "time": "Wed Jan 17 22:13:53 2024 -0800" }, "message": "Merge Android 24Q1 Release (ab/11220357)\n\nBug: 319669529\nMerged-In: Ic7c11e6bab7584bd7acde43ae79f2ea68275333c\nChange-Id: I30aaa1cc50a2b92af1cd0f5e54ad252233178c37\n" }, { "commit": "23b521c6af529a48b8d5d82833cfa2f31ab57219", "tree": "e3476568a4062f21c589d60f4d8850a7887ec835", "parents": [ "b31ef0adcaff61c045e95158cb9720543b42b531" ], "author": { "name": "Ryan Beltran", "email": "ryanbeltran@chromium.org", "time": "Wed Jan 03 01:21:29 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jan 10 21:23:54 2024 +0000" }, "message": "Fix findings of wvla-cxx-extension\n\nThis CL fixes occurances of the wvla-cxx-extension warning in\nplatform/gestures. This is a newly introduced warning in Clang and\nexisting occurances in ChromeOS break compatibility with future releases\nof LLVM.\n\nBUG\u003db:316021385\nTEST\u003demerge-atlas chromeos-base/gestures\n\nChange-Id: If0eb2999d8a5abc3a367dc1c863d53258804d721\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5160432\nReviewed-by: Harry Cutts \u003chcutts@chromium.org\u003e\nCommit-Queue: Ryan Beltran \u003cryanbeltran@chromium.org\u003e\nCode-Coverage: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nTested-by: Ryan Beltran \u003cryanbeltran@chromium.org\u003e\n" }, { "commit": "4db7a3fb3b3970fe67f0c78e9155a74b885671a3", "tree": "1a5fbbe0b0b18fc82b95167539cd5b603e1acb64", "parents": [ "096ec4b20766972237e520afa20dad0863700fe6", "75305ca9beb2199c19f24cf0612dd68ea4df9614" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Thu Dec 14 14:03:46 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Dec 14 14:03:46 2023 +0000" }, "message": "Merge UBSan vla-bounds-not-positive fix from upstream am: ff1aa200b8 am: 41fcfd8bf0 am: 75305ca9be\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2871708\n\nChange-Id: I17359821d4a1c76bcc5cbac580d8167ff39dd2b1\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "75305ca9beb2199c19f24cf0612dd68ea4df9614", "tree": "ffff4c26722421cd89f9fa94770ca0ea9b71f6cc", "parents": [ "3454f4eae5cf480009fdbbbd4a361e29776a80b2", "41fcfd8bf0c39b28617f0bbfe94a68f90e565a51" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Thu Dec 14 13:31:22 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Dec 14 13:31:22 2023 +0000" }, "message": "Merge UBSan vla-bounds-not-positive fix from upstream am: ff1aa200b8 am: 41fcfd8bf0\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2871708\n\nChange-Id: I9093d4ff132807b18d9e17b0366cc41ec5f03f10\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "41fcfd8bf0c39b28617f0bbfe94a68f90e565a51", "tree": "ffff4c26722421cd89f9fa94770ca0ea9b71f6cc", "parents": [ "2caca6be4ab4e342496022ceea93b11391046dea", "ff1aa200b87ad5497d844a9a41c9756f7deb28b4" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Thu Dec 14 12:59:35 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Dec 14 12:59:35 2023 +0000" }, "message": "Merge UBSan vla-bounds-not-positive fix from upstream am: ff1aa200b8\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2871708\n\nChange-Id: I0f5624e8e99b09ec62e463b47aa1a7ff7dce903a\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "ff1aa200b87ad5497d844a9a41c9756f7deb28b4", "tree": "ffff4c26722421cd89f9fa94770ca0ea9b71f6cc", "parents": [ "2caca6be4ab4e342496022ceea93b11391046dea", "b31ef0adcaff61c045e95158cb9720543b42b531" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Wed Dec 13 18:01:10 2023 +0000" }, "committer": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Wed Dec 13 18:04:05 2023 +0000" }, "message": "Merge UBSan vla-bounds-not-positive fix from upstream\n\nBug: 315418482\nTest: Treehugger\nChange-Id: Ibc86b4ee4db288df0be771f007946ae7d65c01a9\n" }, { "commit": "b31ef0adcaff61c045e95158cb9720543b42b531", "tree": "9012ca55ccadd34d3db041f79e4b807bedfe4926", "parents": [ "d2ec17e2817001e97841fbab6da708a4183da4e1" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Fri Dec 08 16:15:44 2023 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Dec 13 17:46:28 2023 +0000" }, "message": "ImmediateInterpreter: fix UBSan vla-bound check failure\n\nThe fs array in GetGesturingFingers could potentially be given a length\nof 0 (a valid value of HardwareState::finger_cnt). Allocating a\nzero-length array can lead to undefined behaviour in C++, so this is\ncausing a crash due to UBSan\u0027s vla-bound check in Android. While I\u0027m\nunable to reproduce the crash locally, the stack trace points to the\nline declaring fs, and it\u0027s the only variable-length array in the\nmethod, so I think we can be confident that this is the fix.\n\nBUG\u003db:315418482\nTEST\u003dOn Android, run Gestures library and inputflinger tests; install\n the library on a device and check motions, gestures, etc. perform\n normally (tested on a Pixel Tablet with an Apple Magic Trackpad 1)\n\nChange-Id: If0bbe7f43ccd761f4a9cb80a55b69cb94e371ba1\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5106028\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\nAuto-Submit: Harry Cutts \u003chcutts@chromium.org\u003e\nCommit-Queue: Harry Cutts \u003chcutts@chromium.org\u003e\nCode-Coverage: Torsha Banerjee \u003ctorsha@google.com\u003e\nReviewed-by: Henry Barnor \u003chbarnor@chromium.org\u003e\nReviewed-by: Torsha Banerjee \u003ctorsha@google.com\u003e\nTested-by: Harry Cutts \u003chcutts@chromium.org\u003e\n" }, { "commit": "096ec4b20766972237e520afa20dad0863700fe6", "tree": "7f7b228ec1af3ec62ab070c84f59d0ccacfab670", "parents": [ "839f1f0504e366a2065192db3f6482c4e144b4d0", "3454f4eae5cf480009fdbbbd4a361e29776a80b2" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Mon Dec 04 19:35:00 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Dec 04 19:35:00 2023 +0000" }, "message": "Rename METADATA.android file to just METADATA am: f35b3ed30c am: 2caca6be4a am: 3454f4eae5\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2855735\n\nChange-Id: Ia137b0bdc104eb4dff2fa95d68a2492484e6074b\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "839f1f0504e366a2065192db3f6482c4e144b4d0", "tree": "7f7b228ec1af3ec62ab070c84f59d0ccacfab670", "parents": [ "8558219173c309cd3a137ff35c87d560037a0486", "a80f88c3cdcad02b8ad876478814985a8b78d134" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Mon Dec 04 19:32:32 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Dec 04 19:32:32 2023 +0000" }, "message": "Rename METADATA.android file to just METADATA am: f35b3ed30c am: 1a5111e578 am: a80f88c3cd\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2855735\n\nChange-Id: I7334594edf06081867dad4aee95401736b38c82d\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "3454f4eae5cf480009fdbbbd4a361e29776a80b2", "tree": "9f708cba987092a0f1bcfb1b0a4b7768d35bd570", "parents": [ "a80f88c3cdcad02b8ad876478814985a8b78d134", "2caca6be4ab4e342496022ceea93b11391046dea" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Mon Dec 04 19:32:23 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Dec 04 19:32:23 2023 +0000" }, "message": "Rename METADATA.android file to just METADATA am: f35b3ed30c am: 2caca6be4a\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2855735\n\nChange-Id: I152e9fb7c5cc02f64eb6f4af881cd29b607090af\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "a80f88c3cdcad02b8ad876478814985a8b78d134", "tree": "9f708cba987092a0f1bcfb1b0a4b7768d35bd570", "parents": [ "e30e7386ee2e36f09a06a383b41f895ca60e7556", "1a5111e5788c338dacac5c3678bd4f3f9f6f8138" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Mon Dec 04 18:45:36 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Dec 04 18:45:36 2023 +0000" }, "message": "Rename METADATA.android file to just METADATA am: f35b3ed30c am: 1a5111e578\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2855735\n\nChange-Id: I1206e2069fffe0269bd124429de3bfcbc6e72bfc\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "2caca6be4ab4e342496022ceea93b11391046dea", "tree": "9f708cba987092a0f1bcfb1b0a4b7768d35bd570", "parents": [ "728ebf8b496136141f6f281882c137cd94806632", "f35b3ed30cc0428bb5e8554f2cc2057282537794" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Mon Dec 04 18:34:13 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Dec 04 18:34:13 2023 +0000" }, "message": "Rename METADATA.android file to just METADATA am: f35b3ed30c\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2855735\n\nChange-Id: I9f9a9902e2290ccdf4fd3c278d2f5f8b0e4dd38b\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "1a5111e5788c338dacac5c3678bd4f3f9f6f8138", "tree": "9f708cba987092a0f1bcfb1b0a4b7768d35bd570", "parents": [ "06546f299b460d379be9fbe5e0283cd827d73056", "f35b3ed30cc0428bb5e8554f2cc2057282537794" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Mon Dec 04 18:21:12 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Dec 04 18:21:12 2023 +0000" }, "message": "Rename METADATA.android file to just METADATA am: f35b3ed30c\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2855735\n\nChange-Id: I0c424d0e786a2ed360d2467a89b82eb6dfa50070\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "8558219173c309cd3a137ff35c87d560037a0486", "tree": "7b175eb1b8ee0bcc60e326150504e4ec21fe06ea", "parents": [ "17a794eb9fcc69b81eac4dcbf666dd3786180390", "e30e7386ee2e36f09a06a383b41f895ca60e7556" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Mon Dec 04 18:11:50 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Dec 04 18:11:50 2023 +0000" }, "message": "Merge UBSan crash fix from upstream am: 972ec0c816 am: 06546f299b am: e30e7386ee\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2855729\n\nChange-Id: I56e6eb250e2ffdc98681423b3f534413803a4085\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "17a794eb9fcc69b81eac4dcbf666dd3786180390", "tree": "7b175eb1b8ee0bcc60e326150504e4ec21fe06ea", "parents": [ "58a5bb7d2b0a63a4d7fc217584ea886389af13d6", "210595d5e741407151c12097a1790b42a4801e35" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Mon Dec 04 18:11:01 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Dec 04 18:11:01 2023 +0000" }, "message": "Merge UBSan crash fix from upstream am: 972ec0c816 am: 728ebf8b49 am: 210595d5e7\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2855729\n\nChange-Id: I08900d5d2601ccc05fa1294ea5c90199175ac526\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "e30e7386ee2e36f09a06a383b41f895ca60e7556", "tree": "7a95df8cbbfe3417f2bf5f71725a195a57152c1a", "parents": [ "210595d5e741407151c12097a1790b42a4801e35", "06546f299b460d379be9fbe5e0283cd827d73056" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Mon Dec 04 17:56:16 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Dec 04 17:56:16 2023 +0000" }, "message": "Merge UBSan crash fix from upstream am: 972ec0c816 am: 06546f299b\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2855729\n\nChange-Id: Id12ed4bb38bebb394fa8471c1531358188c74045\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "210595d5e741407151c12097a1790b42a4801e35", "tree": "7a95df8cbbfe3417f2bf5f71725a195a57152c1a", "parents": [ "ccf59f17a4470e045063c9edff46a63c32b5a388", "728ebf8b496136141f6f281882c137cd94806632" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Mon Dec 04 17:22:24 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Dec 04 17:22:24 2023 +0000" }, "message": "Merge UBSan crash fix from upstream am: 972ec0c816 am: 728ebf8b49\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2855729\n\nChange-Id: I1740ecd7f0e57527905c8544e0530cfc3a6938e8\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "06546f299b460d379be9fbe5e0283cd827d73056", "tree": "7a95df8cbbfe3417f2bf5f71725a195a57152c1a", "parents": [ "3eb630f18654f19c94ac0c7da9c95f0d8cdf1b69", "972ec0c8160f5f698830f5b109aa9b7b51fa7d2b" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Mon Dec 04 17:16:59 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Dec 04 17:16:59 2023 +0000" }, "message": "Merge UBSan crash fix from upstream am: 972ec0c816\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2855729\n\nChange-Id: I0f014b14f2dfecbe46c756d54cfcf2deac776fc4\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "728ebf8b496136141f6f281882c137cd94806632", "tree": "7a95df8cbbfe3417f2bf5f71725a195a57152c1a", "parents": [ "dfd29888e9d6a36637c39a00d072fd65a7c63a56", "972ec0c8160f5f698830f5b109aa9b7b51fa7d2b" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Mon Dec 04 16:52:41 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Dec 04 16:52:41 2023 +0000" }, "message": "Merge UBSan crash fix from upstream am: 972ec0c816\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2855729\n\nChange-Id: I5b1c44f32b5511816ea696a19e4f6401729c5831\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "f35b3ed30cc0428bb5e8554f2cc2057282537794", "tree": "9f708cba987092a0f1bcfb1b0a4b7768d35bd570", "parents": [ "972ec0c8160f5f698830f5b109aa9b7b51fa7d2b" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Mon Dec 04 16:11:10 2023 +0000" }, "committer": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Mon Dec 04 16:11:10 2023 +0000" }, "message": "Rename METADATA.android file to just METADATA\n\nWe originally named it this way because ChromeOS also has METADATA files\nthat look similar but have a slightly different format, so we wanted to\navoid merge conflicts or confusion if the Gestures library acquired one\nin the future. However, the Android compliance tooling doesn\u0027t\nconsistently support METADATA.android files, leading to the compliance\nlinter missing problems with uprev CLs (causing a lot of build breakages\nin one instance, see b/296123023). Since it\u0027s not a documented feature,\nthe compliance team aren\u0027t inclined to support it unless it gains some\nkind of critical mass (b/296989944).\n\nA ChromeOS code search [0] reveals only two instances of repositories\nthat have METADATA files and aren\u0027t third-party imports of some kind, so\nit seems unlikely that one would be added to the Gestures library. Even\nif it was, I don\u0027t think the merge conflicts would be too troublesome,\nso let\u0027s just rename the file to the Android standard.\n\n[0]: https://source.chromium.org/search?q\u003df:%5CbMETADATA%5Cb%20-f:%5Esrc%2Faosp%20case:yes%20-f:third_party\u0026ss\u003dchromiumos\n\nBug: 296989944\nTest: Treehugger\nChange-Id: Iab4458b147ea2f6364f2e969d9cb0b911fcef078\n" }, { "commit": "972ec0c8160f5f698830f5b109aa9b7b51fa7d2b", "tree": "7a95df8cbbfe3417f2bf5f71725a195a57152c1a", "parents": [ "dd1cf6611b5fdebeed9122fdb39640a77f409ad3", "d2ec17e2817001e97841fbab6da708a4183da4e1" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Mon Dec 04 12:31:31 2023 +0000" }, "committer": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Mon Dec 04 12:36:44 2023 +0000" }, "message": "Merge UBSan crash fix from upstream\n\nBug: 313902875\nTest: Treehugger\nChange-Id: I275096fa83ddeb351a60c895b47e37fcbff670ab\n" }, { "commit": "d2ec17e2817001e97841fbab6da708a4183da4e1", "tree": "2bfa3e2fad950c3061e356718fb841f456611090", "parents": [ "81c9ccb03ad4279d6e9dbc701ad970a2ed8b6ada" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Fri Dec 01 14:25:03 2023 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Dec 01 20:02:05 2023 +0000" }, "message": "ImmediateInterpreter: initialize prev_gesture_type_\n\nThe first time SyncInterpretImpl was called after the interpreter was\ncreated, the unitialized value of prev_gesture_type_ would be loaded\ninto memory. This often caused a Clang\u0027s undefined behaviour sanitizer\n(UBSan) to abort with a load-invalid-value error.\n\nBUG\u003db:313902875\nTEST\u003dOn a Pixel Tablet, connect a touchpad and check it doesn\u0027t crash\n (repeat a few times)\n\nChange-Id: I8f3f588c026d71aee58a0aa5a5adbe20ad6a100a\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5079347\nTested-by: Harry Cutts \u003chcutts@chromium.org\u003e\nReviewed-by: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nCommit-Queue: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nAuto-Submit: Harry Cutts \u003chcutts@chromium.org\u003e\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\nCommit-Queue: Harry Cutts \u003chcutts@chromium.org\u003e\n" }, { "commit": "58a5bb7d2b0a63a4d7fc217584ea886389af13d6", "tree": "e965f66ed81f4b2b43a58038310c09287acb697f", "parents": [ "5246b12ee8929efa8d7361fe75f90a781f645c9f", "ccf59f17a4470e045063c9edff46a63c32b5a388" ], "author": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Wed Nov 29 16:14:26 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Nov 29 16:14:26 2023 +0000" }, "message": "Revert \"Disable parts of two gesturelib tests to prevent hwasan crash\" am: dd1cf6611b am: 3eb630f186 am: ccf59f17a4\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2837875\n\nChange-Id: I054bd291daa4bfd3994b677e11b3ef2f0470f229\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "5246b12ee8929efa8d7361fe75f90a781f645c9f", "tree": "e965f66ed81f4b2b43a58038310c09287acb697f", "parents": [ "e5561802f5ba94dbab73d6231c5b3b0e4221e412", "ff55512de9d805f920ecbc87742f1887e53b4ac6" ], "author": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Wed Nov 29 16:13:59 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Nov 29 16:13:59 2023 +0000" }, "message": "Revert \"Disable parts of two gesturelib tests to prevent hwasan crash\" am: dd1cf6611b am: dfd29888e9 am: ff55512de9\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2837875\n\nChange-Id: I3c33e191191fabf145540693f77a714987f64301\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "ccf59f17a4470e045063c9edff46a63c32b5a388", "tree": "b7f6e233663ea100ce0500d016ac069c9e8acce6", "parents": [ "ff55512de9d805f920ecbc87742f1887e53b4ac6", "3eb630f18654f19c94ac0c7da9c95f0d8cdf1b69" ], "author": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Wed Nov 29 15:44:21 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Nov 29 15:44:21 2023 +0000" }, "message": "Revert \"Disable parts of two gesturelib tests to prevent hwasan crash\" am: dd1cf6611b am: 3eb630f186\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2837875\n\nChange-Id: I11a61b0ea1e4c23d45389a3ec5fd31df255ec29d\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "ff55512de9d805f920ecbc87742f1887e53b4ac6", "tree": "b7f6e233663ea100ce0500d016ac069c9e8acce6", "parents": [ "0b441768e81376555ffaa9058ec8320dbbde212a", "dfd29888e9d6a36637c39a00d072fd65a7c63a56" ], "author": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Wed Nov 29 15:42:21 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Nov 29 15:42:21 2023 +0000" }, "message": "Revert \"Disable parts of two gesturelib tests to prevent hwasan crash\" am: dd1cf6611b am: dfd29888e9\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2837875\n\nChange-Id: I2b18dcbdb6111dcb5f9fa72526d02e380a87a49b\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "dfd29888e9d6a36637c39a00d072fd65a7c63a56", "tree": "b7f6e233663ea100ce0500d016ac069c9e8acce6", "parents": [ "e950487db983c6398ae544728195e6b5a5e29d92", "dd1cf6611b5fdebeed9122fdb39640a77f409ad3" ], "author": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Wed Nov 29 15:18:58 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Nov 29 15:18:58 2023 +0000" }, "message": "Revert \"Disable parts of two gesturelib tests to prevent hwasan crash\" am: dd1cf6611b\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2837875\n\nChange-Id: I012747acc10e408c57d2f784f6ec20dffa9ccce1\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "3eb630f18654f19c94ac0c7da9c95f0d8cdf1b69", "tree": "b7f6e233663ea100ce0500d016ac069c9e8acce6", "parents": [ "0129b890ab33656c0f02b9826ef8321e77aa84c2", "dd1cf6611b5fdebeed9122fdb39640a77f409ad3" ], "author": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Wed Nov 29 15:07:54 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Nov 29 15:07:54 2023 +0000" }, "message": "Revert \"Disable parts of two gesturelib tests to prevent hwasan crash\" am: dd1cf6611b\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2837875\n\nChange-Id: Ie91008e8a453528665e87527cc99375972bfb01e\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "dd1cf6611b5fdebeed9122fdb39640a77f409ad3", "tree": "b7f6e233663ea100ce0500d016ac069c9e8acce6", "parents": [ "e59a3460655f686836fd00ca92bae7cbdd69f65f" ], "author": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Fri Nov 24 15:23:24 2023 +0000" }, "committer": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Wed Nov 29 05:14:02 2023 +0000" }, "message": "Revert \"Disable parts of two gesturelib tests to prevent hwasan crash\"\n\nThis reverts commit 20029aa7de12dc24660cbe6b0501c93d5baa93c2.\n\nTest: atest libchrome-gestures_test\nTest: atest libinputflinger_test\nBug: 302505955\nChange-Id: If79c71a870d66ba2213c94640c6754f333e44ddd\n" }, { "commit": "e5561802f5ba94dbab73d6231c5b3b0e4221e412", "tree": "7aa860ef392686a927503871aaaa2c485dbe5ca8", "parents": [ "4bd2af22653326c541e02631f935e0e67ab176b1", "0b441768e81376555ffaa9058ec8320dbbde212a" ], "author": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Tue Nov 28 14:32:58 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Nov 28 14:32:58 2023 +0000" }, "message": "Merge upstream gesturelib branch into aosp/main am: e59a346065 am: 0129b890ab am: 0b441768e8\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2817676\n\nChange-Id: I631d98e2cb46adf076bfbe04f3df8a921793b137\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "4bd2af22653326c541e02631f935e0e67ab176b1", "tree": "7aa860ef392686a927503871aaaa2c485dbe5ca8", "parents": [ "c639cf0c9adf97598198240a63bd12af9af89932", "3d9e52d1a739ed3251d156adc18562e7626546e4" ], "author": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Tue Nov 28 14:32:18 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Nov 28 14:32:18 2023 +0000" }, "message": "Merge upstream gesturelib branch into aosp/main am: e59a346065 am: e950487db9 am: 3d9e52d1a7\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2817676\n\nChange-Id: Ie3aa88a9e43d07d1361e3d2b5d46a8a324f54454\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "0b441768e81376555ffaa9058ec8320dbbde212a", "tree": "029cabc290bb17a850923c444be5d6814d79c2d3", "parents": [ "3d9e52d1a739ed3251d156adc18562e7626546e4", "0129b890ab33656c0f02b9826ef8321e77aa84c2" ], "author": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Tue Nov 28 14:17:20 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Nov 28 14:17:20 2023 +0000" }, "message": "Merge upstream gesturelib branch into aosp/main am: e59a346065 am: 0129b890ab\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2817676\n\nChange-Id: Iec0e6aec25aed97da49798e1a594cec9da75e995\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "3d9e52d1a739ed3251d156adc18562e7626546e4", "tree": "029cabc290bb17a850923c444be5d6814d79c2d3", "parents": [ "4a2ba3966e1922e7dded9b3d94c32486f4103e9c", "e950487db983c6398ae544728195e6b5a5e29d92" ], "author": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Tue Nov 28 13:59:48 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Nov 28 13:59:48 2023 +0000" }, "message": "Merge upstream gesturelib branch into aosp/main am: e59a346065 am: e950487db9\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2817676\n\nChange-Id: Ie7cacf2f93ed496bb9ac4b0630252789b75e755f\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "0129b890ab33656c0f02b9826ef8321e77aa84c2", "tree": "029cabc290bb17a850923c444be5d6814d79c2d3", "parents": [ "3f15d1b1f452b30654f715af1b53f10b552193b3", "e59a3460655f686836fd00ca92bae7cbdd69f65f" ], "author": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Tue Nov 28 13:39:48 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Nov 28 13:39:48 2023 +0000" }, "message": "Merge upstream gesturelib branch into aosp/main am: e59a346065\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2817676\n\nChange-Id: If4a375e0fc7a131d2433544d6f01dac1685e7cad\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "e950487db983c6398ae544728195e6b5a5e29d92", "tree": "029cabc290bb17a850923c444be5d6814d79c2d3", "parents": [ "e223f8a8031f2ed981af029520db2f3ff061cb4a", "e59a3460655f686836fd00ca92bae7cbdd69f65f" ], "author": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Tue Nov 28 13:28:30 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Nov 28 13:28:30 2023 +0000" }, "message": "Merge upstream gesturelib branch into aosp/main am: e59a346065\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2817676\n\nChange-Id: I9ec47c390971ee63f56f614ffd6b869427baffc5\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "e59a3460655f686836fd00ca92bae7cbdd69f65f", "tree": "029cabc290bb17a850923c444be5d6814d79c2d3", "parents": [ "20029aa7de12dc24660cbe6b0501c93d5baa93c2", "81c9ccb03ad4279d6e9dbc701ad970a2ed8b6ada" ], "author": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Tue Nov 28 11:21:15 2023 +0000" }, "committer": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Tue Nov 28 11:22:05 2023 +0000" }, "message": "Merge upstream gesturelib branch into aosp/main\n\nTest: atest libchrome-gestures_test\nTest: atest inputflinger_tests\nBug: 302505955\nChange-Id: I1b52f3ffce42b994ec12e5508b0b2fd5a15a24fb\n" }, { "commit": "81c9ccb03ad4279d6e9dbc701ad970a2ed8b6ada", "tree": "5dc035a3a1a04d7d0fa8e635f1e1600af1c5ea40", "parents": [ "e1b20730a2a0cbccb0bc4a1bd98229a33117a407" ], "author": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Mon Nov 27 18:39:28 2023 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Nov 28 10:49:28 2023 +0000" }, "message": "Disable sanitizers for x86_64 explicitly\n\nWe are getting test failures on Android, to unblock upgrade of\ngesturelib on Android disabling sanitizers on x86_64 explicitly\n\nTest\u003datest libchrome-gestures_test\nBug\u003db:311110623\n\nChange-Id: Ie98ad1aff3a5f3d16acd58140b8d3ca86db27a09\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5062954\nCode-Coverage: Harry Cutts \u003chcutts@chromium.org\u003e\nReviewed-by: Harry Cutts \u003chcutts@chromium.org\u003e\nReviewed-by: Pirama Arumuga Nainar \u003cpirama@google.com\u003e\nCode-Coverage: Arpit Singh \u003carpitks@google.com\u003e\nAuto-Submit: Arpit Singh \u003carpitks@google.com\u003e\nCommit-Queue: Harry Cutts \u003chcutts@chromium.org\u003e\nTested-by: Arpit Singh \u003carpitks@google.com\u003e\n" }, { "commit": "e1b20730a2a0cbccb0bc4a1bd98229a33117a407", "tree": "788f20ad22b988c1dfbf77a56ec4bd478f8bb426", "parents": [ "705a01132d889586bc816edf2cefb1c541980712" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Thu Nov 23 11:45:48 2023 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Nov 27 21:01:38 2023 +0000" }, "message": "Note that HardwareState::fingers can be null\n\nBUG\u003db:245989146\nTEST\u003dnone\n\nChange-Id: Ie80d06b0d2e05be1190c423872465d55285e9d35\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5056835\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\nCommit-Queue: Henry Barnor \u003chbarnor@chromium.org\u003e\nTested-by: Harry Cutts \u003chcutts@chromium.org\u003e\nCode-Coverage: Henry Barnor \u003chbarnor@chromium.org\u003e\nTested-by: Arpit Singh \u003carpitks@google.com\u003e\nAuto-Submit: Harry Cutts \u003chcutts@chromium.org\u003e\nReviewed-by: Henry Barnor \u003chbarnor@chromium.org\u003e\nReviewed-by: Arpit Singh \u003carpitks@google.com\u003e\n" }, { "commit": "705a01132d889586bc816edf2cefb1c541980712", "tree": "b152cef8ea688b0f18ba624721d38265fc9ac93e", "parents": [ "9d24d86552e0825e1c262563644ff55bb9bce5c0" ], "author": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Mon Nov 27 10:56:21 2023 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Nov 27 16:41:37 2023 +0000" }, "message": "Disable sanitizers for x86\n\nWe are getting test failures on x86 on Android, to unblock upgrade of\ngesturelib on Android disabling sanitizers on x86\n\nTest\u003datest libchrome-gestures_test\nBug\u003db:311110623\n\nChange-Id: Idd1ee3683d6d787b7b08c099ce04b1b2f25b35ca\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5059091\nReviewed-by: Harry Cutts \u003chcutts@chromium.org\u003e\nCommit-Queue: Arpit Singh \u003carpitks@google.com\u003e\nTested-by: Arpit Singh \u003carpitks@google.com\u003e\nCode-Coverage: Harry Cutts \u003chcutts@chromium.org\u003e\nCommit-Queue: Harry Cutts \u003chcutts@chromium.org\u003e\n" }, { "commit": "9d24d86552e0825e1c262563644ff55bb9bce5c0", "tree": "b460eb3e5651dedc8559418740f743627e207417", "parents": [ "40d47ef25760b4d2226f72aefaf591b9f0925cea" ], "author": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Thu Nov 23 07:11:01 2023 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Nov 24 14:55:16 2023 +0000" }, "message": "Avoid calling memcpy with invalid destination\n\nDeep copy of a HardwareState with zero fingers causes memcpy call\nto copy zero bytes to a null destination. This behaviour is undefined\n and UndefinedBehaviorSanitizer on Android complains about it. This\nchange adds a check to avoid this unnecessary call.\n\nBUG\u003db:302505955\nTEST\u003datest libchrome-gestures_test\n\nChange-Id: I037214e42ac9299260f4c4ed7eb09adcd5a7c06c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5054360\nCommit-Queue: Harry Cutts \u003chcutts@chromium.org\u003e\nReviewed-by: Harry Cutts \u003chcutts@chromium.org\u003e\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\nTested-by: Arpit Singh \u003carpitks@google.com\u003e\n" }, { "commit": "c639cf0c9adf97598198240a63bd12af9af89932", "tree": "785c5b7b68b47dd855b2c28c5acb0ac7e5ad364d", "parents": [ "169a6eef180dce1b44e71f1a78773de906cc4900", "4a2ba3966e1922e7dded9b3d94c32486f4103e9c" ], "author": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Thu Nov 16 18:11:00 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Nov 16 18:11:00 2023 +0000" }, "message": "Disable parts of two gesturelib tests to prevent hwasan crash am: 20029aa7de am: 3f15d1b1f4 am: 4a2ba3966e\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2832832\n\nChange-Id: I9ba3a1b7e9c5b4da4b19e6de14c1ce59d7115ef7\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "169a6eef180dce1b44e71f1a78773de906cc4900", "tree": "785c5b7b68b47dd855b2c28c5acb0ac7e5ad364d", "parents": [ "db45778f560b361c80b84580963c9f8f8d1c85db", "390fdaddf1ca4f5f7ea65a1306723bd727f27031" ], "author": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Thu Nov 16 18:09:50 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Nov 16 18:09:50 2023 +0000" }, "message": "Disable parts of two gesturelib tests to prevent hwasan crash am: 20029aa7de am: e223f8a803 am: 390fdaddf1\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2832832\n\nChange-Id: I7b97d5406f847a4557f1846854a63557bc204932\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "4a2ba3966e1922e7dded9b3d94c32486f4103e9c", "tree": "3e9f7439a7e9a627f2984cd8d31ca1ecd722cf67", "parents": [ "390fdaddf1ca4f5f7ea65a1306723bd727f27031", "3f15d1b1f452b30654f715af1b53f10b552193b3" ], "author": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Thu Nov 16 16:50:17 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Nov 16 16:50:17 2023 +0000" }, "message": "Disable parts of two gesturelib tests to prevent hwasan crash am: 20029aa7de am: 3f15d1b1f4\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2832832\n\nChange-Id: I5aec7b7f3417213c113ea7d8bcc319818b252547\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "390fdaddf1ca4f5f7ea65a1306723bd727f27031", "tree": "3e9f7439a7e9a627f2984cd8d31ca1ecd722cf67", "parents": [ "5d922bbc521ade3a8743d659936ef27fb2972762", "e223f8a8031f2ed981af029520db2f3ff061cb4a" ], "author": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Thu Nov 16 16:48:49 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Nov 16 16:48:49 2023 +0000" }, "message": "Disable parts of two gesturelib tests to prevent hwasan crash am: 20029aa7de am: e223f8a803\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2832832\n\nChange-Id: I35266df9741b2d1cc4121fd29bc6ae0df5a4d0e0\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "3f15d1b1f452b30654f715af1b53f10b552193b3", "tree": "3e9f7439a7e9a627f2984cd8d31ca1ecd722cf67", "parents": [ "40119718abf54d5b66ecc223120b8e13aaf3b9e0", "20029aa7de12dc24660cbe6b0501c93d5baa93c2" ], "author": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Thu Nov 16 16:15:17 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Nov 16 16:15:17 2023 +0000" }, "message": "Disable parts of two gesturelib tests to prevent hwasan crash am: 20029aa7de\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2832832\n\nChange-Id: I2f3a39b0542a0947a747cad9c5424b2605586d67\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "e223f8a8031f2ed981af029520db2f3ff061cb4a", "tree": "3e9f7439a7e9a627f2984cd8d31ca1ecd722cf67", "parents": [ "5d922bbc521ade3a8743d659936ef27fb2972762", "20029aa7de12dc24660cbe6b0501c93d5baa93c2" ], "author": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Thu Nov 16 16:14:39 2023 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Nov 16 16:14:39 2023 +0000" }, "message": "Disable parts of two gesturelib tests to prevent hwasan crash am: 20029aa7de\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/libchrome-gestures/+/2832832\n\nChange-Id: I30799b61ac379c5fcf10e793bfb49cc00b15a1ca\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "20029aa7de12dc24660cbe6b0501c93d5baa93c2", "tree": "3e9f7439a7e9a627f2984cd8d31ca1ecd722cf67", "parents": [ "eac02377dec1d3792617ab267e281271451c15a6" ], "author": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Wed Nov 15 16:44:48 2023 +0000" }, "committer": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Thu Nov 16 12:03:30 2023 +0000" }, "message": "Disable parts of two gesturelib tests to prevent hwasan crash\n\nWe are seeing a crash due to hwasan while updating the chrome gesturelib\nfrom the upstream, This is likely due to hwasan. Test on ChromeOS do not\nrun with hwasan, we are temprorily disabling these tests tounblock\ngesturelib update.\n\nTest: atest libchrome-gestures_test\nBug: 302505955\nChange-Id: Ibe1afead4c9d592088e7102020fd6007f2b46b16\n" }, { "commit": "40d47ef25760b4d2226f72aefaf591b9f0925cea", "tree": "803e4afeae8045ef6b63aed74c19a3690b84e831", "parents": [ "9eb34c7b68d88a4c773f8f20fc64e57e5b29f988" ], "author": { "name": "Henry Barnor", "email": "hbarnor@chromium.org", "time": "Wed Nov 08 16:37:32 2023 -0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Nov 16 00:49:55 2023 +0000" }, "message": "Ensure touchpad stack version is included with logs\n\nUse a pointer instead of a temporary variable to hold the touchpad\nstack version used to initialize the gesture library. This ensures\nthat the touchpad stack version is automatically included when logs\nare generated. The temporary variable was getting destroyed when it\nwent of scope resulting in logs not having the information.\n\nBUG\u003db:283179221\nTEST\u003dCQ\nTEST\u003dDeployed to Brya device, confirmed in submitted feedback report.\n\nChange-Id: I57e7652891c65e747b2c983d459979f08d00539a\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5015362\nReviewed-by: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nTested-by: Henry Barnor \u003chbarnor@chromium.org\u003e\nCommit-Queue: Henry Barnor \u003chbarnor@chromium.org\u003e\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\n" }, { "commit": "9eb34c7b68d88a4c773f8f20fc64e57e5b29f988", "tree": "1a614c8f51abd751ac3acfaf70f193ddd73e0994", "parents": [ "00d2b6cbb14c971e3976fac3d97ceea4f7e1e116" ], "author": { "name": "George Burgess IV", "email": "gbiv@google.com", "time": "Wed Nov 08 08:44:20 2023 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sat Nov 11 00:42:46 2023 +0000" }, "message": "fix -Wmissing-field-initializers warnings\n\nClang\u0027s -Wmissing-field-initializers now complains about missing\ninitializers in structs init\u0027ed using `.designators`. Fix up about 100\ninstances of this.\n\nBUG\u003db:305723283\nTEST\u003dFEATURES\u003dtest emerge-hana\n\nChange-Id: Ida87c19428aebdeee94eaf4a95f2339f8d0e63d7\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5014383\nCommit-Queue: Henry Barnor \u003chbarnor@chromium.org\u003e\nReviewed-by: Henry Barnor \u003chbarnor@chromium.org\u003e\nTested-by: George Burgess \u003cgbiv@chromium.org\u003e\nCode-Coverage: Henry Barnor \u003chbarnor@chromium.org\u003e\n" }, { "commit": "00d2b6cbb14c971e3976fac3d97ceea4f7e1e116", "tree": "b5123b0d0bada8a18412578c102e7eff38dc6441", "parents": [ "558a2420ad3d1ac5ac8ef7f6707abc2bf1d8b8e2" ], "author": { "name": "AdityaK", "email": "appujee@google.com", "time": "Tue Oct 31 11:48:37 2023 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Nov 02 18:59:39 2023 +0000" }, "message": "Fix visitor\n\n```\nexternal/libcxx/include/variant:587:19: error: static assertion failed due to requirement \u0027is_invocable_v\u003c(anonymous namespace)::Visitor (lambda at external/libchrome-gestures/src/activity_replay.cc: `std::visit` requires the visitor to be exhaustive.\n 587 | static_assert(is_invocable_v\u003c_Visitor, _Values...\u003e,\n\n```\nTest:\nsource build/envsetup.sh\nlunch aosp_x86_64-userdebug\ncd master-plus-llvm/external/libchrome-gestures\nmm\n\nBug: b/308807804\n\nChange-Id: Ia0150688a6715370f3365ee790a8cba0b18ba38c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4996084\nAuto-Submit: Aditya Kumar \u003cappujee@google.com\u003e\nCommit-Queue: Aditya Kumar \u003cappujee@google.com\u003e\nReviewed-by: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\nTested-by: Aditya Kumar \u003cappujee@google.com\u003e\n" }, { "commit": "558a2420ad3d1ac5ac8ef7f6707abc2bf1d8b8e2", "tree": "f1fbb34422e5f969c68c707ccc1dab139d63c1e3", "parents": [ "9e76b2e05a5b6fa723814dfb32e1a6a76aba7a7a" ], "author": { "name": "seobrien", "email": "seobrien@chromium.org", "time": "Thu Oct 26 21:32:37 2023 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Oct 27 20:22:55 2023 +0000" }, "message": "Set delegate to handle changes to debug logging\n\nChanges to debug logging status was not being applied properly there was\nno delegate to handle changes to the gesture property. This CL makes\nsure the event debug logging property it handled.\n\nBUG\u003db:286851905\nTEST\u003ddeploy and check that IntWasWritten is called.\n\nChange-Id: I7a9c9200e7a21c33b3076858073f9d9d18009d17\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4979150\nTested-by: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\nReviewed-by: Torsha Banerjee \u003ctorsha@google.com\u003e\nCommit-Queue: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nCode-Coverage: Torsha Banerjee \u003ctorsha@google.com\u003e\nReviewed-by: Henry Barnor \u003chbarnor@chromium.org\u003e\n" }, { "commit": "9e76b2e05a5b6fa723814dfb32e1a6a76aba7a7a", "tree": "ff17c332eb29b0744f0ae185664545e9227ba4f1", "parents": [ "03240a10b06613b645207d875be6b82d63dee02e" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Fri Oct 20 17:02:21 2023 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Oct 26 18:07:40 2023 +0000" }, "message": "ImmediateInterpreter: replace origin_timestamps_ with metrics\n\nOrigin timestamps were already being collected by FingerMetrics, so\nremoving origin_timestamps_ reduces duplication and should make it\neasier to separate out the tap-to-click logic later.\n\nBUG\u003db:245989146\nTEST\u003drun unit tests on Android; try tapping to click before and after\n the change, check there\u0027s no behaviour difference\n\nChange-Id: I5e0afb9e4a640b15de1255e3d3d27a9e9eb12d54\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4966486\nReviewed-by: Denis Brockus \u003cdbrockus@chromium.org\u003e\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\nTested-by: Harry Cutts \u003chcutts@chromium.org\u003e\nCommit-Queue: Harry Cutts \u003chcutts@chromium.org\u003e\n" }, { "commit": "03240a10b06613b645207d875be6b82d63dee02e", "tree": "b7e2d3c6544c75a551f482c914b7ffa6bf7baf49", "parents": [ "58beefcfe7b7d67f065d420d3596a12736698720" ], "author": { "name": "Arpit Singh", "email": "arpitks@google.com", "time": "Tue Oct 10 19:02:39 2023 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Oct 26 17:43:09 2023 +0000" }, "message": "Expose flag to report palm detected by firmware to gestures-lib\n\nWe currently don\u0027t report palms detected by firmware to gestures-lib,\nthis leads to situations where gesture lib consideres a touch to be\nlifted if its reported as palm by firmware. This can also cause\nunintended tap-to-click, and prevent bottom-right click from working as\nintended.\n\nBUG\u003db:302505955\nTEST\u003datest libchrome-gestures_test\n\nChange-Id: I172af6b3d46997bfefe68b4bede5c80d522bad3d\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4974106\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\nReviewed-by: Harry Cutts \u003chcutts@chromium.org\u003e\nTested-by: Arpit Singh \u003carpitks@google.com\u003e\nReviewed-by: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nCommit-Queue: Harry Cutts \u003chcutts@chromium.org\u003e\n" }, { "commit": "58beefcfe7b7d67f065d420d3596a12736698720", "tree": "c885008f6b8e1c33e098a788fb48dbcbab51b25d", "parents": [ "eff665b6e8184b98b4139e576d0c0194c84b1937" ], "author": { "name": "David Padlipsky", "email": "dpad@google.com", "time": "Tue Oct 24 19:25:16 2023 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Oct 24 22:49:01 2023 +0000" }, "message": "gestures: Add support for differentiating BTN_SIDE and BTN_EXTRA\n\nBUG\u003db:241965717\nTEST\u003dUSE\u003d\"coverage\" FEATURES\u003d\"test noclean\" emerge-brya chromeos-base/gestures\n\nChange-Id: I65605f928f8524c9c494a8cea6432f51c084c848\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4973858\nTested-by: David Padlipsky \u003cdpad@google.com\u003e\nCommit-Queue: David Padlipsky \u003cdpad@google.com\u003e\nReviewed-by: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\n" }, { "commit": "eff665b6e8184b98b4139e576d0c0194c84b1937", "tree": "dffdea8cb405bbc28dbcd282864158069958b91d", "parents": [ "36467839006b1aef5ae93cb17e7b355fff1b9dd0" ], "author": { "name": "Harry Cutts", "email": "hcutts@google.com", "time": "Thu Oct 05 14:41:17 2023 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Oct 18 13:55:48 2023 +0000" }, "message": "Android.bp: sanitize tests, enable more sanitizers\n\nSince some of the unit tests are quite complex, I think it\u0027s worth\nenabling sanitizers for them.\n\nBUG\u003db:302041840\nTEST\u003drun unit tests on Android\n\nChange-Id: Id5fea00ff5e633c2d202ef539b03920c4dbf096c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4916790\nReviewed-by: Denis Brockus \u003cdbrockus@chromium.org\u003e\nTested-by: Harry Cutts \u003chcutts@chromium.org\u003e\nCode-Coverage: Denis Brockus \u003cdbrockus@chromium.org\u003e\nReviewed-by: Siarhei Vishniakou \u003csvv@google.com\u003e\nCommit-Queue: Denis Brockus \u003cdbrockus@chromium.org\u003e\n" }, { "commit": "36467839006b1aef5ae93cb17e7b355fff1b9dd0", "tree": "66852921b68406a849d2fb40891bcdd808a0c321", "parents": [ "f658e3cc2ae9ff617a905d810a72b60c7052fcc6" ], "author": { "name": "George Burgess IV", "email": "gbiv@google.com", "time": "Mon Oct 16 15:49:33 2023 -0600" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Oct 17 00:55:33 2023 +0000" }, "message": "gestures: fix ill-formed code\n\nTo resolve ambiguities during overload resolution, `using\nV::operator()...;` is needed here in well-formed C++ code. Clang\nincorrectly let this code pass without diagnostics before. See\ndiscussion on https://reviews.llvm.org/D155387 for more details.\n\nBUG\u003db:305745122\nTEST\u003demerge-jacuzzi gestures\n\nChange-Id: I96dc35d87a0289863adc847a158b62e6f22a655e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4944553\nCode-Coverage: Zoss \u003czoss-cl-coverage@prod.google.com\u003e\nTested-by: George Burgess \u003cgbiv@chromium.org\u003e\nReviewed-by: Sean O\u0027Brien \u003cseobrien@chromium.org\u003e\nCommit-Queue: George Burgess \u003cgbiv@chromium.org\u003e\n" } ], "next": "f658e3cc2ae9ff617a905d810a72b60c7052fcc6" }