tree 971ba34dd10fcbfb25a374a3539d06cef349aee4
parent c6488980b2be422832fb9fa0c0e2c0928d825a35
author Martin Storsjo <martin@martin.st> 1432069948 +0300
committer Marco Nelissen <marcone@google.com> 1435245952 -0700

Fix string handling for generating version strings

Don't do concatenation with strncat; the length parameter in strncat
is only for how many chars to append at most, not for the full output
buffer size. To safely use strncat, one would have to do
strncat(buf, str, sizeof(buf) - strlen(buf)).

By using snprintf, we guarantee that the buffer is null terminated, and
we don't need to use strnlen at all.

(If compatibility with older MSVC versions that lack snprintf, one
can use _snprintf instead and manually add the null termination.)

Change-Id: I1c2322c7a406ddd5e6551a96c460da60deeffda1