| commit | a5a67c2ffdf50cd399519fb5a7f334d41b2e2c5d | [log] [tgz] |
|---|---|---|
| author | Giuliano Procida <gprocida@google.com> | Thu Mar 26 19:15:17 2020 +0000 |
| committer | Dodji Seketeli <dodji@redhat.com> | Mon Mar 30 16:26:31 2020 +0200 |
| tree | 9588e13878b05a3f1723c3f082b2a6f387e0f670 | |
| parent | 95868e0c42a3ff38defcb972b3c79a82365bb85f [diff] |
abidiff: Clean up new lines between sections. Some blank lines were unintentionally removed with a recent patch. The new line to remove should have been the one after all changed functions not the one after each one. Changed functions (and variables) tend to be reported as paragraphs, rather than single lines, so the extra spacing is useful. This patch removes the blank line emitted after all changed functions, variables and unreachable types, and adds back the missing blank lines between changed functions. * src/abg-default-reporter.cc (report): In the corpus_diff override, add back the extra blank line per changed function but remove the extra one after all changed changed functions and variables; comment these. * src/abg-leaf-reporter.cc (report): In the corpus_diff override, add back the extra blank line per changed function but remove the extra one after all changed changed functions and variables; comment these. * src/abg-reporter-priv.cc (maybe_report_unreachable_type_changes): Remove extra blank line emitted after all unreachable type changes; comment this. * tests/data/test*report*.txt: Remove/add blank lines. Reviewed-by: Matthias Maennich <maennich@google.com> Signed-off-by: Giuliano Procida <gprocida@google.com>