commit | 70f293d74d582f68ff9c845ea3f5ada3b47635d6 | [log] [tgz] |
---|---|---|
author | Carmi Grushko <carmi@fb.com> | Tue Aug 04 09:19:53 2020 -0700 |
committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | Tue Aug 04 09:21:05 2020 -0700 |
tree | 0e6fc09e9a81683f32d32317b598f31bbc422002 | |
parent | b1e855059aa83204ffaa068b5721acc87534cbda [diff] |
Rewrite formatting code for call-expression and qualified-expression Summary: 1. This fixes several bugs, including https://github.com/facebookincubator/ktfmt/issues/56 2. It is an adaptation of google-java-format's `JavaInputAstVisitor.visitDot`. 3. I copied over GJF's code that guesses whether a list of names are actually a fully qualified class name, because the original isn't public. I'll send a pR to GJF and then switch to it. The rules for formatting are: 1. If there's only a single call exprsesion in the qualified expression chain (e.g., `foo.bar.baz()`), then try to keep the field accesses on a single line. 2. If there are multiple call expressions, put every call on a line of its own (unless, of course, it all fits in one line) This fixes https://github.com/facebookincubator/ktfmt/issues/54 This fixes https://github.com/facebookincubator/ktfmt/issues/56 Reviewed By: strulovich Differential Revision: D22769445 fbshipit-source-id: aaf53d805106f4c86cddc02d7a6bc8598c8a796a
ktfmt
is a program that pretty-prints (formats) Kotlin code, based on google-java-format.
Note that ktfmt
still has some rough edges which we're constantly working on fixing.
The minimum supported runtime version is JDK 11, released September 2018.
Before Formatting | Formatted by ktfmt |
---|---|
For comparison, the same code formatted by ktlint
and IntelliJ:
Formatted by ktlint | Formatted by IntelliJ |
---|---|
Download the formatter and run it with:
java -jar /path/to/ktfmt-<VERSION>-jar-with-dependencies.jar [--dropbox-style] [files...]
--dropbox-style
makes ktfmt
use a block indent of 4 spaces instead of 2. See below for details.
Note: There is no configurability as to the formatter's algorithm for formatting (apart from --dropbox-style
). This is a deliberate design decision to unify our code formatting on a single format.
On Gradle: https://github.com/diffplug/spotless/tree/main/plugin-gradle#ktfmt On Maven: https://github.com/diffplug/spotless/tree/main/plugin-maven#ktfmt
ktfmt
vs ktlint
vs IntelliJktfmt
uses google-java-format's underlying engine, and as such, many items on google-java-format's FAQ apply to ktfmt
as well.
In particular,
ktfmt
ignores most existing formatting. It respects existing newlines in some places, but in general, its output is determinstic and is independent of the input code.ktfmt
exposes no configuration options that govern formatting behavior. See https://github.com/google/google-java-format/wiki/FAQ#i-just-need-to-configure-it-a-bit-differently-how for the rationale.These two properties make ktfmt
a good fit in large Kotlin code bases, where consistency is very important.
We created ktfmt
because ktlint
and IntelliJ sometime fail to produce nice-looking code that fits in 100 columns, as can be seen in the Demo section.
ktfmt
uses a 2-space indent; why not 4? any way to change that?Two reasons -
However, we do offer an escape-hatch for projects that absolutely cannot make the move to ktfmt
because of 2-space: the --dropbox-style
flag changes block indents to 4-space.
pom.xml
in IntelliJ. Choose “Open as a Project”FormatterKtTest.kt
.mvn install
java -jar core/target/ktfmt-<VERSION>-jar-with-dependencies.jar
See RELEASING.md.
Apache License 2.0