commit | 5164ad9c90a851b99c8b76dcd6fb33fcc40264b7 | [log] [tgz] |
---|---|---|
author | David Torosyan <dtoro@fb.com> | Fri Jan 07 10:50:32 2022 -0800 |
committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | Fri Jan 07 10:52:08 2022 -0800 |
tree | 6d06c4225728f8570a2fccb8616fd0703818d88d | |
parent | 61a9024f156622e13d2a168968976d455606d1c6 [diff] |
Consolidate emitQualifiedExpression functions Summary: ## Context Before, we had two paths for `emitQualifiedExpression`: * `emitQualifiedExpressionOnePerLine` - breaks expressions with `UNIFIED` * `emitQualifiedExpressionSeveralInOneLine` - breaks grouped expressions with `INDEPENDENT`, and then the remaining with `UNIFIED` This had a few problems: 1. The `OnePerLine` was really a misnomer, since it didn't actually put them one-per-line if it all fit on one line 2. It was hard to modify the logic, since it's not obvious how to keep changes in sync I noticed that they could be combined if `OnePerLine` was treated as a special case of the `SeveralInOneLine` - when there are no grouped expressions. ## New problems Combining these functions has two issues: 1. Now we're keeping track of `textLength`, which further complicates the larger function 2. We have this `simple` boolean which helps deal with the differences between the two cases, mostly having to do with indentation. Both of these had to be included to avoid causing any behavior changes, but I want to deal with them by removing them in the next diff, since they add complexity and (I think) little value. ## Next steps Now that the two code paths are consolidated, I can start changing behavior as described in T80900127! Reviewed By: strulovich, hick209 Differential Revision: D33399531 fbshipit-source-id: 8f86d1cd0c9aa89cae04afbae8b3f10fde6edfef
ktfmt
is a program that pretty-prints (formats) Kotlin code, based on google-java-format.
Note that ktfmt
still has some rough edges which we're constantly working on fixing.
The minimum supported runtime version is JDK 11, released September 2018.
Before Formatting | Formatted by ktfmt |
---|---|
For comparison, the same code formatted by ktlint
and IntelliJ:
Formatted by ktlint | Formatted by IntelliJ |
---|---|
A ktfmt IntelliJ plugin is available from the plugin repository. To install it, go to your IDE's settings and select the Plugins
category. Click the Marketplace
tab, search for the ktfmt
plugin, and click the Install
button.
The plugin will be disabled by default. To enable it in the current project, go to File→Settings...→ktfmt Settings
(or IntelliJ IDEA→Preferences...→Editor→ktfmt Settings
on macOS) and check the Enable ktfmt
checkbox. (A notification will be presented when you first open a project offering to do this for you.)
To enable it by default in new projects, use File→New Project Settings→Preferences for new Projects→Editor→ktfmt Settings
.
When enabled, it will replace the normal Reformat Code
action, which can be triggered from the Code
menu or with the Ctrl-Alt-L (by default) keyboard shortcut.
To configure IntelliJ to approximate ktfmt‘s formatting rules during code editing, you can edit your project’s .editorconfig
file to include the Kotlin section from one of the files inside docs/editorconfig
. Not all of ktfmt‘s rules can be represented as IntelliJ editor settings, so you will still need to run ktfmt. Alternately, that file can be used as a reference to manually change the project’s code style settings.
Download the formatter and run it with:
java -jar /path/to/ktfmt-<VERSION>-jar-with-dependencies.jar [--dropbox-style] [files...]
--dropbox-style
makes ktfmt
use a block indent of 4 spaces instead of 2. See below for details.
Note: There is no configurability as to the formatter's algorithm for formatting (apart from --dropbox-style
). This is a deliberate design decision to unify our code formatting on a single format.
A Gradle plugin (ktfmt-gradle) is available on the Gradle Plugin Portal. To set it up, just follow the instructions in the How-to-use section.
Alternatively, you can use Spotless with the ktfmt Gradle plugin.
Consider using Spotless with the ktfmt Maven plugin.
ktfmt
vs ktlint
vs IntelliJktfmt
uses google-java-format's underlying engine, and as such, many items on google-java-format's FAQ apply to ktfmt
as well.
In particular,
ktfmt
ignores most existing formatting. It respects existing newlines in some places, but in general, its output is deterministic and is independent of the input code.ktfmt
exposes no configuration options that govern formatting behavior. See https://github.com/google/google-java-format/wiki/FAQ#i-just-need-to-configure-it-a-bit-differently-how for the rationale.These two properties make ktfmt
a good fit in large Kotlin code bases, where consistency is very important.
We created ktfmt
because ktlint
and IntelliJ sometime fail to produce nice-looking code that fits in 100 columns, as can be seen in the Demo section.
ktfmt
uses a 2-space indent; why not 4? any way to change that?Two reasons -
However, we do offer an escape-hatch for projects that absolutely cannot make the move to ktfmt
because of 2-space: the --dropbox-style
flag changes block indents to 4-space.
pom.xml
in IntelliJ. Choose “Open as a Project”FormatterTest.kt
.mvn install
java -jar core/target/ktfmt-<VERSION>-jar-with-dependencies.jar
See RELEASING.md.
Apache License 2.0