commit | 50f9b7cc5086a2659fdb82c143afd0312ed54132 | [log] [tgz] |
---|---|---|
author | Omer Strulovich <ostrulovich@fb.com> | Tue Feb 11 12:34:10 2020 -0800 |
committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | Tue Feb 11 12:35:43 2020 -0800 |
tree | e306877e61e2ed318abdcd4099be27648095a8d1 | |
parent | eff61fa877ff6a7d816e6e5d0bf4931a746659c7 [diff] |
Improve formatting of chained binary expressions Summary: When seeing a lot of binary expressions without parenthesis, format them as if they go from left to right, instead of by the AST. This is similar to how we deal with dot call chains such as `a.b().c().d()`. See examples in tests Reviewed By: cgrushko Differential Revision: D19837346 fbshipit-source-id: 02e86aad93f2c1713b181cb351304967ac5736f2
ktfmt
is a program that pretty-prints (formats) Kotlin code, based on google-java-format.
Note that ktfmt
still has some rough edges which we're constantly working on fixing.
Before Formatting | Formatted by ktfmt |
---|---|
For comparison, the same code formatted by ktlint
and IntelliJ:
Formatted by ktlint | Formatted by IntelliJ |
---|---|
vendor/google-java/format
submodule is populated. Either clone with submodules (git pull --recurse-submodules https://github.com/facebookincubator/ktfmt.git
) or populate the submodule after cloning (git submodule update --init
)mvn install
java -jar core/target/ktfmt-0.1-SNAPSHOT-jar-with-dependencies.jar
ktfmt
vs ktlint
vs IntelliJktfmt
uses google-java-format's underlying engine, and as such, many items on google-java-format's FAQ apply to ktfmt
as well.
In particular,
ktfmt
ignores most existing formatting. It respects existing newlines in some places, but in general, its output is determinstic and is independent of the input code.ktfmt
exposes no configuration options that govern formatting behavior. See https://github.com/google/google-java-format/wiki/FAQ#i-just-need-to-configure-it-a-bit-differently-how for the rationale.These two properties make ktfmt
a good fit in large Kotlin code bases, where consistency is very important.
We created ktfmt
because ktlint
and IntelliJ sometime fail to produce nice-looking code that fits in 100 columns, as can be seen in the Demo section.
ktfmt
uses a 2-space indent; why not 4?Two reasons -
vendor/google-java/format
submodule is populated. Either clone with submodules (git pull --recurse-submodules https://github.com/facebookincubator/ktfmt.git
) or populate the submodule after cloning (git submodule update --init
)pom.xml
in IntelliJ. Choose “Open as a Project”FormatterKtTest.kt
.Apache License 2.0