commit 505b3fc6cfbed95a4101c9a9c75a76645eb6fb6b
author Behdad Esfahbod <behdad@behdad.org> Wed Feb 17 11:34:47 2021 -0700
committer Behdad Esfahbod <behdad@behdad.org> Wed Feb 17 11:34:47 2021 -0700
tree e51779f48847c1d52100f1362933a9a910ff3595
parent 6a9f576fd438aef23242e72bd04285d0ea1279ad

[harfbuzz.cc] Fix OffsetTable name clash with Mac headers

There's no easy way to undo a "using namespace" in our sources, so by the time
we get to include hb-coretext.cc from harfbuzz.cc, we already have "using namespace OT"
active, which clashes with Mac headers.

Error was:
$ gcc -O3 -Wall -arch i386 -DHAVE_CORETEXT=1 -c harfbuzz.cc -o harfbuzz.o -std=c++11
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/TextUtils.h:288:3: error:
      reference to 'OffsetTable' is ambiguous
  OffsetTable     offsets,
  ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/IntlResources.h:115:41: note:
      candidate found by name lookup is 'OffsetTable'
typedef OffPair                         OffsetTable[3];
                                        ^
./hb-open-file.hh:81:16: note: candidate found by name lookup is 'OT::OffsetTable'
typedef struct OffsetTable
               ^
1 error generated.