Google Git
Sign in
android / platform / external / grpc-grpc / 4a15da4443
commit4a15da4443b6920f1cf0f244b2dbfa3367136534[log] [tgz]
authorXuan Wang <xuanwn@google.com>Wed Aug 14 11:55:09 2024 -0700
committerGitHub <noreply@github.com>Wed Aug 14 11:55:09 2024 -0700
tree080f3523034d17a8d2fe2b02430f26630f368d71
parent87f97246b2f8310a1853a1bace90bc1f2303441b [diff]
[Python Otel] Manage call tracer life cycle use call arena. (v1.66.x backport) (#37479)

Backport of #37460 to v1.66.x.
---
We're seeing segfault in Python CSM tests:
```
2024-08-03T09:49:45.720555997Z *** SIGSEGV received at time=1722678585 on cpu 0 ***
2024-08-03T09:49:45.721761998Z PC: @     0x7847ffd5c1c9  (unknown)  (unknown)
2024-08-03T09:49:45.722070502Z     @     0x7847fa309d8c         64  absl::lts_20240116::WriteFailureInfo()
2024-08-03T09:49:45.722175904Z     @     0x7847fa309a15        272  absl::lts_20240116::AbslFailureSignalHandler()
2024-08-03T09:49:45.722187675Z     @     0x7847ffc3d050       1592  (unknown)
2024-08-03T09:49:45.723432238Z     @     0x7847e97f9390  (unknown)  (unknown)
2024-08-03T09:49:45.723487349Z     @ ... and at least 1 more frames
2024-08-03T09:49:45.829702781Z [INFO  tini (1)] Spawned child process '/xds_interop_client' with pid '7'
2024-08-03T09:49:45.829766869Z [DEBUG tini (1)] Received SIGCHLD
2024-08-03T09:49:45.829778749Z [DEBUG tini (1)] Reaped child with pid: '7'
2024-08-03T09:49:45.829787070Z [INFO  tini (1)] Main child exited with signal (with signal 'Segmentation fault')
```

### The issue

After investigation, we found that the call tracer was deleted before
`RecordEnd` was called.

### Why this fix

* To fix this, we decide to use arena to manage the life cycle of
CallTracer.
* Since CallTracer was created in another shard object library
(`grpcio_observability`) which don't have a dependency on grpc core, we
can't use `grpc_core::Arena` directly when creating the call tracer.
* As a workaround, we created a wrapper class `ClientCallTracerWrapper`
to wrap the CallTracer and created another core API
`grpc_call_tracer_set_and_manage` so that we can manage the life cycle
of CallTracer use the wrapper class.


<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
9 files changed
tree: 080f3523034d17a8d2fe2b02430f26630f368d71
  1. .bazelci/
  2. .github/
  3. bazel/
  4. cmake/
  5. doc/
  6. etc/
  7. examples/
  8. fuzztest/
  9. include/
  10. spm-core-include/
  11. spm-cpp-include/
  12. src/
  13. summerofcode/
  14. templates/
  15. test/
  16. third_party/
  17. tools/
  18. .bazelignore
  19. .bazelrc
  20. .bazelversion
  21. .clang-format
  22. .clang-tidy
  23. .dockerignore
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitallowed
  27. .gitattributes
  28. .gitignore
  29. .gitmodules
  30. .istanbul.yml
  31. .pylintrc
  32. .pylintrc-examples
  33. .pylintrc-tests
  34. .rspec
  35. .yapfignore
  36. .yardopts
  37. _metadata.py
  38. AUTHORS
  39. black.toml
  40. BoringSSL-Package.swift
  41. BUILD
  42. build_autogenerated.yaml
  43. build_config.rb
  44. build_handwritten.yaml
  45. BUILDING.md
  46. CMakeLists.txt
  47. CODE-OF-CONDUCT.md
  48. composer.json
  49. CONCEPTS.md
  50. config.m4
  51. config.w32
  52. CONTRIBUTING.md
  53. CONTRIBUTING_STEPS.md
  54. Gemfile
  55. GOVERNANCE.md
  56. gRPC-C++.podspec
  57. gRPC-Core.podspec
  58. gRPC-ProtoRPC.podspec
  59. gRPC-RxLibrary.podspec
  60. grpc.bzl
  61. grpc.def
  62. grpc.gemspec
  63. grpc.gyp
  64. gRPC.podspec
  65. LICENSE
  66. MAINTAINERS.md
  67. Makefile
  68. MANIFEST.md
  69. NOTICE.txt
  70. Package.swift
  71. package.xml
  72. PYTHON-MANIFEST.in
  73. Rakefile
  74. README.md
  75. requirements.bazel.txt
  76. requirements.txt
  77. SECURITY.md
  78. setup.cfg
  79. setup.py
  80. TROUBLESHOOTING.md
  81. WORKSPACE
README.md

gRPC – An RPC library and framework

gRPC is a modern, open source, high-performance remote procedure call (RPC) framework that can run anywhere. gRPC enables client and server applications to communicate transparently, and simplifies the building of connected systems.

Join the chat at https://gitter.im/grpc/grpc

To start using gRPC

To maximize usability, gRPC supports the standard method for adding dependencies to a user‘s chosen language (if there is one). In most languages, the gRPC runtime comes as a package available in a user’s language package manager.

For instructions on how to use the language-specific gRPC runtime for a project, please refer to these documents

  • C++: follow the instructions under the src/cpp directory
  • C#/.NET: NuGet packages Grpc.Net.Client, Grpc.AspNetCore.Server
  • Dart: pub package grpc
  • Go: go get google.golang.org/grpc
  • Java: Use JARs from Maven Central Repository
  • Kotlin: Use JARs from Maven Central Repository
  • Node: npm install @grpc/grpc-js
  • Objective-C: Add gRPC-ProtoRPC dependency to podspec
  • PHP: pecl install grpc
  • Python: pip install grpcio
  • Ruby: gem install grpc
  • WebJS: follow the grpc-web instructions

Per-language quickstart guides and tutorials can be found in the documentation section on the grpc.io website. Code examples are available in the examples directory.

Precompiled bleeding-edge package builds of gRPC master branch's HEAD are uploaded daily to packages.grpc.io.

To start developing gRPC

Contributions are welcome!

Please read How to contribute which will guide you through the entire workflow of how to build the source code, how to run the tests, and how to contribute changes to the gRPC codebase. The “How to contribute” document also contains info on how the contribution process works and contains best practices for creating contributions.

Troubleshooting

Sometimes things go wrong. Please check out the Troubleshooting guide if you are experiencing issues with gRPC.

Performance

See the Performance dashboard for performance numbers of master branch daily builds.

Concepts

See gRPC Concepts

About This Repository

This repository contains source code for gRPC libraries implemented in multiple languages written on top of a shared C++ core library src/core.

Libraries in different languages may be in various states of development. We are seeking contributions for all of these libraries:

LanguageSource
Shared C++ [core library]src/core
C++src/cpp
Rubysrc/ruby
Pythonsrc/python
PHPsrc/php
C# (core library based)src/csharp
Objective-Csrc/objective-c
LanguageSource repo
Javagrpc-java
Kotlingrpc-kotlin
Gogrpc-go
NodeJSgrpc-node
WebJSgrpc-web
Dartgrpc-dart
.NET (pure C# impl.)grpc-dotnet
Swiftgrpc-swift