ANDROID: Fix heap overflow in sgdisk
If a maliciously formatted USB or SD Card device was inserted into an
Android device, the sgdisk tool could crash. This crash occurs because
sgdisk does not validate that the number of GPT partition entries
specified on disk matches the internal maximum permitted by the GPT spec.
Fix this by sanity checking the on disk parameter before using it.
After the fix, sgdisk detects the corrupt GPT during the formatting
procedure, but it is harmlessly zapped and replaced with a new one.
Test: before fix, saw sgdisk crash while the device was booting up
Test: after fix, no more sgdisk crashes
Test: went through "portable storage" and "adopted storage" wizard flows
using the cuttlefish virtual device and a malicious partition
table flashed to the device
(cherry picked from commit d4d8dd0455312e121d04a1e5a4b8244ff66b6a5e)
1 file changed