| commit | f7428bc397fd1e5bd6162a592ebc988d6d585eb3 | [log] [tgz] |
|---|---|---|
| author | Chingjun Lau <chingjun@google.com> | Thu May 20 16:02:31 2021 -0700 |
| committer | Joshua Peraza <jperaza@chromium.org> | Fri May 21 18:56:41 2021 +0000 |
| tree | 1cad1b4cdc4fe50da1690b9018423fedf186d031 | |
| parent | b7ce678aec90c0fd5dcd445acb0c9f3e3e42ef36 [diff] |
Fix macos_dump_syms when __eh_frame is included in the dSYM file. macho_reader assumes that every section in a segment exists, or none of the sections exist in the file (for dSYM files). https://reviews.llvm.org/D94460?id=315965 added __eh_frame section to the __TEXT segments in dSYM files. All the other sections are removed, but still have non-zero size in the header. macho_reader only looks at `fileoff` and `filesize` fields to determine the size of the segment, but it looks at `addr` and `size` to determine the size of the section, therefore it determines that the sections would not fit in the segment and refused to parse the file. In this case the removed sections all have offset == 0. Ignore such cases. Change-Id: Ife771f7b302c1bc81c673b1103492c41321b5e3e Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2911204 Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Breakpad is a set of client and server components which implement a crash-reporting system.
First, download depot_tools and ensure that they’re in your PATH.
Create a new directory for checking out the source code (it must be named breakpad).
mkdir breakpad && cd breakpad
Run the fetch tool from depot_tools to download all the source repos.
fetch breakpad
cd src
Build the source.
./configure && make
You can also cd to another directory and run configure from there to build outside the source tree.
This will build the processor tools (src/processor/minidump_stackwalk, src/processor/minidump_dump, etc), and when building on Linux it will also build the client libraries and some tools (src/tools/linux/dump_syms/dump_syms, src/tools/linux/md2core/minidump-2-core, etc).
Optionally, run tests.
make check
Optionally, install the built libraries
make install
If you need to reconfigure your build be sure to run make distclean first.
To update an existing checkout to a newer revision, you can git pull as usual, but then you should run gclient sync to ensure that the dependent repos are up-to-date.
Follow the steps above to get the source and build it.
Make changes. Build and test your changes. For core code like processor use methods above. For linux/mac/windows, there are test targets in each project file.
Commit your changes to your local repo and upload them to the server. http://dev.chromium.org/developers/contributing-code e.g. git commit ... && git cl upload ... You will be prompted for credential and a description.
At https://chromium-review.googlesource.com/ you'll find your issue listed; click on it, then “Add reviewer”, and enter in the code reviewer. Depending on your settings, you may not see an email, but the reviewer has been notified with google-breakpad-dev@googlegroups.com always CC’d.