| commit | e6ef7709393d2d16834adea8451b9c164d8ee4ed | [log] [tgz] |
|---|---|---|
| author | Robert Findley <rfindley@google.com> | Wed Feb 23 15:37:02 2022 -0500 |
| committer | Robert Findley <rfindley@google.com> | Thu Feb 24 14:31:55 2022 +0000 |
| tree | 0b7ba46357f3a528ad5e7ddc92d7c8f0f20988e3 | |
| parent | 258e47306680682e73d2b873b69fe7e616ae5490 [diff] |
go/types/typeutil: don't recurse into constraints when hashing tparams When hashing signature type parameters, we recursed into their constraints in an attempt to improve the accuracy of the hash (signatures are considered identical modulo type parameter renaming). This introduces a mechanism for infinite recursion via recursive constraints, as reported in golang/go#51314. To fix this, we can hash just the type parameter index and rely on types.Identical for de-duplicating map entries. Fixes golang/go#51314 Change-Id: Ifd7596d978b98293391bbe64f72f1da2b2a5d51c Reviewed-on: https://go-review.googlesource.com/c/tools/+/387754 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> Reviewed-by: Tim King <taking@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go install.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go install golang.org/x/tools/...@latest.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.