commit | cbdab0337f29854813c47e95cf14a3d6b6e6cf2d | [log] [tgz] |
---|---|---|
author | Muir Manders <muir@mnd.rs> | Fri Mar 18 21:07:51 2022 -0700 |
committer | Robert Findley <rfindley@google.com> | Tue Mar 22 17:37:20 2022 +0000 |
tree | 028475036b83dd13423c43a4f6cdc50d545202b7 | |
parent | 3a6cbd67ddf4b039031861a517e4e1762133a18f [diff] |
lsp/completion: fix bogus type param candidate In this example: func foo[A []int | []float64]() {} foo[<>] When completing at <> you were getting the creative candidate "[]int | []float64". This came from some code that makes the expected type available as a candidate if it wouldn't otherwise be found by a lexical search. I tweaked the code in this case to instead look at each structural type in the type constraint rather than the constraint as a whole. In the above example you now get the candidates "[]int" and "[]float64". Change-Id: Ib8e422df3009cb4253ec66005b4a53851564c4e1 Reviewed-on: https://go-review.googlesource.com/c/tools/+/394015 Run-TryBot: Muir Manders <muir@mnd.rs> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com> Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go install
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go install golang.org/x/tools/...@latest
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.