commit | 707beb0c6308e0b247f3ab133a7a3bbfade2ff2e | [log] [tgz] |
---|---|---|
author | Robert Findley <rfindley@google.com> | Thu Mar 24 17:13:27 2022 -0400 |
committer | Robert Findley <rfindley@google.com> | Fri Mar 25 15:26:50 2022 +0000 |
tree | 2bb1a9ee7623d6742e8cc4a0cd7788ffeb1e542e | |
parent | 1e5ae8399a2b4c8019e7ff391e820ed744d68c56 [diff] |
internal/lsp/source: descend into fields and field lists in qualifyExpr We do a lot of gymnastics to format var types, working around the lack of alias tracking in go/types. As part of this, we clone and qualify expressions. In this case, we were not qualifying identifiers that were contained within fields or field lists. Fix this by updating our expression traversal to include *ast.Field and *ast.FieldList. Fixes golang/go#50539 Change-Id: I6531c6a51aa402bd784778b8bedaa3dccee75af0 Reviewed-on: https://go-review.googlesource.com/c/tools/+/395678 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go install
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go install golang.org/x/tools/...@latest
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.