commit | 1428e83b473713a9252bebd0171aed3e14730135 | [log] [tgz] |
---|---|---|
author | Muir Manders <muir@mnd.rs> | Sat Mar 19 11:21:36 2022 -0700 |
committer | Robert Findley <rfindley@google.com> | Tue Mar 22 17:37:31 2022 +0000 |
tree | c53efab9e2afa7799cb005cdfe6e9d57f6d52b4b | |
parent | cbdab0337f29854813c47e95cf14a3d6b6e6cf2d [diff] |
lsp/completion: fix bogus generic func conversion For example: func foo[A int | float64](a A) A { return a } var _ int = fo<> Previously at <> we would complete to "int(foo[A int|float64](a A))". We added the int() type conversion because the returned type param A was convertible to the expected "int" (i.e. both "int" and "float64" can be converted). This is a premature suggestion, though, so fix by suppressing such type conversions for type parameters. Fixes golang/go#51780. Change-Id: I63e3bd401a4d9927b9261659812c521c02e33d94 Reviewed-on: https://go-review.googlesource.com/c/tools/+/394016 Run-TryBot: Muir Manders <muir@mnd.rs> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com> Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go install
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go install golang.org/x/tools/...@latest
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.