| commit | 954bd92c193e9c6979b5e1265cd7a267748e7b78 | [log] [tgz] |
|---|---|---|
| author | Damien Neil <dneil@google.com> | Wed Jul 17 16:52:10 2019 -0700 |
| committer | Damien Neil <dneil@google.com> | Mon Aug 05 22:33:14 2019 +0000 |
| tree | add8ebbdc280d5e86b15b5c6a92dabd60118f1ac | |
| parent | f542220747e6628d22b7c0a971b07371da7b8efa [diff] |
all: refactor Converter A Converter converts between reflect.Values and protoreflect.Values. The existing usage of Converter is somewhat confusing: The internal/value package creates Converters for scalar types only, the internal/impl package creates Converters for legacy messages and enums, and the reflect/prototype package creates Converters for repeated fields. Change the Converter type to an interface. The constructor for Converter takes a FieldDescriptor and reflect.Type, and directly handles conversions for all field types: Scalars, lists, maps, and legacy types. Move Converter into the internal/impl package, since that package contains the necessary support for dealing with legacy messages and enums. Drop the internal/value package. Replace two uses of prototype.Extension with more focused implementations, since the implementation is trivial with the refactored Converter. Drop prototype.Extension for the moment since it is now unused. Change-Id: If0c570fefac002cc5925b3d56281b6eb17e90d5f Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/187857 Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.