UPSTREAM: linux_spi: Use fgets() to read buffer size
Since fread() returns the number of bytes read, this currently will only
check for errors if it returns 0 (i.e. the file was empty). However, it
is possible for fread() to encounter an error after reading a few bytes,
which this doesn't catch. Fix this by using fgets() instead, which will
return NULL if EOF or an error is encountered, and is simpler anyway.
Original-Change-Id: I4f37c70e97149b87c6344e63a57d11ddde7638c4
Original-Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Original-Found-by: Coverity CID 1403824
Original-Reviewed-on: https://review.coreboot.org/c/flashrom/+/34848
Original-Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Original-Reviewed-by: David Hendricks <david.hendricks@gmail.com>
(cherry picked from commit 1c0c8fd9da34d29d549803f3ddff9a68dd95dfed)
BUG=b:153598437
BRANCH=none
TEST=builds
Tested-by: Nikolai Artemiev <nartemiev@chromium.org>
Signed-off-by: Nikolai Artemiev <nartemiev@chromium.org>
Change-Id: Ia1b3939367366c326208de8a96336f9b1d84eb20
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashrom/+/2230809
Tested-by: Nikolai Artemiev <nartemiev@google.com>
Commit-Queue: Nikolai Artemiev <nartemiev@google.com>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
1 file changed
