)]}' { "log": [ { "commit": "1071b86eeb1af8d79992db13b1e3f883314aeb7f", "tree": "aaeeb5255dd3204f6c5241ef3d419c7d597651ff", "parents": [ "10ab3d5684d607e4639dd7949074d31e874a2ad4", "65c59e023c5336bbd4a23be7af78407e3d80e7e7" ], "author": { "name": "Xin Li", "email": "delphij@google.com", "time": "Fri Dec 20 13:39:37 2024 -0800" }, "committer": { "name": "Xin Li", "email": "delphij@google.com", "time": "Fri Dec 20 13:39:37 2024 -0800" }, "message": "Empty merge ab/12770256 into aosp-main-future\n\nMerged-In: I51ff75cdc990dd43d8c6f6c939fed2134080acae\nChange-Id: I5d54fd82fcdbd5e2da21aff2f36c77d8d966d7cb\n" }, { "commit": "10ab3d5684d607e4639dd7949074d31e874a2ad4", "tree": "aaeeb5255dd3204f6c5241ef3d419c7d597651ff", "parents": [ "3af8e6f6ad3aa496bea4978b76aa74d5c3c4553b", "7998955435c0cfff5a68ba1d36fa7a737fe3671f" ], "author": { "name": "Sadaf Ebrahimi", "email": "sadafebrahimi@google.com", "time": "Wed Dec 18 13:27:36 2024 -0800" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Dec 18 13:27:36 2024 -0800" }, "message": "Add janitors to the OWNERS file am: 7998955435\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/fbjni/+/3423842\n\nChange-Id: I9908af0c7e402118e4bd6af6dbe4cf320cf29244\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "7998955435c0cfff5a68ba1d36fa7a737fe3671f", "tree": "aaeeb5255dd3204f6c5241ef3d419c7d597651ff", "parents": [ "c8aa242439554f5837cae9ec0d53af99c05f8774" ], "author": { "name": "Sadaf Ebrahimi", "email": "sadafebrahimi@google.com", "time": "Wed Dec 18 20:12:09 2024 +0000" }, "committer": { "name": "Sadaf Ebrahimi", "email": "sadafebrahimi@google.com", "time": "Wed Dec 18 20:26:57 2024 +0000" }, "message": "Add janitors to the OWNERS file\n\nTest: TreeHugger\nChange-Id: I8479c58d5407d9d2e403cd452bc154148212aac3\n" }, { "commit": "3af8e6f6ad3aa496bea4978b76aa74d5c3c4553b", "tree": "e815d6cc026c4392ff04d430955ce2e1b796c8a5", "parents": [ "b5aa70bc6e5f433d869f1ee934117fcf3ff614b7", "c8aa242439554f5837cae9ec0d53af99c05f8774" ], "author": { "name": "Qiao Li", "email": "qiaoli@google.com", "time": "Fri Dec 13 16:18:19 2024 -0800" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Fri Dec 13 16:18:19 2024 -0800" }, "message": "Change fbjni to static library am: c8aa242439\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/fbjni/+/3410378\n\nChange-Id: I20a12208de2143817d724173435c826db4fe97fd\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "c8aa242439554f5837cae9ec0d53af99c05f8774", "tree": "e815d6cc026c4392ff04d430955ce2e1b796c8a5", "parents": [ "b5aa70bc6e5f433d869f1ee934117fcf3ff614b7" ], "author": { "name": "Qiao Li", "email": "qiaoli@google.com", "time": "Thu Dec 12 20:25:40 2024 +0000" }, "committer": { "name": "Qiao Li", "email": "qiaoli@google.com", "time": "Fri Dec 13 21:49:21 2024 +0000" }, "message": "Change fbjni to static library\n\nTest: TH\nChange-Id: I91f888841dd8fc131bee601912269b69e3843580\n" }, { "commit": "65c59e023c5336bbd4a23be7af78407e3d80e7e7", "tree": "277907102de1c1514b4cf06bd1c076eb051f4abc", "parents": [ "536c56aac09b36a8d35c2f2f8e703f72e59c714d", "b5aa70bc6e5f433d869f1ee934117fcf3ff614b7" ], "author": { "name": "Inna Palant", "email": "ipalant@google.com", "time": "Wed Dec 04 21:39:12 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Dec 04 21:39:12 2024 +0000" }, "message": "Merge remote-tracking branch \u0027origin/upstream\u0027 am: d7c1b84a31 am: b5aa70bc6e\n\nOriginal change: undetermined\n\nChange-Id: Ibb1316a529c1604f81abe92128fd3aabc40db10f\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "b5aa70bc6e5f433d869f1ee934117fcf3ff614b7", "tree": "277907102de1c1514b4cf06bd1c076eb051f4abc", "parents": [ "536c56aac09b36a8d35c2f2f8e703f72e59c714d", "d7c1b84a31224d95b6627ca1eaab19f546aa9f8d" ], "author": { "name": "Inna Palant", "email": "ipalant@google.com", "time": "Wed Dec 04 21:02:54 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Dec 04 21:02:54 2024 +0000" }, "message": "Merge remote-tracking branch \u0027origin/upstream\u0027 am: d7c1b84a31\n\nOriginal change: undetermined\n\nChange-Id: I602e6a6dd00e54fafa7819707e3495a583d115b9\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "d7c1b84a31224d95b6627ca1eaab19f546aa9f8d", "tree": "277907102de1c1514b4cf06bd1c076eb051f4abc", "parents": [ "536c56aac09b36a8d35c2f2f8e703f72e59c714d", "440a4276105ff5b1634b29828fd5758f13e24c54" ], "author": { "name": "Inna Palant", "email": "ipalant@google.com", "time": "Mon Dec 02 23:55:17 2024 +0000" }, "committer": { "name": "Inna Palant", "email": "ipalant@google.com", "time": "Mon Dec 02 23:55:17 2024 +0000" }, "message": "Merge remote-tracking branch \u0027origin/upstream\u0027\n" }, { "commit": "440a4276105ff5b1634b29828fd5758f13e24c54", "tree": "277907102de1c1514b4cf06bd1c076eb051f4abc", "parents": [ "474795fa9ff0dda60b838871171be935432bae16" ], "author": { "name": "Emily Fu", "email": "fumengyao@google.com", "time": "Mon Nov 25 22:07:36 2024 +0000" }, "committer": { "name": "Emily Fu", "email": "fumengyao@google.com", "time": "Tue Nov 26 19:03:54 2024 +0000" }, "message": "Include platform/external/fbjni\n\nThird-Party Import of:\nhttps://github.com/facebookincubator/fbjni\nRequest Document: go/android3p-revised\nFor CL reviewers: go/android3p#reviewing-a-cl\nFor Build Team:go/ab-third-party-imports\nBug: http://b/379335354\nOriginal import of the code can be found at:\nhttps://googleplex-android.googlesource.com/platform/external/fbjni/+/refs/heads/third-party-review.\nSecurit Questionnaire: http://b/379335354#comment1\n\nTest: third party review\n\nBuild successfully: gpaste/6375123287539712\n\nChange-Id: Ia8afdfae039afba651e08c8122a725d6067bef76\n" }, { "commit": "536c56aac09b36a8d35c2f2f8e703f72e59c714d", "tree": "4b825dc642cb6eb9a060e54bf8d69288fbee4904", "parents": [], "author": { "name": "Inna Palant (xWF)", "email": "ipalant@google.com", "time": "Tue Nov 19 15:51:39 2024 +0000" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Tue Nov 19 15:51:39 2024 +0000" }, "message": "Initial empty repository\n" }, { "commit": "474795fa9ff0dda60b838871171be935432bae16", "tree": "641a2320461ce4c17c5199f5b1a3986b6c32fdf8", "parents": [ "cdd876d092cce80371f982007544f6806cf3838e" ], "author": { "name": "Nicola Corti", "email": "ncor@meta.com", "time": "Tue Sep 24 03:20:05 2024 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Tue Sep 24 03:20:05 2024 -0700" }, "message": "Prepare version 0.7.0 (#100)\n\nSummary:\nPull Request resolved: https://github.com/facebookincubator/fbjni/pull/100\n\nThis just bumps the version of fbjni ahead of a new public release.\n\nReviewed By: alanleedev\n\nDifferential Revision: D63264478\n\nfbshipit-source-id: 4800ff3c02035e75d416257ea6ffe96bb63d4dd1\n" }, { "commit": "cdd876d092cce80371f982007544f6806cf3838e", "tree": "ca9d9401c628734b20eacddd5bab46e8a8e5084f", "parents": [ "72e44a2a16054df85b867dedbbb27eefbf952335" ], "author": { "name": "sentony93", "email": "sentony93@gmail.com", "time": "Fri Sep 20 00:24:56 2024 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Fri Sep 20 00:24:56 2024 -0700" }, "message": "NDK 27 \u0026 Support 16kb page size for Android15 (#98)\n\nSummary:\n## Motivation\n\nhttps://github.com/facebookincubator/fbjni/issues/97\n\nUpdated ndk to 27, enabled flexible page size support\n\nhttps://developer.android.com/guide/practices/page-sizes#compile-r27-higher\n\nPull Request resolved: https://github.com/facebookincubator/fbjni/pull/98\n\nTest Plan: Built locally and checked alignment via test method [here](https://developer.android.com/guide/practices/page-sizes#test) as well as `objdump` on the binary\n\nReviewed By: alanleedev\n\nDifferential Revision: D63021463\n\nPulled By: cortinico\n\nfbshipit-source-id: d4415440836b138a76bc101320dbe4b98c32f3c7\n" }, { "commit": "72e44a2a16054df85b867dedbbb27eefbf952335", "tree": "f49072dd1e1d9299246ac8190c7a7964bad6ad57", "parents": [ "e9af44ffbce7e589e43b2cb0a7bed3911a630ee4" ], "author": { "name": "Nicola Corti", "email": "corti.nico@gmail.com", "time": "Thu Sep 19 04:10:10 2024 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Thu Sep 19 04:10:10 2024 -0700" }, "message": "Fix CI broken for host.gradle (#99)\n\nSummary:\n## Motivation\n\nCI is currently broken, this fixes it.\n\nPull Request resolved: https://github.com/facebookincubator/fbjni/pull/99\n\nTest Plan: CI is green now\n\nReviewed By: passy\n\nDifferential Revision: D63022694\n\nPulled By: cortinico\n\nfbshipit-source-id: 68a78cfb0d7fae8be823edafe40e8a82fe29b166\n" }, { "commit": "e9af44ffbce7e589e43b2cb0a7bed3911a630ee4", "tree": "7b54d96ad6f2725871e43cebaf8e548fcd074570", "parents": [ "95a6972e70c2976f6447643f06e1e9742aa5ff5b" ], "author": { "name": "generatedunixname89002005287564", "email": "generatedunixname89002005287564@meta.com", "time": "Mon Aug 12 07:15:36 2024 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Mon Aug 12 07:15:36 2024 -0700" }, "message": "fbandroid/libraries/fbjni/test/FBJniTests.java\n\nReviewed By: jocelynluizzi13\n\nDifferential Revision: D61110517\n\nfbshipit-source-id: 49b7664ac2f307f1fa615289aad8960f6f92a99b\n" }, { "commit": "95a6972e70c2976f6447643f06e1e9742aa5ff5b", "tree": "b321c482ceb73439f60d03fc89cbe5d29d349f31", "parents": [ "4ec7ce4db211ce1c4cb280fad6c26f8173e1e029" ], "author": { "name": "Richard Barnes", "email": "rbarnes@meta.com", "time": "Fri Aug 02 14:20:17 2024 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Fri Aug 02 14:20:17 2024 -0700" }, "message": "Remove unused exception parameter from fbandroid/libraries/fbjni/test/jni/inter_dso_exception_test_2/Test.cpp\n\nSummary:\n`-Wunused-exception-parameter` has identified an unused exception parameter. This diff removes it.\n\nThis:\n```\ntry {\n ...\n} catch (exception\u0026 e) {\n // no use of e\n}\n```\nshould instead be written as\n```\n} catch (exception\u0026) {\n```\n\nIf the code compiles, this is safe to land.\n\nReviewed By: dmm-fb\n\nDifferential Revision: D60515202\n\nfbshipit-source-id: 9e1552ed8a7dc2530d3efbf457ed9abcc16434a1\n" }, { "commit": "4ec7ce4db211ce1c4cb280fad6c26f8173e1e029", "tree": "fbcdba57a20ae4226e6b63581a7c1f59d4873b99", "parents": [ "231bed1f746e665abe614671284067cab6fb011a" ], "author": { "name": "Shoaib Meenai", "email": "smeenai@meta.com", "time": "Mon Jun 17 14:35:10 2024 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Mon Jun 17 14:35:10 2024 -0700" }, "message": "Update for libc++ 18\n\nSummary:\nlibc++ 18 adds `__cxa_init_primary_exception` and uses it to speed up\n`std::make_exception_ptr`, so `exception_ptr` objects created by it\nwould not have stack traces attached (since they bypassed `__cxa_throw`,\nwhich Lyra was using to attach the stack traces). `__cxa_throw` calls\n`__cxa_init_primary_exception`, so we can hook the new function instead\nwhere supported. Change Lyra\u0027s APIs a bit to abstract the choice of\nhooking function.\n\nReviewed By: yozhu, thevinster\n\nDifferential Revision: D58622936\n\nfbshipit-source-id: c7a8213c8cbcce847b70002130f133da07852b9f\n" }, { "commit": "231bed1f746e665abe614671284067cab6fb011a", "tree": "e754e647275f2eb1848cb71dc8b6bf21fa16bfed", "parents": [ "968e3815f92aeb0670f5d88ae975fbbd47a4b482" ], "author": { "name": "Shoaib Meenai", "email": "smeenai@meta.com", "time": "Mon Jun 17 14:35:10 2024 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Mon Jun 17 14:35:10 2024 -0700" }, "message": "Remove libstdc++ support\n\nSummary:\nAndroid only uses libc++ now. The libc++ implementation should also work\nfor libstdc++ though (for other platforms if desired). The libc++\nimplementation doesn\u0027t rely on any headers not available on Windows so\nwe can remove the `_WIN32` conditionals (though it still won\u0027t work on\nWindows because of ABI library differences, but that\u0027s not different\nfrom before).\n\nReviewed By: thevinster\n\nDifferential Revision: D58622935\n\nfbshipit-source-id: aa55809d570101c1be97184feb8255aa61bb66eb\n" }, { "commit": "968e3815f92aeb0670f5d88ae975fbbd47a4b482", "tree": "4e718acc97f002a222209b8a3ed85671fa55f4bc", "parents": [ "cd6e61a96129bdf70dc1e3c967c5ec29f4d4eeb1" ], "author": { "name": "Andres Suarez", "email": "asuarez@meta.com", "time": "Sun Apr 14 11:28:32 2024 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Sun Apr 14 11:28:32 2024 -0700" }, "message": "Apply clang-format 18\n\nSummary: Previously this code conformed from clang-format 12.\n\nReviewed By: igorsugak\n\nDifferential Revision: D56065247\n\nfbshipit-source-id: f5a985dd8f8b84f2f9e1818b3719b43c5a1b05b3\n" }, { "commit": "cd6e61a96129bdf70dc1e3c967c5ec29f4d4eeb1", "tree": "93c5541161d86d554ce0bc3e254fdbec6b7c86a1", "parents": [ "17d30bcafd678ec7fb2b5ff185e07d48fcb1cee6" ], "author": { "name": "Edward Pastuszenski", "email": "egp@meta.com", "time": "Thu Apr 11 16:41:37 2024 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Thu Apr 11 16:41:37 2024 -0700" }, "message": "Log Java stack trace for uncaught JniExceptions\n\nSummary: `JniException::what` is used as the abort message when a `JniException` is uncaught. It is currently missing the stack trace information you\u0027d need to debug the underlying Java `Exception`.\n\nReviewed By: mhorowitz\n\nDifferential Revision: D55830419\n\nfbshipit-source-id: 82992db5e60871cf78a779d56aa3528c2c8b8e68\n" }, { "commit": "17d30bcafd678ec7fb2b5ff185e07d48fcb1cee6", "tree": "13351f5b3f9fed73f71934d63016199a59871093", "parents": [ "8862b326f7fe7bb68a99c6fc631f6179db8e3a30" ], "author": { "name": "Jeff Bahr", "email": "jbahr@meta.com", "time": "Sat Mar 23 16:07:04 2024 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Sat Mar 23 16:07:04 2024 -0700" }, "message": "Migrate google java format from 1.7 -\u003e 1.21.0 (#95)\n\nSummary:\nX-link: https://github.com/facebookexternal/OculusManufacturing/pull/524\n\nX-link: https://github.com/facebookexternal/fbpay/pull/3\n\nX-link: https://github.com/facebook/screenshot-tests-for-android/pull/324\n\nX-link: https://github.com/pytorch/executorch/pull/1771\n\nX-link: https://github.com/facebook/igl/pull/68\n\nX-link: https://github.com/facebook/mariana-trench/pull/153\n\nX-link: https://github.com/facebook/fresco/pull/2757\n\nX-link: https://github.com/facebook/litho/pull/974\n\nX-link: https://github.com/facebook/react-native/pull/42754\n\nX-link: https://github.com/facebook/hhvm/pull/9431\n\nX-link: https://github.com/WhatsApp/eqwalizer/pull/52\n\nX-link: https://github.com/facebookincubator/spectrum/pull/1858\n\nX-link: https://github.com/fbsamples/metapay/pull/1\n\nPull Request resolved: https://github.com/facebookincubator/fbjni/pull/95\n\nX-link: https://github.com/facebookincubator/Battery-Metrics/pull/30\n\nX-link: https://github.com/facebook/ktfmt/pull/440\n\nX-link: https://github.com/facebook/flipper/pull/5456\n\nX-link: https://github.com/facebook/hermes/pull/1290\n\nX-link: https://github.com/facebook/TextLayoutBuilder/pull/35\n\nX-link: https://github.com/facebook/SoLoader/pull/122\n\nallow-large-files\n\nThis diff migrates google java format form 1.7 to 1.21.0. This update will allow for new language features from java 17 and 21. This diff also formats all necessary files.\n\n Changelog:\n [Internal][Changed] - Updated format from google-java-format 1.7 -\u003e 1.21.0\n\nReviewed By: IanChilds\n\nDifferential Revision: D52786052\n\nfbshipit-source-id: b675ae215084f340b93dfe628e329e696ca0616e\n" }, { "commit": "8862b326f7fe7bb68a99c6fc631f6179db8e3a30", "tree": "16d2a64fb5361424dab7a624bfa9b6fe2a10a27e", "parents": [ "5587a7fd2b191656be9391a3832ce04c034009a5" ], "author": { "name": "(SWE@Signals)", "email": "(SWE@Signals)", "time": "Tue Mar 12 18:08:53 2024 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Tue Mar 12 18:08:53 2024 -0700" }, "message": "h2kt - support set\n\nSummary: as title\n\nDifferential Revision: D54783575\n\nfbshipit-source-id: 8dfe7b466d215e03cf7fe5ca495d949b88d63d2c\n" }, { "commit": "5587a7fd2b191656be9391a3832ce04c034009a5", "tree": "775ed4b7f030e94c3403b72555a73873c0cbbdae", "parents": [ "1cf763714e99d45c23dfb316d702ebfa8290af64" ], "author": { "name": "Nicola Corti", "email": "ncor@meta.com", "time": "Tue Jan 30 06:47:53 2024 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Tue Jan 30 06:47:53 2024 -0800" }, "message": "Prepare upcoming version of fbjni\n\nSummary: Prepare upcoming version of fbjni\n\nReviewed By: cipolleschi\n\nDifferential Revision: D53223559\n\nfbshipit-source-id: e2c085214a7b978bf6804bbdcb95d4cf1eada251\n" }, { "commit": "1cf763714e99d45c23dfb316d702ebfa8290af64", "tree": "79da6f743b82fb782f183fa7c01c7b171971451f", "parents": [ "3bf81724cf91f964c8192471064754c41eb3c16d" ], "author": { "name": "Nicola Corti", "email": "ncor@meta.com", "time": "Sat Jan 27 10:37:05 2024 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Sat Jan 27 10:37:05 2024 -0800" }, "message": "Prepare version 0.6.0\n\nSummary: Time to publish version 0.6.0 which comes with a new NDK version\n\nReviewed By: mdvacca\n\nDifferential Revision: D53155847\n\nfbshipit-source-id: 38e9c237d8128ac924646a552c78f5c16c0e55c5\n" }, { "commit": "3bf81724cf91f964c8192471064754c41eb3c16d", "tree": "0b25a4f90025476324339ade7122c784fadfe9a6", "parents": [ "0454714cf0692c4efdb49a94d29d5d8f11667bbc" ], "author": { "name": "Marc Rousavy", "email": "me@mrousavy.com", "time": "Fri Jan 26 17:04:58 2024 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Fri Jan 26 17:04:58 2024 -0800" }, "message": "feat: Bump Android NDK (#94)\n\nSummary:\n## Motivation\n\nBumps Android NDK version to 26.1.xxx - see https://github.com/facebook/react-native/pull/42656, cc cortinico\n\nbump in gradle\n\nPull Request resolved: https://github.com/facebookincubator/fbjni/pull/94\n\nTest Plan: build app\n\nReviewed By: NickGerleman\n\nDifferential Revision: D53122799\n\nPulled By: cortinico\n\nfbshipit-source-id: 4a256d4e595ea7025b80b98260330827023a07a0\n" }, { "commit": "0454714cf0692c4efdb49a94d29d5d8f11667bbc", "tree": "d58f8a2354be2e50662eb37bc3e42e40f65d49d1", "parents": [ "8b45d9c9178e2e1f3f09f93e761fda1c7ddcbac0" ], "author": { "name": "Marc Rousavy", "email": "me@mrousavy.com", "time": "Thu Jan 25 14:31:45 2024 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Thu Jan 25 14:31:45 2024 -0800" }, "message": "feat: Add `bigEndian()` and `littleEndian()` fields to `JByteOrder` (#93)\n\nSummary:\n## Motivation\n\n`JByteBuffer`s could only be initialized with `nativeOrder` endianness.\nWith this PR, both `littleEndian()` and `bigEndian()` fields are exposed in `JByteOrder` and can now be set through `JByteBuffer::order(...)`.\n\nGet static fields `LITTLE_ENDIAN` and `BIG_ENDIAN` through `JByteOrder`.\n\nPull Request resolved: https://github.com/facebookincubator/fbjni/pull/93\n\nTest Plan:\nTest code:\n\nDefault:\n\n```cpp\nauto buffer \u003d JByteBuffer::allocateDirect(5);\nuint8_t* data \u003d buffer-\u003egetDirectData();\ndata[0] \u003d 255;\ndata[1] \u003d 1;\n__android_log_print(ANDROID_LOG_INFO, \"Test\", \"First item: %i\", data[0]);\n```\n\nWith custom Endian:\n\n```cpp\nauto buffer \u003d JByteBuffer::allocateDirect(5);\nbuffer-\u003eorder(JByteOrder::bigEndian()); // \u003c-- or littleEndian()\nuint8_t* data \u003d buffer-\u003egetDirectData();\ndata[0] \u003d 255;\ndata[1] \u003d 1;\n__android_log_print(ANDROID_LOG_INFO, \"Test\", \"First item: %i\", data[0]);\n```\n\nReviewed By: cipolleschi\n\nDifferential Revision: D53089814\n\nPulled By: cortinico\n\nfbshipit-source-id: 4f683ccba46caf5a62842944d44b3a201473f522\n" }, { "commit": "8b45d9c9178e2e1f3f09f93e761fda1c7ddcbac0", "tree": "4d3e1c32c6770e481ffdee00f101a9270fbd9baa", "parents": [ "00c867220b04f90e128c2ae49178e51354ddc9fa" ], "author": { "name": "Oskar Wirga", "email": "oskarwirga@meta.com", "time": "Thu Jan 18 18:53:51 2024 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Thu Jan 18 18:53:51 2024 -0800" }, "message": "Add dynamic_fn_ptr attribute to dynamic fn ptrs in M4A\n\nSummary:\nThis list was generated using warnings logged to the console as part of D51514310. The warnings were then manually assessed as to whether they were true positives or false positives using either \"dynamic_fn_ptr\" or \"ignore_dlsym\" annotations.\n\nI repeated this process and compiled M4A until there were no warnings logged to the console.\n\nFor files that touch open source or are just generally a pain to deal with, I left them ignorelisted as they really didn\u0027t seem to contain other function pointers we should be protecting.\n\nReviewed By: sampriti-fb\n\nDifferential Revision: D52634681\n\nfbshipit-source-id: 73c3c84a44d1289a617d0721d8512854dc530848\n" }, { "commit": "00c867220b04f90e128c2ae49178e51354ddc9fa", "tree": "254ade25c6ddbbb852bb32e7eaeeb34203263698", "parents": [ "0f2b807fbacfd04e67b62480d8d9c54ceca2bbed" ], "author": { "name": "Nick Gerleman", "email": "ngerlem@meta.com", "time": "Thu Jan 11 01:11:41 2024 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Thu Jan 11 01:11:41 2024 -0800" }, "message": "Start enabling -Wextra and -Wconversion in \"rn_xplat_cxx_library\" (1/2)\n\nSummary:\n## Stack\n\nThese can suss out some real bugs, and helps further avoid mismatch with downstream MSVC on /W4 as used by MSFT.\n\nI enabled the families of warnings, but suppressed some major individual warnings that weren\u0027t clean. But I did clean some up, notably, missing initializer, and shortening 64 bit to 32 bit. We can do some of the rest incrementally (e.g. `-Wunused-parameter` has a fixit).\n\nThis change illuminates that MapBuffer is missing 64 bit integer support, but we often pass 64 bit counters to it, which is a bug. For now I just left TODOs around those.\n\n`rn_xplat_cxx_library` is used for external libraries interfacing with RN, which we probably don\u0027t want to police, so I structured these stricter warnings as an opt-in flag, only enabled for our own rules.\n\n## Diff\n\nThis fixes up source code to avoid emitting the extra warnings now enforced. Of what is enabled, this is mostly shortening 64 to 32, or missing field in initializer.\n\nChangelog: [Internal]\n\nReviewed By: christophpurrer\n\nDifferential Revision: D52589303\n\nfbshipit-source-id: 11cb778d065799fd0ead3ae706934146d13500bb\n" }, { "commit": "0f2b807fbacfd04e67b62480d8d9c54ceca2bbed", "tree": "0bcae33b71b323bb64b56518c8f1dd2e28f118ad", "parents": [ "08a04f0456ed9f5d45b12fd4af82a3776a22c2f2" ], "author": { "name": "Sergei Semenov", "email": "ssa@meta.com", "time": "Sun Nov 12 13:41:00 2023 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Sun Nov 12 13:41:00 2023 -0800" }, "message": "Use a separate executor/thread for ClientSync\n\nSummary: Sometimes ClientSync never gets created because the relevant task, which is scheduled on an executor, is never called. We do not know the root cause, but we (Kay, Michael, JP, and I) attempt to minimize the severity of the issue by creating a separate executor/thread for ClientSync on every new TW cast session.\n\nDifferential Revision: D51184111\n\nfbshipit-source-id: 7fa7265f928671d95c1791eb111707584fb16efe\n" }, { "commit": "08a04f0456ed9f5d45b12fd4af82a3776a22c2f2", "tree": "522cbd127aa0a0bd2bd7c5f76500a789243ad981", "parents": [ "d1289137ff5abaf6fc70030614bb00d1a8fcba72" ], "author": { "name": "Nick Gerleman", "email": "ngerlem@meta.com", "time": "Fri Nov 10 16:53:18 2023 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Fri Nov 10 16:53:18 2023 -0800" }, "message": "Bump Gradle minSdkVersion (#91)\n\nSummary:\nPull Request resolved: https://github.com/facebookincubator/fbjni/pull/91\n\nhttps://github.com/facebookincubator/fbjni/commit/bd94aae8f47ffa012783b94bf53379f0db84f725 bumped to NDK 26 (latest LTS NDK).\n\nNDK 26 [dropped](https://github.com/android/ndk/wiki/Changelog-r26) [support](https://github.com/android/ndk/issues/1751) for KitKat, and NDK 25 already required minSDK 19, so our minSdk of 15 is too low.\n\nThis bumps the minSdk, so that when we publish AARs for next fbjni published version, it errors if user is on earlier SDK.\n\nReviewed By: rshest\n\nDifferential Revision: D51146044\n\nfbshipit-source-id: de1b38de0f2bd0afe9ed7ac074eaf7eb07903d40\n" }, { "commit": "d1289137ff5abaf6fc70030614bb00d1a8fcba72", "tree": "60a0c86676588e1eb9ed98866ae9517a31f43270", "parents": [ "59461eff6c7881d58e958287481e1f1cd99e08d3" ], "author": { "name": "generatedunixname89002005287564", "email": "generatedunixname89002005287564@meta.com", "time": "Thu Nov 09 12:39:24 2023 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Thu Nov 09 12:39:24 2023 -0800" }, "message": "xplat/arfx/atlas/core/presenter/java/jni\n\nReviewed By: nlutsenko\n\nDifferential Revision: D51164212\n\nfbshipit-source-id: ad6c60d40809ce3b5f3c19ddf758cecd0a0d0579\n" }, { "commit": "59461eff6c7881d58e958287481e1f1cd99e08d3", "tree": "6d2d06324a91737b37a3d426836087f25d22645c", "parents": [ "408af4e82093c041e8b0b6c98c96f9cb4fa5d59f" ], "author": { "name": "Nick Gerleman", "email": "ngerlem@meta.com", "time": "Thu Nov 09 10:01:43 2023 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Thu Nov 09 10:01:43 2023 -0800" }, "message": "Fix missing \"#include\" causing GitHub Actions failure (#92)\n\nSummary:\nPull Request resolved: https://github.com/facebookincubator/fbjni/pull/92\n\nfbjni OSS tests will build a binary using `ubuntu-latest` Clang + stdlibc++ toolchain. https://github.com/facebookincubator/fbjni/blob/main/scripts/run-host-tests.sh\n\nThe stdlib version changed, and now we fail to build, because `#include \u003cstring\u003e` or another header is no longer pulling in `\u003ccstdint\u003e` for us.\n\nReviewed By: cipolleschi\n\nDifferential Revision: D51146182\n\nfbshipit-source-id: 1bc532b36b8acd0f54b454cc9fcc90a9bd4cf245\n" }, { "commit": "408af4e82093c041e8b0b6c98c96f9cb4fa5d59f", "tree": "773ad8a3ca2744795d00c24be28779f046d2455d", "parents": [ "12995ec0d27d682ebad4a6986913a303cac1693d" ], "author": { "name": "Nikita Lutsenko", "email": "nlutsenko@meta.com", "time": "Wed Nov 08 11:39:44 2023 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Wed Nov 08 11:39:44 2023 -0800" }, "message": "fbjni | Fix lints exposed by clang-tidy\n\nDifferential Revision: D51020426\n\nfbshipit-source-id: 8a872650ed53f6716eed67299aa03b671074723e\n" }, { "commit": "12995ec0d27d682ebad4a6986913a303cac1693d", "tree": "36e7a191bbf1cf6c84fac04363fc804ae3955418", "parents": [ "bd94aae8f47ffa012783b94bf53379f0db84f725" ], "author": { "name": "generatedunixname89002005287564", "email": "generatedunixname89002005287564@meta.com", "time": "Wed Nov 08 09:13:49 2023 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Wed Nov 08 09:13:49 2023 -0800" }, "message": "xplat/arfx/atlas/core/presenter/java/jni\n\nDifferential Revision: D51107140\n\nfbshipit-source-id: c418fd15ac3f376d55b6d5b90565acfebf0ad11f\n" }, { "commit": "bd94aae8f47ffa012783b94bf53379f0db84f725", "tree": "f314cc37c23f2ea3bb4e3dfb200e45a4ce2af0fb", "parents": [ "52a14f0daa889a20d8984798b8d96eb03cebd334" ], "author": { "name": "Nick Gerleman", "email": "ngerlem@meta.com", "time": "Mon Oct 16 14:59:58 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Mon Oct 16 14:59:58 2023 -0700" }, "message": "Bump to NDK 26 (#89)\n\nSummary:\nPull Request resolved: https://github.com/facebookincubator/fbjni/pull/89\n\nThis bumps fbjni to NDK 26, the latest stable NDK, lining up with RN 0.74, and the next published version of Yoga.\n\nGoogle [documents](https://developer.android.com/ndk/guides/middleware-vendors#choosing_api_levels_and_ndk_versions) the expected NDK to NDK compatibility:\n\n\u003e NDK versions are largely compatible with each other, but occasionally there are changes that break compatibility. If you know that all of your users are using the same version of the NDK, it\u0027s best to use the same version that they do. Otherwise, use the newest version.\n\nReviewed By: christophpurrer, cortinico\n\nDifferential Revision: D50296514\n\nfbshipit-source-id: b03510dc4fb046aa7e74bb794e105ab6a08e95c2\n" }, { "commit": "52a14f0daa889a20d8984798b8d96eb03cebd334", "tree": "8a636159fe7d782547b79ac715e3ac21d64d30bf", "parents": [ "4e00822a88d22a7cc89e872c95e458206d1d191e" ], "author": { "name": "Max Kareta", "email": "mkareta@meta.com", "time": "Wed Aug 30 05:48:24 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Wed Aug 30 05:48:24 2023 -0700" }, "message": "fixed -Wdocumentation warning\n\nSummary:\nfixed\nwarning: parameter \u0027ref\u0027 not found in the function declaration [-Wdocumentation]\n\nDifferential Revision: D48782622\n\nfbshipit-source-id: a22ecb8c75468862743adb674e17ab44e8b28635\n" }, { "commit": "4e00822a88d22a7cc89e872c95e458206d1d191e", "tree": "fbb7dc0138cfc9ac638f49fdb579f7b28338064a", "parents": [ "070e640fa734601888c743acadc0fd6b62138374" ], "author": { "name": "Andrew Calvano", "email": "calvano@meta.com", "time": "Mon Jul 31 08:35:21 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Mon Jul 31 08:35:21 2023 -0700" }, "message": "Back out \"Fuzzing harness for fbjni utf16toUTF8\"\n\nSummary:\nOriginal commit changeset: b4ca1383f0d8\n\nOriginal Phabricator Diff: D47807803\n\nDifferential Revision: D47917622\n\nfbshipit-source-id: 4e7de4f1d10e6b8979dde85ef3da21d22b97752b\n" }, { "commit": "070e640fa734601888c743acadc0fd6b62138374", "tree": "f09c2346d4dab9aa41b302cb5f23dc11aa26f61f", "parents": [ "66fa2976a15994f80be491ee5197e386157f0a6e" ], "author": { "name": "Andrew Calvano", "email": "calvano@meta.com", "time": "Mon Jul 31 06:40:49 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Mon Jul 31 06:40:49 2023 -0700" }, "message": "Fuzzing harness for fbjni utf16toUTF8\n\nSummary: Project Sierra showed a crash in this code. While we don\u0027t know exactly how its used its worth putting up a fuzzer for it.\n\nReviewed By: alichtman\n\nDifferential Revision: D47807803\n\nfbshipit-source-id: b4ca1383f0d87f628bc1124068b994c27ee14d53\n" }, { "commit": "66fa2976a15994f80be491ee5197e386157f0a6e", "tree": "fbb7dc0138cfc9ac638f49fdb579f7b28338064a", "parents": [ "8dc225aba6ba41983b0f1ddb73300208b00cf405" ], "author": { "name": "Nicola Corti", "email": "ncor@meta.com", "time": "Wed Jul 26 10:55:12 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Wed Jul 26 10:55:12 2023 -0700" }, "message": "Prepare 0.6.0-SNAPSHOT and fix double closing issue\n\nSummary:\nBumping the version number to 0.6.0-SNAPSHOT as 0.5.1 has been published\nPlus the `closeAndReleaseRepository` job has failed in the last run as there were two staging repository (one for `fbjni` and `fbjni-java-only`).\nI\u0027m fixing this by invoking `closeAndReleaseRepository` twice, after every `publish` call.\n\nReviewed By: passy\n\nDifferential Revision: D47755250\n\nfbshipit-source-id: c91189b308dc40567413e36d1c862c9ac5cc2548\n" }, { "commit": "8dc225aba6ba41983b0f1ddb73300208b00cf405", "tree": "d989f34698f78fccef63a9fde67b43c38160f4e4", "parents": [ "7621c81d3b3f6b7abf541a973b3f04f69e5fbe9d" ], "author": { "name": "Nicola Corti", "email": "ncor@meta.com", "time": "Mon Jul 24 06:57:54 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Mon Jul 24 06:57:54 2023 -0700" }, "message": "0.5.1 Correctly publish the -java-only artifact and the -headers artifact\n\nSummary:\nFixes #85\n\nI\u0027ve realized that 0.5.0 was published successfully, but the `fbjni-java-only` artifact and the `headers`\nartifacts are missing. This is because the publishing plugin was not applied to the host build, and\nchanges on the maven publish plugin required a bit more changes on the build files.\n\nI\u0027ve fixed them all and verified on maven local that everything publishes correctly.\n\nI\u0027m also bumping the version to 0.5.1 to publish a new version.\n\nReviewed By: cipolleschi\n\nDifferential Revision: D47718649\n\nfbshipit-source-id: bcc95fb6011867d61bbeac26c9f61b4149bf0e49\n" }, { "commit": "7621c81d3b3f6b7abf541a973b3f04f69e5fbe9d", "tree": "bd9db7fe7e502d0f3305e87cbe70e45c9fbb05ba", "parents": [ "c58c8eed0489967370ae6e07b5ed66000dd090d2" ], "author": { "name": "Nicola Corti", "email": "ncor@meta.com", "time": "Mon Jul 24 02:29:05 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Mon Jul 24 02:29:05 2023 -0700" }, "message": "Add missing publishing properties to gradle.properties\n\nSummary:\nThe publishing of fbjni 0.5.0 is still failing due to a couple of missing properties:\n```\nSONATYPE_HOST\u003dDEFAULT\nRELEASE_SIGNING_ENABLED\u003dtrue\n```\nI\u0027ve added them as suggested here: https://vanniktech.github.io/gradle-maven-publish-plugin/central/#configuring-maven-central\n\nPlus I\u0027ve also cleaned up a bit the buildscript.\n\nReviewed By: cipolleschi\n\nDifferential Revision: D47712906\n\nfbshipit-source-id: 5062ee43f88c0cb91210200e891da75655e7b966\n" }, { "commit": "c58c8eed0489967370ae6e07b5ed66000dd090d2", "tree": "5db7f53c6b55b069aa3ece0cf746e419273008f8", "parents": [ "e058590a68bf3e16fe2d6187842af10600bff828" ], "author": { "name": "Nicola Corti", "email": "ncor@meta.com", "time": "Fri Jul 21 09:53:56 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Fri Jul 21 09:53:56 2023 -0700" }, "message": "Fix publishing for 0.5.0\n\nSummary:\nPublishing on fbjni 0.5.0 just failed as the `publish` task is missing when applying the `host.gradle` file.\nThis fixes it.\n\nReviewed By: passy\n\nDifferential Revision: D47664137\n\nfbshipit-source-id: 0906a0ca4c77897427d71c2e62c0b9888e634e70\n" }, { "commit": "e058590a68bf3e16fe2d6187842af10600bff828", "tree": "ce5830b76336b3874c36d4ea9a121a880d0589cc", "parents": [ "147c95b292bf2c2d4f577cd4ba5fc66a1143714d" ], "author": { "name": "Nicola Corti", "email": "ncor@meta.com", "time": "Thu Jul 20 10:41:57 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Thu Jul 20 10:41:57 2023 -0700" }, "message": "Bump Version to 0.5.0\n\nSummary: As this version was built with NDK 25, let\u0027s bump the minor version before releasing it.\n\nReviewed By: luluwu2032\n\nDifferential Revision: D47636497\n\nfbshipit-source-id: cceb615b416a28a49c9ab5fe5bf4b7e1dbfabf91\n" }, { "commit": "147c95b292bf2c2d4f577cd4ba5fc66a1143714d", "tree": "9a120e17f7837daf93150d2d570ebf362f775184", "parents": [ "f6969e1319f782c85e752d530acccb7c58ac6d6e" ], "author": { "name": "Aaron Lichtman", "email": "alichtman@meta.com", "time": "Wed Jul 12 14:08:14 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Wed Jul 12 14:08:14 2023 -0700" }, "message": "Format fbjni with CLANGFORMAT\n\nSummary:\n```\n[alichtman@185611 fbsource]$ arc lint --apply-patches --take CLANGFORMAT --paths-cmd \u0027hg files fbandroid/libraries/fbjni\u0027\n```\n\nReviewed By: zertosh\n\nDifferential Revision: D47400803\n\nfbshipit-source-id: eb056375abc4264d1cee282444a309e64c2ccd5c\n" }, { "commit": "f6969e1319f782c85e752d530acccb7c58ac6d6e", "tree": "4e74efd6fce085139bc4911552a54ca5146796fd", "parents": [ "b8a7f9e3c26a053b17f09894ec3c5704155e5796" ], "author": { "name": "Aaron Lichtman", "email": "alichtman@meta.com", "time": "Wed Jul 12 14:08:14 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Wed Jul 12 14:08:14 2023 -0700" }, "message": "Format fb-ffmpeg with CLANGFORMAT\n\nSummary:\n`fb-ffmpeg` was opted out of CLANGFORMAT in D31456555 because it had \u003e 5 dirty files.\n\nI opted it back in, and ran the linter. It seems useful to have it enabled?\n\n```\n$ arc lint --apply-patches --take CLANGFORMAT --paths-cmd \u0027fbandroid/libraries/ffmpeg/native/fb-ffmpeg\u0027\n```\n\nReviewed By: zertosh\n\nDifferential Revision: D47399327\n\nfbshipit-source-id: ce0c0dbdab5d20e529f5b9c144a41bfae18dbafc\n" }, { "commit": "b8a7f9e3c26a053b17f09894ec3c5704155e5796", "tree": "a84a3736bc472bdc60bb225089ee480cc8fe6e78", "parents": [ "22a9cdb082e9fade3089560fdff36dbc5132a6b1" ], "author": { "name": "Benjamin Jaeger", "email": "bjaeger@meta.com", "time": "Wed Jul 05 11:16:18 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Wed Jul 05 11:16:18 2023 -0700" }, "message": "fbjni - Add getApplication() to AContext\n\nReviewed By: nlutsenko\n\nDifferential Revision: D47159377\n\nfbshipit-source-id: 055e65e4c56299c7226217df7435b2d1a6ac1d3f\n" }, { "commit": "22a9cdb082e9fade3089560fdff36dbc5132a6b1", "tree": "49185382f722361bbc85846857653efd65f8b095", "parents": [ "cc92b5d1a96f243ee4f3ea366852d2652eaf903c" ], "author": { "name": "Nicola Corti", "email": "ncor@meta.com", "time": "Fri Jun 23 02:51:41 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Fri Jun 23 02:51:41 2023 -0700" }, "message": "compile/target SDK to 33\n\nSummary:\nWe fell behind in terms of supported Android version.\nI\u0027m bumping this up to the latest stable.\n\nReviewed By: passy, lblasa\n\nDifferential Revision: D46844312\n\nfbshipit-source-id: 2108035ee6e13012ddc52bb96769aeeafaff2a25\n" }, { "commit": "cc92b5d1a96f243ee4f3ea366852d2652eaf903c", "tree": "b779f848acfeca0a2cd55098bda997f207cc8823", "parents": [ "43d1b7dc71b266838e355fd58727287905329146" ], "author": { "name": "Nicola Corti", "email": "ncor@meta.com", "time": "Fri Jun 23 02:51:41 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Fri Jun 23 02:51:41 2023 -0700" }, "message": "NDK to 25.1.8937393\n\nSummary: This is a major bump of the NDK. We\u0027ll need once we want to bump the NDK to 25 inside React Native.\n\nReviewed By: lblasa\n\nDifferential Revision: D46844316\n\nfbshipit-source-id: 67c2cf5cbd3c59ec0ee555e29e19b88b17dbecf3\n" }, { "commit": "43d1b7dc71b266838e355fd58727287905329146", "tree": "da393e5a0c53f68e82baba0d8fb3bc1835b3c2ee", "parents": [ "49ef4a588cf5f4150befc98626eee2fb152b2e5d" ], "author": { "name": "Nicola Corti", "email": "ncor@meta.com", "time": "Fri Jun 23 02:51:41 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Fri Jun 23 02:51:41 2023 -0700" }, "message": "CMake to 3.22.1\n\nSummary: This bumps CMake to the default version shipped with AGP 8.x\n\nReviewed By: lblasa\n\nDifferential Revision: D46844319\n\nfbshipit-source-id: 4f894919b2190a037b429e3ef4f24792e3cb7b43\n" }, { "commit": "49ef4a588cf5f4150befc98626eee2fb152b2e5d", "tree": "fc1cf2d7ae30efd01adb52351d991947dfc6815e", "parents": [ "c24757147fd88136f231d71f40a2cf02c51fdce7" ], "author": { "name": "Nicola Corti", "email": "ncor@meta.com", "time": "Fri Jun 23 02:51:41 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Fri Jun 23 02:51:41 2023 -0700" }, "message": "AGP to 8.0.2\n\nSummary:\nThis bumps AGP to the latest stable, allowing to bump CMake/NDK afterwards.\nI\u0027ve also bumped JDK version to 17 and set compile/target Java level to 8 so\nusers can keep on using this library.\n\nReviewed By: lblasa\n\nDifferential Revision: D46844315\n\nfbshipit-source-id: 38235c9950050cf36e6f2bbabc2853fe483a8086\n" }, { "commit": "c24757147fd88136f231d71f40a2cf02c51fdce7", "tree": "63cffd1accb97f778524309e54c289a7eb637ed2", "parents": [ "19041c0b15de46205f866381f0e7e26c7d38f3ef" ], "author": { "name": "Nicola Corti", "email": "ncor@meta.com", "time": "Fri Jun 23 02:51:41 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Fri Jun 23 02:51:41 2023 -0700" }, "message": "Cleanup and simplify publishing\n\nSummary:\nI\u0027m removing the custom -header.jar as now headers are distributed in the `.aar` with the prefab\nprotocol so users can get it from there automatically.\n\nI\u0027ve also bumped com.vanniktech.maven.publish to the latest stable as now it supportes the publishing\nDSL from AGP 7.x automatically so there is no need to specify anything extra.\n\nReviewed By: luluwu2032\n\nDifferential Revision: D46844317\n\nfbshipit-source-id: 912983d6ee82cc984442e3c1226228223c9d0a33\n" }, { "commit": "19041c0b15de46205f866381f0e7e26c7d38f3ef", "tree": "7d82dde50508bc9bf2adad5697d2fcb83066749f", "parents": [ "cf86584a44d1540783f14a0caa5b41c9ecefb5ad" ], "author": { "name": "Nicola Corti", "email": "ncor@meta.com", "time": "Fri Jun 23 02:51:41 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Fri Jun 23 02:51:41 2023 -0700" }, "message": "Use namespace and remove unnecessary manifest file\n\nSummary:\nSince AGP 7.3.x libraries are required to specify a namespace. The package inside the Manifest can be remove.\nAs the manifest file was empty, I\u0027ve removed it entirely.\n\nReviewed By: luluwu2032\n\nDifferential Revision: D46844318\n\nfbshipit-source-id: 326ed2359c20047f6b9b8321ac722d26d0d4fa1f\n" }, { "commit": "cf86584a44d1540783f14a0caa5b41c9ecefb5ad", "tree": "23582fb53aee6819691f90a583ab889f821975cd", "parents": [ "4407d37ebe49544f7e2244f13f6eb06a3d064c77" ], "author": { "name": "Nicola Corti", "email": "ncor@meta.com", "time": "Fri Jun 23 02:51:41 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Fri Jun 23 02:51:41 2023 -0700" }, "message": "Modernize the CI of fbjni\n\nSummary:\nI\u0027m doing a pass and modernizing GitHub Actions setup:\n- Update actions to use the latest versions (e.g. checkout v3)\n- Updated jobs to use gradle/gradle-build-action which adds proper caching\n\nReviewed By: luluwu2032\n\nDifferential Revision: D46844314\n\nfbshipit-source-id: f779bdc0e63eae29c88599359a0f342c0e21cbca\n" }, { "commit": "4407d37ebe49544f7e2244f13f6eb06a3d064c77", "tree": "9b63b7507fa7647e962896549caee90e66cffdaa", "parents": [ "94c44af451b63ff7b99774237e319942e5a04a98" ], "author": { "name": "Nicola Corti", "email": "ncor@meta.com", "time": "Fri Jun 23 02:51:41 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Fri Jun 23 02:51:41 2023 -0700" }, "message": "Bump AGP to 7.4.2\n\nSummary:\nThis is an intermediate step before the bump to AGP 8.x\nHere I bump the CI to use JDK 11, and bump Gradle to 8.1.1 as the version we were using was quite old.\n\nReviewed By: luluwu2032\n\nDifferential Revision: D46844313\n\nfbshipit-source-id: a46aadc0214fd423eec3c8db81a2639261ac28da\n" }, { "commit": "94c44af451b63ff7b99774237e319942e5a04a98", "tree": "84cb2b45bccd04640849914744923e98a8e452c4", "parents": [ "53ff02562e2406633bb0b0ebd8323f09c3bf258f" ], "author": { "name": "Nicola Corti", "email": "ncor@meta.com", "time": "Thu Jun 22 02:46:43 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Thu Jun 22 02:46:43 2023 -0700" }, "message": "Bump CMake to 3.18.1 (#83)\n\nSummary:\n## Motivation\n\nCI is currently red due to a wrong CMake version. I\u0027m bumping it to the next stable one included in the NDK\n\nPull Request resolved: https://github.com/facebookincubator/fbjni/pull/83\n\nTest Plan: Will wait for green CI signal\n\nReviewed By: javache\n\nDifferential Revision: D46930703\n\nPulled By: cortinico\n\nfbshipit-source-id: b3f8bb777e6cbcf5077d7864f35112a880da0f49\n" }, { "commit": "53ff02562e2406633bb0b0ebd8323f09c3bf258f", "tree": "ebcd3ecce459c70bd370202ae65a8c0cad10e869", "parents": [ "91f5b98a20f47f85660b1fbbaa0a3fe26b0ec600" ], "author": { "name": "Sim Sun", "email": "simsun@meta.com", "time": "Tue Jun 20 23:16:26 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Tue Jun 20 23:16:26 2023 -0700" }, "message": "reland: [fbjni] Keep all the HybridData\u0027s members\n\nSummary:\nreland D46769581.\nD46769581 added a new annotation(DoNotStripAny) in fbjni for keeping all the classes member, but it doesn\u0027t work for couple arvr apps, since it misses actual proguard rule like:\n\n```\nkeep,allowobfuscation interface com.facebook.jni.annotations.DoNotStripAny\n-keep com.facebook.jni.annotations.DoNotStripAny class * {\n *;\n}\n```\nFixing it by backporting the same proguard definition that we use for com.facebook.proguard annotaitons but to com.facebook.jni.annotations.\n\n----\n\nReviewed By: javache\n\nDifferential Revision: D46850839\n\nfbshipit-source-id: 44502659cb117604b8c74c418f2445c239733053\n" }, { "commit": "91f5b98a20f47f85660b1fbbaa0a3fe26b0ec600", "tree": "87ee179be3ecd7499ecddc747fd574fa62e1a6d3", "parents": [ "a4be46cea1e2946b441bc0ba2524abafe6e4ec19" ], "author": { "name": "Nicola Corti", "email": "ncor@meta.com", "time": "Tue Jun 20 09:04:42 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Tue Jun 20 09:04:42 2023 -0700" }, "message": "Bump version to 0.4.1-SNAPSHOT\n\nSummary: Just bumping the version to 0.4.1 so SNAPSHOT version can be published if needed\n\nReviewed By: passy\n\nDifferential Revision: D46859233\n\nfbshipit-source-id: d60d5e7040ec93cd8083df06e5fb11200b797693\n" }, { "commit": "a4be46cea1e2946b441bc0ba2524abafe6e4ec19", "tree": "f78d6e7b0f438f386941c3c1ff0b7561367517da", "parents": [ "d08a84eaad5bb2e0629b3f209d436f96982296d8" ], "author": { "name": "Sim Sun", "email": "simsun@fb.com", "time": "Tue Jun 20 00:08:43 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Tue Jun 20 00:08:43 2023 -0700" }, "message": "Revert D46769581: Keep all the HybridData\u0027s members\n\nDifferential Revision:\nD46769581\n\nOriginal commit changeset: 9ee17e490e65\n\nOriginal Phabricator Diff: D46769581\n\nfbshipit-source-id: dc05c4cfcb6e6fecf4726b6025e2a1eee4189c02\n" }, { "commit": "d08a84eaad5bb2e0629b3f209d436f96982296d8", "tree": "5e82d61dff1fb1e9f20d39e72b6a4ef422e5c6c8", "parents": [ "83cc597977e862e85e2df0cb097ee221afc859c2" ], "author": { "name": "Sim Sun", "email": "simsun@meta.com", "time": "Mon Jun 19 13:09:55 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Mon Jun 19 13:09:55 2023 -0700" }, "message": "Keep all the HybridData\u0027s members\n\nSummary: It\u0027s safer to keep all the members in the `HybridData` and `HybridData$Destructor` instead of annotating `DoNotStrip` on all the members.\n\nReviewed By: aandreyeu\n\nDifferential Revision: D46769581\n\nfbshipit-source-id: 9ee17e490e65316c6f8395758d85bc9a8c82f978\n" }, { "commit": "83cc597977e862e85e2df0cb097ee221afc859c2", "tree": "f78d6e7b0f438f386941c3c1ff0b7561367517da", "parents": [ "8efea4d089f3f88680c8937d5a7ea5b1ce2bef17" ], "author": { "name": "Nicola Corti", "email": "ncor@meta.com", "time": "Mon Jun 19 12:33:36 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Mon Jun 19 12:33:36 2023 -0700" }, "message": "Prepare FBJNI version 0.4.0 (#82)\n\nSummary:\nPull Request resolved: https://github.com/facebookincubator/fbjni/pull/82\n\nWe do have several changes on `main` which I\u0027d like to ship as they\u0027re needed\non React Native\u0027s end (mostly related to stacktrace \u0026 crash reporting on Android).\n\nReviewed By: javache\n\nDifferential Revision: D46843899\n\nfbshipit-source-id: bd8282cc8d29582c267ed767b5102f3ceea3836e\n" }, { "commit": "8efea4d089f3f88680c8937d5a7ea5b1ce2bef17", "tree": "ed6eda44b77c1b99d7c34bbde3afc54bdce087f6", "parents": [ "521c0d16ad053b3e074205a9155f6458750d83bd" ], "author": { "name": "Krystof Woldrich", "email": "krystof.woldrich@sentry.io", "time": "Tue Jun 13 10:32:44 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Tue Jun 13 10:32:44 2023 -0700" }, "message": "Add getMessage to JThrowable and getSimpleName to JClass (#78)\n\nSummary:\n## Motivation\n\nWhy are you making this change?\n\nTo enable RN to retrieve details about Throwables.\n\nRelates to https://github.com/facebook/react-native/pull/36925. Where these changes will be used.\n\nWhat did you change?\n\nAdded `getMessage` to JThrowable.\n\nAdded `getSimpleName` to JClass.\n\nHow does the code work?\n\nUses dynamic Java method call like other similar methods.\n\nPull Request resolved: https://github.com/facebookincubator/fbjni/pull/78\n\nTest Plan:\nHow did you test this change?\n\nCould anyone guide me on how to test my changes of `fbjni` in RN?\n\nI wanted to publish the package to my local Maven and add it to RN to verify the functionality, but it didn\u0027t work.\n\nWhat I tried:\n\n1. `./gradlew publishToMavenLocal` generated `0.3.1-SNAPSHOT`\n2. Add `mavenLocal()` to `packages/rn-tester/android/app/build.gradle`.\n3. yarn install-android-jsc\n\nI got this error:\n```\n[CXX1429] error when building with cmake using /Users/krystofwoldrich/random/react-native/packages/react-native/ReactAndroid/src/main/jni/CMakeLists.txt: C++ build system [prefab] failed while executing:\n \"/Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java\" \\\n --class-path \\\n /Users/krystofwoldrich/.gradle/caches/modules-2/files-2.1/com.google.prefab/cli/2.0.0/f2702b5ca13df54e3ca92f29d6b403fb6285d8df/cli-2.0.0-all.jar \\\n com.google.prefab.cli.AppKt \\\n --build-system \\\n cmake \\\n --platform \\\n android \\\n --abi \\\n arm64-v8a \\\n --os-version \\\n 21 \\\n --stl \\\n c++_shared \\\n --ndk-version \\\n 23 \\\n --output \\\n /var/folders/tl/jddrmdy97gj0cljrcwb_qkzc0000gn/T/agp-prefab-staging13347947173282983619/staged-cli-output \\\n /Users/krystofwoldrich/.gradle/caches/transforms-3/f866505a036566e921ad0564b1cacdd9/transformed/fbjni-0.3.1-SNAPSHOT/prefab \\\n /Users/krystofwoldrich/random/react-native/packages/react-native/ReactAndroid/build/intermediates/cxx/refs/packages/react-native/ReactAndroid/hermes-engine/572y156m\n from /Users/krystofwoldrich/random/react-native/packages/react-native/ReactAndroid\nException in thread \"main\" java.lang.IllegalArgumentException: version must be compatible with CMake, if present\n\tat com.google.prefab.api.Package.\u003cinit\u003e(Package.kt:58)\n\tat com.google.prefab.cli.Cli$packages$2.invoke(Cli.kt:124)\n\tat com.google.prefab.cli.Cli$packages$2.invoke(Cli.kt:123)\n\tat kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:74)\n\tat com.google.prefab.cli.Cli.getPackages(Cli.kt:123)\n\tat com.google.prefab.cli.Cli.validate(Cli.kt:172)\n\tat com.google.prefab.cli.Cli.run(Cli.kt:189)\n\tat com.github.ajalt.clikt.parsers.Parser.parse(Parser.kt:204)\n\tat com.github.ajalt.clikt.parsers.Parser.parse(Parser.kt:17)\n\tat com.github.ajalt.clikt.core.CliktCommand.parse(CliktCommand.kt:396)\n\tat com.github.ajalt.clikt.core.CliktCommand.parse$default(CliktCommand.kt:393)\n\tat com.github.ajalt.clikt.core.CliktCommand.main(CliktCommand.kt:411)\n\tat com.github.ajalt.clikt.core.CliktCommand.main(CliktCommand.kt:436)\n\tat com.google.prefab.cli.AppKt.main(App.kt:28)\n```\n\nAny change that adds functionality should add a unit test as well.\n\nReviewed By: cortinico, antonk52\n\nDifferential Revision: D45731659\n\nPulled By: lblasa\n\nfbshipit-source-id: cac0962a772bfc2fcc119bb03f176e68684e5c29\n" }, { "commit": "521c0d16ad053b3e074205a9155f6458750d83bd", "tree": "e338cb9c5e50915549287467ed0dd8ffd367171e", "parents": [ "423ecddfe14d167898138b3b13af867ff3cf1421" ], "author": { "name": "Benjamin Jaeger", "email": "bjaeger@meta.com", "time": "Wed May 24 04:50:30 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Wed May 24 04:50:30 2023 -0700" }, "message": "Remove global initializer in fbjni\n\nSummary: So that it doesn\u0027t run on startup\n\nReviewed By: nlutsenko\n\nDifferential Revision: D46109074\n\nfbshipit-source-id: 38837ce775186063c8781488d50f5301f307b702\n" }, { "commit": "423ecddfe14d167898138b3b13af867ff3cf1421", "tree": "64087f97cd125768bfbb6775237488106a90ae32", "parents": [ "568b0129b0a49b0b68392f95f4a8c6f6bf3d9bfa" ], "author": { "name": "Nikita Lutsenko", "email": "nlutsenko@meta.com", "time": "Tue May 23 17:54:49 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Tue May 23 17:54:49 2023 -0700" }, "message": "fbjni | Remove usage of global constructors in Exceptions/Lyra.\n\nSummary: Removing a complete usage in one of these cases, and converting to a local static in another.\n\nReviewed By: smeenai\n\nDifferential Revision: D46129471\n\nfbshipit-source-id: 8eebf71444a5c8a42eca07e9e46cd1f241428683\n" }, { "commit": "568b0129b0a49b0b68392f95f4a8c6f6bf3d9bfa", "tree": "db6d8c2a2bb48c8a1305b88219cc1a2b1fba572a", "parents": [ "303646316929436ad2720f4877ac3c177dd1b034" ], "author": { "name": "Joshua Selbo", "email": "jselbo@meta.com", "time": "Tue Mar 28 21:56:35 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Tue Mar 28 21:56:35 2023 -0700" }, "message": "Fix CI\n\nReviewed By: jiawei-lyu\n\nDifferential Revision: D44491212\n\nfbshipit-source-id: be935b09d77e77fd7640a3c28feea48b0c5584ca\n" }, { "commit": "303646316929436ad2720f4877ac3c177dd1b034", "tree": "3a45cea078a9f7fad517a74bb5c9fd1d24989877", "parents": [ "11791b4cf69e9ac9722cc367ea029bff359da3ae" ], "author": { "name": "Joshua Selbo", "email": "jselbo@meta.com", "time": "Tue Mar 28 15:43:03 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Tue Mar 28 15:43:03 2023 -0700" }, "message": "Remove remaining usages of fest\n\nSummary: fest is deprecated in favor of AssertJ. This removes the last remaining usages.\n\nReviewed By: jiawei-lyu\n\nDifferential Revision: D44469926\n\nfbshipit-source-id: f2ea60348511942a396c7aa7a23c8b2fc1d5289c\n" }, { "commit": "11791b4cf69e9ac9722cc367ea029bff359da3ae", "tree": "3ec975746f77ac3fe6a29da07d74833c3b1b5459", "parents": [ "378aeb44014f1ef4e98a0adf75b6438ebf713d98" ], "author": { "name": "Nikita Lutsenko", "email": "nlutsenko@meta.com", "time": "Thu Mar 16 10:47:07 2023 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Thu Mar 16 10:47:07 2023 -0700" }, "message": "fbjni | Add \u0027getPackageName\u0027 to AContext.\n\nSummary: Generally really useful - add it.\n\nDifferential Revision: D44126124\n\nfbshipit-source-id: d15135c0eebe2a4e2b788fb7abdc0bd94777480d\n" }, { "commit": "378aeb44014f1ef4e98a0adf75b6438ebf713d98", "tree": "2dbd0da62a97c077b86820a2414e93b5dc2c8224", "parents": [ "5eacdd11c5d9c46f5a752faad3457f3b07fe40cb" ], "author": { "name": "Sim Sun", "email": "simsun@meta.com", "time": "Sun Feb 26 10:54:22 2023 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Sun Feb 26 10:54:22 2023 -0800" }, "message": "Bump SoLoader version to 0.10.5 (#119)\n\nSummary:\nX-link: https://github.com/facebookincubator/profilo/pull/119\n\nPull Request resolved: https://github.com/facebookincubator/fbjni/pull/77\n\nUse system linker by default on Android N and above devices.\n\nReviewed By: lblasa\n\nDifferential Revision: D43575298\n\nfbshipit-source-id: 3f065f27644f92aa64df78b403d966ac0b298d7b\n" }, { "commit": "5eacdd11c5d9c46f5a752faad3457f3b07fe40cb", "tree": "0cdd868cdc10a4059372d8d3277ddac448988beb", "parents": [ "6015a2f3c42e3497f1d2a62e12f55d775b896db8" ], "author": { "name": "Thiago Goulart", "email": "thiagog@meta.com", "time": "Wed Nov 09 18:09:33 2022 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Wed Nov 09 18:09:33 2022 -0800" }, "message": "Fixes for -Wextra-semi,-Wextra-semi-stmt\n\nSummary: The flags are being introduced to higher level modules that depend on these headers. Although I admit these specific flags are more aesthetic than functional, I still would like to keep them around, and it\u0027s also normal for lower level libraries to be subject to a higher bar in terms of quality and readability.\n\nReviewed By: mhorowitz\n\nDifferential Revision: D41164579\n\nfbshipit-source-id: 03e8a4c23c5ba83e791b0b442bc63c9d88cc6c98\n" }, { "commit": "6015a2f3c42e3497f1d2a62e12f55d775b896db8", "tree": "b328f00a874c30de2070499a8abbea2a646cdbef", "parents": [ "428f535599b6b31fdf1c4a127128dcc64d712818" ], "author": { "name": "Anh Bui", "email": "abui@fb.com", "time": "Thu Aug 25 01:00:44 2022 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Thu Aug 25 01:00:44 2022 -0700" }, "message": "fix release build again\n\nSummary:\n- it seems like something change in the compiler or redex or sth, but between when I land D38945343 and today, the toolchain somehow no longer respects keeping class names for HybridData$Destructor like before\n- I tried adding DoNotStrip to Destructor and bizarrely it was working for a few hours until I tried again and it does not.\n - I then replace `Class.forName(\"com.facebook.jni.ThreadScopeSupport\")` with `SoLoader.loadLibrary(\"fbjni\")` and it works\n - on a hunch, I decided to throwaway my last ondemand and reserved a new one to test again, voila it crashed **again**! This tells me that redex seems to have some stateful logic if you run it enough times on the same machine ...\n - I added a few more fixes: using `fb_android_library` and adding `fbjni.pro` to the lib with HybridData\n- I\u0027m also working on adding release variant test to prevent instacrash like this T130146010\n## Update: differences beween `configured_alias` and the actual rule\non a previous commit,\n\n* **This android_binary_for_automation target crashes**\n```\nbuck install -r //fbandroid/apps/hypernova/apps/capture_and_share:automation_capture_and_share_android_x86_64_x86_64_release_redex @//fbandroid/mode/opt @//xplat/mode/hypernova/sandcastle/android\n```\n\n* `configured_alias` target does not\n```\nbuck install -r //fbandroid/apps/hypernova/apps/capture_and_share:capture_and_share_android_x86_64_release @//fbandroid/mode/opt @//xplat/mode/hypernova/sandcastle/android\n```\n* note that in CI, even if we provide the `configured_alias` CI will still build the android_binary_for_automation target, i.e. I download a build from https://www.internalfb.com/intern/sandcastle/job/18014399268658083/actions and could reproduce the crash\n\nReviewed By: simpleton\n\nDifferential Revision: D38996661\n\nfbshipit-source-id: 60db75ca31be6f29c6968565d417d1f07ce2c356\n" }, { "commit": "428f535599b6b31fdf1c4a127128dcc64d712818", "tree": "a014b43d8996e33b16ab3a51c26d5c50ad143a31", "parents": [ "40bdad2e03046c681abb5ea82a7ab8a2e5cf4e31" ], "author": { "name": "Nadia Yakimakha", "email": "nya@fb.com", "time": "Wed Aug 17 20:09:30 2022 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Wed Aug 17 20:09:30 2022 -0700" }, "message": "Do explicit cast from size_t to jsize.\n\nSummary:\nImplicit cast causes build error on M1 laptop:\n```\nerror: implicit conversion loses integer precision: \u0027size_t\u0027 (aka \u0027unsigned long\u0027) to \u0027jsize\u0027 (aka \u0027int\u0027) [-Werror,-Wshorten-64-to-32]\n auto rawElement \u003d env-\u003eGetObjectArrayElement(this-\u003eself(), idx);\n```\n\nReviewed By: mhorowitz\n\nDifferential Revision: D38791257\n\nfbshipit-source-id: a17df571cbe0486ca336f29174f8c19e70831386\n" }, { "commit": "40bdad2e03046c681abb5ea82a7ab8a2e5cf4e31", "tree": "ae7a226ec9c929b15f97388102f0ebbb354a03b4", "parents": [ "d4c43e3dd8ff4bee072bc4a4887d3aa53197fe58" ], "author": { "name": "Sim Sun", "email": "simsun@fb.com", "time": "Thu Jul 21 17:13:08 2022 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Thu Jul 21 17:13:08 2022 -0700" }, "message": "Bump SoLoader version to 0.10.4\n\nDifferential Revision: D38057928\n\nfbshipit-source-id: d44f7ac1f080a7acb248a5df2a0cd10260c02bda\n" }, { "commit": "d4c43e3dd8ff4bee072bc4a4887d3aa53197fe58", "tree": "3be4368f58b559ac596ab6786dd2f709e3a7fab6", "parents": [ "0068c0353d81ae52f527c5e6aa640b775a31a286" ], "author": { "name": "Nikita Lutsenko", "email": "nlutsenko@fb.com", "time": "Tue Jul 19 15:23:15 2022 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Tue Jul 19 15:23:15 2022 -0700" }, "message": "fbjni | Fix includes when using FBJNI_DEBUG_LOG_REFS.\n\nSummary: If the FBJNI_DEBUG_LOG_REFS - we are going to require usage of __android_log_print, but are missing include for it - add it.\n\nReviewed By: boguscoder\n\nDifferential Revision: D37971279\n\nfbshipit-source-id: af8964460643e3da7e6f6166cee2f323524223d0\n" }, { "commit": "0068c0353d81ae52f527c5e6aa640b775a31a286", "tree": "a5c5ac5f39173f6004565398d085cd5778b951e7", "parents": [ "f3797504785516524baf2c063007f28c0fdd0742" ], "author": { "name": "Shoaib Meenai", "email": "smeenai@fb.com", "time": "Thu Jun 16 01:12:27 2022 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Thu Jun 16 01:12:27 2022 -0700" }, "message": "Back out \"Temporarily disable stack traces for libc++ arm64\"\n\nSummary:\nAs with all temporary solutions, this turned out to be a lot less\ntemporary than I was hoping for :D I was never able to figure out the\noriginal issue, but I tried again after switching unwinders from libgcc\nto libunwind. Unfortunately that ran into new crashes so I had to revert\nit again. I fixed the underlying issue in LLVM\u0027s libunwind in\nhttps://reviews.llvm.org/D126343, so let\u0027s try this again and see what\nhappens.\n\nReviewed By: simpleton\n\nDifferential Revision: D37181295\n\nfbshipit-source-id: bb4ca5c8e525e8deab3fa43b8be78120b477ffed\n" }, { "commit": "f3797504785516524baf2c063007f28c0fdd0742", "tree": "ddbd18b5ea827ae19ff0ff003f21abe486c3e0db", "parents": [ "250d88925081930627eb9fb6d2ab9ebea47e185c" ], "author": { "name": "Shoaib Meenai", "email": "smeenai@fb.com", "time": "Thu Apr 07 11:55:44 2022 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Thu Apr 07 11:55:44 2022 -0700" }, "message": "Restore \"[lyra] Temporarily disable stack traces for libc++ arm64\"\n\nSummary:\nThis is still causing crashes, and I have no idea why :(\n\nOriginal commit changeset: 8959891f1a8a\n\nOriginal Phabricator Diff: D35133990 (https://github.com/facebookincubator/fbjni/commit/de205a30baee612d1f7bbe4885c91a18ac1e5baf)\n\nReviewed By: lanza\n\nDifferential Revision: D35473041\n\nfbshipit-source-id: 81ac2c3083a102fa4b0116602d9c215db8d20dec\n" }, { "commit": "250d88925081930627eb9fb6d2ab9ebea47e185c", "tree": "a5c5ac5f39173f6004565398d085cd5778b951e7", "parents": [ "de205a30baee612d1f7bbe4885c91a18ac1e5baf" ], "author": { "name": "Hannes Friederich", "email": "hfriederich@fb.com", "time": "Tue Apr 05 12:12:56 2022 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Tue Apr 05 12:12:56 2022 -0700" }, "message": "fixes to support -Wstring-conversion compiler warning\n\nSummary: We\u0027re in the process of enable `-Wstring-conversion` in the default arvr build modes. The reason is that it flags legitimate bugs such as D35316465.\n\nReviewed By: mhorowitz\n\nDifferential Revision: D35389996\n\nfbshipit-source-id: 20fdb00f0b630a723d5a253fd80257edfa87bafb\n" }, { "commit": "de205a30baee612d1f7bbe4885c91a18ac1e5baf", "tree": "416aa66ba6130f2741f480a87d5a2b89f89c0186", "parents": [ "2554f9b5ee2e473a0d35b8f6f312267c00e443ed" ], "author": { "name": "Shoaib Meenai", "email": "smeenai@fb.com", "time": "Fri Mar 25 12:37:13 2022 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Fri Mar 25 12:37:13 2022 -0700" }, "message": "Back out \"Temporarily disable stack traces for libc++ arm64\"\n\nSummary:\nAs with all temporary solutions, this turned out to be a lot less\ntemporary than I was hoping for :D I was never able to figure out the\noriginal issue, but we\u0027ve since changed unwinders from libgcc to LLVM\u0027s\nlibunwind, and hopefully that fixes this issue as well.\n\nOriginal commit changeset: 088c8a781d00\n\nOriginal Phabricator Diff: D19718354 (https://github.com/facebookincubator/fbjni/commit/501e6dfd35a39fb51cef2c3e3cd8d902e45eb56e)\n\nReviewed By: lanza\n\nDifferential Revision: D35133990\n\nfbshipit-source-id: 8959891f1a8a7687be5786cb5c00c257cefdef36\n" }, { "commit": "2554f9b5ee2e473a0d35b8f6f312267c00e443ed", "tree": "8fc5b9bd1008b01afa3482b285ee9a6e71201806", "parents": [ "0464ece9f1cb94ef2a8c9f605a25ad8ba2478e9e" ], "author": { "name": "Pieter De Baets", "email": "pieterdb@fb.com", "time": "Fri Feb 25 09:41:19 2022 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Fri Feb 25 09:41:19 2022 -0800" }, "message": "Implement ReadableNative*::mapException without dynamic_cast\n\nSummary:\nChanging fbjni\u0027s mapException interface to use `std::exception_ptr`, this enables us to use `std::rethrow_exception` and `catch` statements to check for specific exception types, rather than using dynamic_casts and having an explicit dependency on RTTI.\n\nWhile generally, we should always be enabling RTTI and exception support simultaneously, we have a number of targets where we don\u0027t, or where avoiding RTTI provides significant binary size gains.\n\nChangelog: [Internal]\n\nReviewed By: mhorowitz\n\nDifferential Revision: D34379950\n\nfbshipit-source-id: 446d105f9fb50ada3526f242f98e163215abd0ab\n" }, { "commit": "0464ece9f1cb94ef2a8c9f605a25ad8ba2478e9e", "tree": "3af3380a8f88c80cade19cc20928c5073b9d8299", "parents": [ "6420543dab1a4de27f83633f94dedf00c23a3499" ], "author": { "name": "Pascal Hartig", "email": "phartig@rdrei.net", "time": "Wed Nov 24 06:25:53 2021 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Wed Nov 24 06:28:20 2021 -0800" }, "message": "v0.3.1-SNAPSHOT (#75)\n\nSummary:\nBack to snapshot releases.\n\nPull Request resolved: https://github.com/facebookincubator/fbjni/pull/75\n\nReviewed By: nikoant\n\nDifferential Revision: D32620390\n\nPulled By: passy\n\nfbshipit-source-id: 43ca95788e6a2ed86b5dc32b88af6943aad78e27\n" }, { "commit": "6420543dab1a4de27f83633f94dedf00c23a3499", "tree": "ee9dac7e1040fa85d39634fdfca992c2a548b847", "parents": [ "34535fc9e2ee8c81c75d2d9fb8ba358513c65d72" ], "author": { "name": "Pascal Hartig", "email": "phartig@rdrei.net", "time": "Mon Nov 22 11:50:48 2021 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Mon Nov 22 11:51:34 2021 -0800" }, "message": "Use new publish action (#74)\n\nSummary:\nSee https://github.com/vanniktech/gradle-maven-publish-plugin/blob/master/CHANGELOG.md#version-0170-2021-07-04\n\nPull Request resolved: https://github.com/facebookincubator/fbjni/pull/74\n\nTest Plan: testinprod\n\nReviewed By: lblasa\n\nDifferential Revision: D32598321\n\nPulled By: passy\n\nfbshipit-source-id: f8b3e4113a56703141f3ded4e4b1775591014269\n" }, { "commit": "34535fc9e2ee8c81c75d2d9fb8ba358513c65d72", "tree": "1c5841733ab157e9a212e3647ac785509b60588c", "parents": [ "ebe4309a4cdb38241b17ac58db85d524c6f1e326" ], "author": { "name": "Pascal Hartig", "email": "phartig@rdrei.net", "time": "Mon Nov 22 09:16:05 2021 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Mon Nov 22 09:16:49 2021 -0800" }, "message": "Use new credentials format (#73)\n\nSummary:\nThis matches what we have over at Flipper:\n\nhttps://github.com/facebook/flipper/blob/main/.github/workflows/publish-android.yml#L28\n\nPull Request resolved: https://github.com/facebookincubator/fbjni/pull/73\n\nTest Plan: Next release\n\nReviewed By: lblasa\n\nDifferential Revision: D32596178\n\nPulled By: passy\n\nfbshipit-source-id: c2465534b3a79f8add5f835ada22f7662a05448c\n" }, { "commit": "ebe4309a4cdb38241b17ac58db85d524c6f1e326", "tree": "84f6364a37d8903bff387fc9cfd9f8612a1d8f61", "parents": [ "8aa8ffa49ef950e56d986c82d98cd0573bff5b93" ], "author": { "name": "Pascal Hartig", "email": "realpassy@fb.com", "time": "Mon Nov 22 08:42:39 2021 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Mon Nov 22 08:43:31 2021 -0800" }, "message": "Revert D32593957: v0.3.1-SNAPSHOT\n\nDifferential Revision:\nD32593957 (https://github.com/facebookincubator/fbjni/commit/8aa8ffa49ef950e56d986c82d98cd0573bff5b93)\n\nOriginal commit changeset: 9b710be3fa20\n\nfbshipit-source-id: bcb66bfe4ac0867df5a798448acf7dd279d88daa\n" }, { "commit": "8aa8ffa49ef950e56d986c82d98cd0573bff5b93", "tree": "67d6a8650414e940ba7b725dc4362710f6a57a61", "parents": [ "0c14863b05a4668b68a5977e5249b35cde55c687" ], "author": { "name": "Pascal Hartig", "email": "realpassy@fb.com", "time": "Mon Nov 22 06:52:01 2021 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Mon Nov 22 06:52:55 2021 -0800" }, "message": "v0.3.1-SNAPSHOT\n\nSummary: Back to snapshot releases.\n\nReviewed By: lblasa\n\nDifferential Revision: D32593957\n\nfbshipit-source-id: 9b710be3fa202f079930ca57b9a99b704a833211\n" }, { "commit": "0c14863b05a4668b68a5977e5249b35cde55c687", "tree": "84f6364a37d8903bff387fc9cfd9f8612a1d8f61", "parents": [ "af4c8e61660905cb7fd3869bb74cbf12472781f7" ], "author": { "name": "Pascal Hartig", "email": "realpassy@fb.com", "time": "Mon Nov 22 06:52:01 2021 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Mon Nov 22 06:52:55 2021 -0800" }, "message": "v0.3.0\n\nSummary: New release building against the latest NDK.\n\nReviewed By: lblasa\n\nDifferential Revision: D32593958\n\nfbshipit-source-id: 01d13c753b0682678083bc3ba868529c22793ad2\n" }, { "commit": "af4c8e61660905cb7fd3869bb74cbf12472781f7", "tree": "7a39b5c1734e923edcbcd9b4408e9de91726385a", "parents": [ "befc998237a995fd706601e5ec1c95c61f2d73b6" ], "author": { "name": "Pascal Hartig", "email": "phartig@rdrei.net", "time": "Mon Nov 22 06:33:06 2021 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Mon Nov 22 06:34:01 2021 -0800" }, "message": "Bump ndk (#72)\n\nSummary:\nBump to the latest NDK.\n\nPull Request resolved: https://github.com/facebookincubator/fbjni/pull/72\n\nTest Plan: ./gradlew assembleDebug\n\nReviewed By: lblasa\n\nDifferential Revision: D32593098\n\nPulled By: passy\n\nfbshipit-source-id: e5a35070e7b85e4926157d6bf07496cadd01606c\n" }, { "commit": "befc998237a995fd706601e5ec1c95c61f2d73b6", "tree": "72dec78922051e61d8e74431a9bde9fc02634b76", "parents": [ "aacc5d851d4acd00b13abdf930174c7e5660ca55" ], "author": { "name": "Pascal Hartig", "email": "phartig@rdrei.net", "time": "Mon Nov 22 05:11:35 2021 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Mon Nov 22 05:12:58 2021 -0800" }, "message": "Remove sdkmanager (#71)\n\nSummary:\nThis isn\u0027t necessary with the GitHub base image and just one more thing we need to keep from breaking.\n\nPull Request resolved: https://github.com/facebookincubator/fbjni/pull/71\n\nTest Plan: Green CI\n\nReviewed By: lblasa\n\nDifferential Revision: D32592577\n\nPulled By: passy\n\nfbshipit-source-id: e4026af76ff35337ef53061b762e9ff2f7bb68cf\n" }, { "commit": "aacc5d851d4acd00b13abdf930174c7e5660ca55", "tree": "a248d80c783712e26a0a5f8e6c39884d08611e40", "parents": [ "dc673a2fe481a5f2f30215ba6559683576d72f4d" ], "author": { "name": "Pascal Hartig", "email": "phartig@rdrei.net", "time": "Mon Nov 22 04:28:51 2021 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Mon Nov 22 04:29:38 2021 -0800" }, "message": "Upgrade deps (#70)\n\nSummary:\nWe want to upgrade the NDK, but first we need to fix a bunch of other stuff to make that work.\n\n- Upgrade the Gradle plugin. That should just work.\n- Upgrade the release plugin. We need to change `LICENSE` to `LICENCE` for that. Sigh.\n- Fix GoogleTest which now also lives on a `main` branch.\n- Remove JCenter dependencies.\n\nPull Request resolved: https://github.com/facebookincubator/fbjni/pull/70\n\nTest Plan:\n- ./gradlew assembleDebug\n- ./scripts/scripts/run-host-tests.sh\n- CI\n\nReviewed By: lblasa\n\nDifferential Revision: D32592380\n\nPulled By: passy\n\nfbshipit-source-id: ad1dcc2a16a1028b97934c800b690a50087c6454\n" }, { "commit": "dc673a2fe481a5f2f30215ba6559683576d72f4d", "tree": "02c736d6afb1a0057da300ab252f5df35820d54b", "parents": [ "11ea7b1f60e2ed6b3a435dd0aaaf99c739c9e49c" ], "author": { "name": "Wesley Elias Ribeiro", "email": "wesleyer@fb.com", "time": "Sat Nov 20 13:47:34 2021 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Sat Nov 20 13:50:34 2021 -0800" }, "message": "Create a new method to return the cached environment and whether we are in the middle of attaching\n\nReviewed By: simpleton\n\nDifferential Revision: D32573083\n\nfbshipit-source-id: 4c307fcef3bac62396d7c3e409d445980bf9cd71\n" }, { "commit": "11ea7b1f60e2ed6b3a435dd0aaaf99c739c9e49c", "tree": "285c1700f1475f35fc7a84492e441047793025aa", "parents": [ "8cd8713ad4c9777ad272d7605e5ced1356f9f586" ], "author": { "name": "Wesley Elias Ribeiro", "email": "wesleyer@fb.com", "time": "Sat Nov 20 13:47:34 2021 -0800" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Sat Nov 20 13:50:33 2021 -0800" }, "message": "Make sure TLS data is initialized before calling attachCurrentThread()\n\nSummary: Initialize TLS data structure as soon as it is set.\n\nReviewed By: simpleton\n\nDifferential Revision: D32569250\n\nfbshipit-source-id: 9278b011a50acd2cf995977f8e62cb0c7bfcb36f\n" }, { "commit": "8cd8713ad4c9777ad272d7605e5ced1356f9f586", "tree": "29ae8aac3e2a406f15fb9b01cbc477224a8b53e6", "parents": [ "8b5aa9eb323184b27b87b5955b242e6e5a342c1a" ], "author": { "name": "Pascal Hartig", "email": "phartig@rdrei.net", "time": "Fri Aug 13 04:58:41 2021 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Fri Aug 13 05:00:02 2021 -0700" }, "message": "Default branch renames (#66)\n\nSummary: Pull Request resolved: https://github.com/facebookincubator/fbjni/pull/66\n\nReviewed By: timur-valiev\n\nDifferential Revision: D30302026\n\nPulled By: passy\n\nfbshipit-source-id: fe892b558ac498977fab785175ec260f8dbdc8ba\n" }, { "commit": "8b5aa9eb323184b27b87b5955b242e6e5a342c1a", "tree": "371c87ae687f05ad0dc154a907e1a5f403dfbc0f", "parents": [ "bb2910d72b030cb931fb2a7e0e8e174f149208ea" ], "author": { "name": "Nathan Lanza", "email": "lanza@fb.com", "time": "Fri Jul 30 17:28:39 2021 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Fri Jul 30 17:29:10 2021 -0700" }, "message": "Add a default copy assignment operator since there\u0027s a default copy constructor\n\nSummary:\nClang has deprecated implicitly defining a copy assignment operator given a manually\ndefined copy constructor. So here we have to also define a default copy assignment\noperator.\n\nReviewed By: smeenai\n\nDifferential Revision: D30000986\n\nfbshipit-source-id: 324a58d13d7d0a04b8d996e163393b710e2be326\n" }, { "commit": "bb2910d72b030cb931fb2a7e0e8e174f149208ea", "tree": "721c9813bc3720b688975e060e057c4ab6fe7ea1", "parents": [ "fc4d1275c0c5c43691e8ab1912a443cfd8db83f5" ], "author": { "name": "Nathan Lanza", "email": "lanza@fb.com", "time": "Fri Jul 30 17:25:46 2021 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Fri Jul 30 17:26:53 2021 -0700" }, "message": "Add a default copy constructor for JMethod\n\nSummary:\nSince the copy assignment operator was defaulted the compiler will\nrefuse to subsequently generate the copy assignment operator in llvm-13. So just\ntell it to do what it used to do.\n\nReviewed By: mhorowitz\n\nDifferential Revision: D30026103\n\nfbshipit-source-id: abc8877218277e5056148c5b8a784072a7a1f701\n" }, { "commit": "fc4d1275c0c5c43691e8ab1912a443cfd8db83f5", "tree": "c87be0251d7411257c1f841d26544e79eac533c2", "parents": [ "a98ec18408fcfc7c5898a5e6b5007b44c1940e87" ], "author": { "name": "Raghav Rao", "email": "rrao@fb.com", "time": "Thu Jul 01 15:18:39 2021 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Thu Jul 01 15:19:34 2021 -0700" }, "message": "Revert D29433693: Fix JNI leaks\n\nDifferential Revision:\nD29433693 (https://github.com/facebookincubator/fbjni/commit/a98ec18408fcfc7c5898a5e6b5007b44c1940e87)\n\nOriginal commit changeset: cfabc9c6bc0e\n\nfbshipit-source-id: 5cc3ef4e55b112660d944cdad5f8492199314ded\n" }, { "commit": "a98ec18408fcfc7c5898a5e6b5007b44c1940e87", "tree": "63b23e374ff99972494df4b81f40694e8faa3e37", "parents": [ "089df7f3e03d246599e33fb93f4e1ae7b3114ec3" ], "author": { "name": "Raghav Rao", "email": "rrao@fb.com", "time": "Wed Jun 30 00:51:07 2021 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Wed Jun 30 00:51:56 2021 -0700" }, "message": "Fix JNI leaks\n\nSummary:\nOacr(assistant platform) creates native threads on every start and these thread make calls to glog ex. https://fburl.com/diffusion/pzx0nsai\nHere is full backtrace P426317875\nGlog internally would internally call AndroidLogSink::send which does the attach but there is no detach.\nThese threads are not aware that the attach happened. This diffs add an attach/detach in scope so that there is no memory leak.\n\nWe are seeing thousands of virtual memory leaks for Portal voice app https://fburl.com/everpaste/1bp5hwsj\nThis exception P426037302 is present in logview for portal voice assistant app and other apps like alohausers and is happening here in the code where mmap is failing https://fburl.com/diffusion/h1kqd68k. Error \u003d 12 is \u0027no memory\u0027 and in this context it virtual memory.\n\nWhen we checked the memory map(pmap) we found thousands of IndirectReference mapping and growing steadily and ultimately it leads to virtual memory exhaustion.\n\n0000000053f48000 16K rw--- [anon:dalvik-indirect ref table]\n0000000053f54000 8K rw--- [anon:dalvik-indirect ref table]\n0000000053f6b000 24K rw--- [anon:dalvik-indirect ref table]\n0000000054040000 16K rw--- [anon:dalvik-indirect ref table]\n00000000540d2000 8K rw--- [anon:dalvik-indirect ref table]\n\nallocated from here https://fburl.com/diffusion/ru1gd35e\n\n**logview**\n\n{F628796337}\n\nReviewed By: JunqiWang\n\nDifferential Revision: D29433693\n\nfbshipit-source-id: cfabc9c6bc0e44d1032ee5eba1e32d43c815bae8\n" }, { "commit": "089df7f3e03d246599e33fb93f4e1ae7b3114ec3", "tree": "c87be0251d7411257c1f841d26544e79eac533c2", "parents": [ "f730250ff16424ae7d85550a7aea62a10c7a0a36" ], "author": { "name": "David Reiss", "email": "dreiss@fb.com", "time": "Fri Jun 25 09:52:53 2021 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Fri Jun 25 09:53:53 2021 -0700" }, "message": "Add JHashMap::create(int)\n\nSummary:\nThere are two uses of this in our codebase, in separate\nJHashMap implementations. Adding it here allows consolidation.\n\nReviewed By: mhorowitz\n\nDifferential Revision: D29280593\n\nfbshipit-source-id: fa33f3751f97a0909b7246cd4e4da7cca21dda5c\n" }, { "commit": "f730250ff16424ae7d85550a7aea62a10c7a0a36", "tree": "4d4a93420561a264658d0eac616f0b25ed50abbb", "parents": [ "d31edcb5e97241f00195c43947b6aead0fefb4a1" ], "author": { "name": "David Reiss", "email": "dreiss@fb.com", "time": "Fri Jun 18 12:38:11 2021 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Fri Jun 18 12:39:37 2021 -0700" }, "message": "Add simple bindings for container construction\n\nSummary:\nBind Container.add and Map.put, plus add ArrayList and HashMap\nwith just constructors.\n\nCopy/pasted versions of these show up in various places in the FB codebase.\nConsolidate them since people seem to find them useful.\n\nAdd to doc tests.\n\nI made Map.put return local_ref\u003cJObject\u003e like the underlying Java method,\neven though most internal copies return void. I think this is free or\nnearly so since we already need to construct a local_ref for the return\nvalue of putMethod, and this should return by NRVO. The Java equivalent\ndoes a checked cast to V, but I think it\u0027s smart enough to only do so\nif you\u0027re actually capturing the return value. We\u0027re not able to match\nthat behavior, so just do the cheap thing and the user can dynamic_ref_cast\nif they want. Or static_ref_cast if they\u0027re feeling lucky.\n\nReviewed By: mhorowitz\n\nDifferential Revision: D28499872\n\nfbshipit-source-id: 5fca2d5e1fed79775dc43abb6c71495ba99eff0d\n" }, { "commit": "d31edcb5e97241f00195c43947b6aead0fefb4a1", "tree": "025c48467877647d7b12957216483abab3ab74be", "parents": [ "a031656b52b1a2221339dcf68d3ca056ca59d62b" ], "author": { "name": "David Reiss", "email": "dreiss@fb.com", "time": "Fri Jun 18 12:38:11 2021 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Fri Jun 18 12:39:37 2021 -0700" }, "message": "Reorder DocTests.java\n\nSummary: Make the source ordering more closely match the rendered ordering.\n\nReviewed By: mhorowitz\n\nDifferential Revision: D28499873\n\nfbshipit-source-id: 85d1f2af083af18e2874983c646b732707e0974c\n" }, { "commit": "a031656b52b1a2221339dcf68d3ca056ca59d62b", "tree": "1697a784b73297fc6c23da722fab36f08bae4de7", "parents": [ "7e1e1fe3858c63c251c637ae41a20de425dde96f" ], "author": { "name": "Pascal Hartig", "email": "realpassy@fb.com", "time": "Wed Mar 24 11:32:49 2021 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Wed Mar 24 11:34:04 2021 -0700" }, "message": "v0.2.3-SNAPSHOT\n\nSummary: Back to snapshots.\n\nReviewed By: fabiomassimo\n\nDifferential Revision: D27291198\n\nfbshipit-source-id: 32992bbb6ec3878aeabfca610f7e4741598e4f1f\n" }, { "commit": "7e1e1fe3858c63c251c637ae41a20de425dde96f", "tree": "395ffc4053c8cedaaca92effa5d23c14be40b8d7", "parents": [ "e7a5554a72d9d606591dd44261a916ffd347f2e3" ], "author": { "name": "Pascal Hartig", "email": "realpassy@fb.com", "time": "Wed Mar 24 11:32:49 2021 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Wed Mar 24 11:34:03 2021 -0700" }, "message": "v0.2.2\n\nSummary: Need another release to test the release pipeline.\n\nReviewed By: fabiomassimo\n\nDifferential Revision: D27291197\n\nfbshipit-source-id: 4cfbd9f4cb371cb570b465c857dddf79c0cb1515\n" }, { "commit": "e7a5554a72d9d606591dd44261a916ffd347f2e3", "tree": "5271f1bccf1743c38fceffe31f41d9cf8027148b", "parents": [ "f107a1f8c61d50a763beeaebb0500f6f591f5fb5" ], "author": { "name": "Pascal Hartig", "email": "phartig@rdrei.net", "time": "Wed Mar 24 10:37:06 2021 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Wed Mar 24 10:37:52 2021 -0700" }, "message": "Don\u0027t create separate distribution for headers (#55)\n\nSummary:\ndogscience\n\nI\u0027m just throwing code against the (gradle) wall and see what sticks.\nThe problem with the previous setup was that it created two\npublications. While the outcome looked fine in general, it created\ntwo POM files which overwrote each other and the latter one created\nwould not have all the meta data, causing Maven Central validation\nto fail.\n\nWith this we\u0027re modifying the existing one(s) to add the headers JAR\ninstead.\n\nPull Request resolved: https://github.com/facebookincubator/fbjni/pull/55\n\nTest Plan:\n./gradlew installArchives\n\nChecked my ~/.m2/ and now there\u0027s only one distribution, i.e. not\nmultiple installations and, importantly, only one POM file.\n\nReviewed By: IvanKobzarev\n\nDifferential Revision: D27290376\n\nPulled By: passy\n\nfbshipit-source-id: d3e0a713ccec381f518867594607554d35f0b88e\n" }, { "commit": "f107a1f8c61d50a763beeaebb0500f6f591f5fb5", "tree": "f8b958fcc0e6385137d2f1e1ebb833ed7bbee60c", "parents": [ "7af8406201bb9e413166e7ce9a54d6aa70205243" ], "author": { "name": "Pascal Hartig", "email": "realpassy@fb.com", "time": "Tue Mar 23 11:36:59 2021 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Tue Mar 23 11:38:52 2021 -0700" }, "message": "v0.2.2-SNAPSHOT\n\nSummary: Back to snapshot releases.\n\nReviewed By: muraziz\n\nDifferential Revision: D27267310\n\nfbshipit-source-id: fb164933d8418400c13ba223d79b17243fd2e12c\n" }, { "commit": "7af8406201bb9e413166e7ce9a54d6aa70205243", "tree": "e312103d3fa0f6f79acd0d90953527272dae4701", "parents": [ "8c12e9599ac08820aa7e290c7595954a68f6ef96" ], "author": { "name": "Pascal Hartig", "email": "realpassy@fb.com", "time": "Tue Mar 23 11:36:59 2021 -0700" }, "committer": { "name": "Facebook GitHub Bot", "email": "facebook-github-bot@users.noreply.github.com", "time": "Tue Mar 23 11:38:52 2021 -0700" }, "message": "v0.2.1\n\nSummary: Version bump which includes header-only releases again.\n\nReviewed By: muraziz\n\nDifferential Revision: D27267311\n\nfbshipit-source-id: 187cfd1b693899639e3c932a7e67641cfd31bba0\n" } ], "next": "8c12e9599ac08820aa7e290c7595954a68f6ef96" }