| commit | ce5c59729dfc9c970bbdaeb4a11b97427e65834e | [log] [tgz] |
|---|---|---|
| author | Deven Desai <deven.desai.amd@gmail.com> | Tue Sep 22 20:28:08 2020 +0000 |
| committer | Deven Desai <deven.desai.amd@gmail.com> | Tue Sep 22 22:26:45 2020 +0000 |
| tree | f165f8fb7d0d3ad132238534c1a3b40b39565ca3 | |
| parent | b8a13f13ca64328227604ef9eb6bbdd6327ac481 [diff] |
Fix for ROCm/HIP breakage - 200921 The following commit causes regressions in the ROCm/HIP support for Eigen https://gitlab.com/libeigen/eigen/-/commit/e55182ac09885d7558adf75e9e230b051a721c18 I suspect the same breakages occur on the CUDA side too. The above commit puts the EIGEN_CONSTEXPR attribute on `half_base` constructor. `half_base` is derived from `__half_raw`. When compiling with GPU support, the definition of `__half_raw` gets picked up from the GPU Compiler specific header files (`hip_fp16.h`, `cuda_fp16.h`). Properly supporting the above commit would require adding the `constexpr` attribute to the `__half_raw` constructor (and other `*half*` routines) in those header files. While that is something we can explore in the future, for now we need to undo the above commit when compiling with GPU support, which is what this commit does. This commit also reverts a small change in the `raw_uint16_to_half` routine made by the above commit. Similar to the case above, that change was leading to compile errors due to the fact that `__half_raw` has a different definition when compiling with DPU support.
Eigen is a C++ template library for linear algebra: matrices, vectors, numerical solvers, and related algorithms.
For more information go to http://eigen.tuxfamily.org/.
For pull request, bug reports, and feature requests, go to https://gitlab.com/libeigen/eigen.