| commit | f83c13fd0cce0dbabe87186d1233b2c9a0b66579 | [log] [tgz] |
|---|---|---|
| author | Deborah Brouwer <deborah.brouwer@collabora.com> | Thu Aug 14 16:29:32 2025 -0700 |
| committer | Deborah Brouwer <deborah.brouwer@collabora.com> | Tue Aug 19 12:23:31 2025 -0700 |
| tree | bea8aba2f7758c3be2fedd9d74399168b3d3981b | |
| parent | ae70ed5bf1af0ce9ffe61e4c707ef833b7e45862 [diff] |
drm_hwcomposer: Silence clang-tidy warnings Currently the clang-tidy CI job is ignoring code guarded by `__ANDROID_API__ >= 36` so some readability warnings slipped through. In preparation for updating the ANDROID_SDK_VERSION to 36, silence these warnings: * error: invalid case style for parameter 'maxProfiles' * error: all parameters should be named in a function Signed-off-by: Deborah Brouwer <deborah.brouwer@collabora.com>
Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms. So please bring on porting patches, bugfixes, improvements for documentation and new features.
A short list of contribution guidelines:
Submit changes via gitlab merge requests on gitlab.freedesktop.org.
drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/.
When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:
git diff | clang-format-diff-19 -p 1 -style=file
Hardware specific changes should be tested on relevant platforms before committing.
If you need inspiration, please checkout our TODO issues.
Happy hacking!