| commit | f35210964cb3d3d04cd4c98d2ebbb01c29105147 | [log] [tgz] |
|---|---|---|
| author | Andrew Wolfers <aswolfers@google.com> | Fri Jun 20 14:10:45 2025 +0000 |
| committer | Andrew Wolfers <aswolfers@google.com> | Fri Jun 20 15:43:33 2025 +0000 |
| tree | 6470000aa7e3f392e4a1441aca6f5931a4d8fd91 | |
| parent | e5f755f842396d5a47fdbe633068945511381bd3 [diff] |
drm_hwcomposer: Remove cursor buffor validity check This change removes a check in DrmPlane::IsValidForLayer which would verify that the buffer size matches known accepted values from the DRM_CAP_CURSOR or SIZE_HINTS properties. Those properties are required to return valid buffer sizes for committing to the cursor plane, but they are not meant to be exhaustive. As a result, this check was returning false negatives, and forcing the cursor into client composition unnecessarily. The intended usage is that these props should be checked during buffer allocation, not during composition. Instead, test commits are sufficient for detecting whether a buffer is valid for the cursor plane, and triggering fallback logic as needed. Change-Id: Iae14436a6f50e45a113a4d18de67e73810b2a83e Signed-off-by: Andrew Wolfers <aswolfers@google.com>
Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms. So please bring on porting patches, bugfixes, improvements for documentation and new features.
A short list of contribution guidelines:
Submit changes via gitlab merge requests on gitlab.freedesktop.org.
drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/.
When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:
git diff | clang-format-diff-19 -p 1 -style=file
Hardware specific changes should be tested on relevant platforms before committing.
If you need inspiration, please checkout our TODO issues.
Happy hacking!