Google Git
Sign in
android / platform / external / drm_hwcomposer / f3d360328e724c908827716d442c226e3128ff5a
commitf3d360328e724c908827716d442c226e3128ff5a[log] [tgz]
authorHaixia Shi <hshi@chromium.org>Mon Nov 02 10:04:49 2015 -0800
committerHaixia Shi <hshi@chromium.org>Mon Nov 02 10:29:25 2015 -0800
treeabc02f4e42c0b960d3ad9523eb17fbd2856e1247
parentbd61c8dc8a5a5198b5a35cae9908787209607a28 [diff]
drm_hwcomposer: filter out empty or invalid rects.

We can safely ignore zero-area rects because they do not affect the outcome
of the separate_rects() function. Furthermore the line sweep algorithm would
break when two identical START or END events are added to the same set.

Additionally any rect with |left| greater than |right| or |top| greater than
|bottom| is invalid and shall be ignored.

Added test cases with empty and invalid rects. This case would have crashed (or
failed the assert in a debug build) without this fix.

BUG=chrome-os-partner:47103
TEST=verify no crash with Photos app

Change-Id: I80950ef376390a14a892c58b563eb3c0f79db71c
1 file changed
tree: abc02f4e42c0b960d3ad9523eb17fbd2856e1247
  1. .clang-format
  2. Android.mk
  3. autofd.h
  4. autogl.h
  5. drmcomposition.cpp
  6. drmcomposition.h
  7. drmcompositor.cpp
  8. drmcompositor.h
  9. drmcompositorworker.cpp
  10. drmcompositorworker.h
  11. drmconnector.cpp
  12. drmconnector.h
  13. drmcrtc.cpp
  14. drmcrtc.h
  15. drmdisplaycomposition.cpp
  16. drmdisplaycomposition.h
  17. drmdisplaycompositor.cpp
  18. drmdisplaycompositor.h
  19. drmencoder.cpp
  20. drmencoder.h
  21. drmframebuffer.h
  22. drmgenericimporter.cpp
  23. drmgenericimporter.h
  24. drmhwcgralloc.h
  25. drmhwcomposer.h
  26. drmmode.cpp
  27. drmmode.h
  28. drmplane.cpp
  29. drmplane.h
  30. drmproperty.cpp
  31. drmproperty.h
  32. drmresources.cpp
  33. drmresources.h
  34. glworker.cpp
  35. glworker.h
  36. hwcomposer.cpp
  37. importer.h
  38. nvimporter.cpp
  39. nvimporter.h
  40. seperate_rects.cpp
  41. seperate_rects.h
  42. virtualcompositorworker.cpp
  43. virtualcompositorworker.h
  44. vsyncworker.cpp
  45. vsyncworker.h
  46. worker.cpp
  47. worker.h