| commit | 9805b1bac1798780453214ff0619935b63f522a6 | [log] [tgz] |
|---|---|---|
| author | Drew Davenport <ddavenport@google.com> | Thu Apr 03 14:43:10 2025 -0600 |
| committer | Drew Davenport <ddavenport@google.com> | Fri Apr 04 11:22:39 2025 -0600 |
| tree | 184df0ff15b0442390e6a0d5deefb015dd0a956b | |
| parent | 16292937922e7b0df14aa54ae861a7ee9399eaba [diff] |
drm_hwcomposer: Handle empty and cursor-only composition It's possible for the client may validate/present a composition without any layers. Early out in this case. This avoids a spurious failed_kms_validate_ when CreateComposition returns an error in this case. Reduce the error in HwcDisplay::CreateComposition to a warning, since the rest of the code should work even if an empty DrmKmsPlan is created. Additionally, the error in HwcDisplay::CreateComposition did not handle the case where the only layer is the cursor. This case is now handled by checking for an empty composition at the higher level. This case is hit in GraphicsComposerAidlCommandTest#PresentDisplay. Change-Id: I03e5accc3ccda18426908d7d163f23d81c3145ea Signed-off-by: Drew Davenport <ddavenport@google.com>
Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms. So please bring on porting patches, bugfixes, improvements for documentation and new features.
A short list of contribution guidelines:
Submit changes via gitlab merge requests on gitlab.freedesktop.org.
drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/.
When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:
git diff | clang-format-diff-19 -p 1 -style=file
Hardware specific changes should be tested on relevant platforms before committing.
If you need inspiration, please checkout our TODO issues.
Happy hacking!