| commit | 0fade37afd60c3f0e387172e03759e055f831d30 | [log] [tgz] |
|---|---|---|
| author | Roman Stratiienko <r.stratiienko@gmail.com> | Sat Feb 20 13:59:55 2021 +0200 |
| committer | Roman Stratiienko <r.stratiienko@gmail.com> | Sat Jul 24 17:59:09 2021 +0300 |
| tree | 247fb23bfac5a18ce8dc8d90efffa3166845b36d | |
| parent | 5128715b42e6713b98244bd05f218b8800a39b74 [diff] |
drm_hwcomposer: Rework autofd Motivation: Current implementation of UniqueFd can be used in a different ways, making analytical tracking of FD lifecycle much harder than it may be. Keep this part clean is very important, since any wrong code may open a hard-to-detect runtime bugs and fd leaks, which may accidentally slip into the production. Implementation: 1. Combine UniqueFd anf OutputFd into single class. 2. Reduce the API to be minimal and sufficient. 3. Document the API and use cases. 4. Move to utils/UniqueFd.h. 5. dup(fd) was replaced with fcntl(fd, F_DUPFD_CLOEXEC)) to address clang-tidy findings. Find more information at [1] [1]: https://clang.llvm.org/extra/clang-tidy/checks/android-cloexec-dup.html Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com>
Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms. So please bring on porting patches, bugfixes, improvements for documentation and new features.
A short list of contribution guidelines:
Submit changes via gitlab merge requests on gitlab.freedesktop.org.
drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/.
When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:
git diff | clang-format-diff-11 -p 1 -style=file
Hardware specific changes should be tested on relevant platforms before committing.
If you need inspiration, please checkout our TODO issues.
Happy hacking!