| commit | 0312c9e2a039eb872b6254b6dd5f2b3c7cc24f6e | [log] [tgz] |
|---|---|---|
| author | Andrew Wolfers <aswolfers@google.com> | Fri Apr 04 14:11:42 2025 +0000 |
| committer | Andrew Wolfers <aswolfers@google.com> | Fri Apr 04 19:49:46 2025 +0000 |
| tree | 23e6d189aba0066340967f52395300b9f5774493 | |
| parent | 9805b1bac1798780453214ff0619935b63f522a6 [diff] |
drm_hwcomposer: Fix cursor-related composition fallback This change fixes an issue during display validation where cursor layer failures would trigger a fallback that forces all other layers to be client composited. Prior to this fix, if the cursor layer could not match to the cursor plane, DrmKmsPlan would attempt to match it to another plane. This could result in the number of layers exceeding the number of available planes, which causes the composition to fail into the client-composition fallback behavior. This fix changes the first-level fallback behavior, so that when the cursor layer doesn't match to the cursor plane, the client range will be recaluclated in order to reserve an additional plane for device composition. Then the cursor layer is converted to device composition and the composition is retried. Change-Id: Id704e182b7cc1dc66270de45a986a29e4b71a5a8 Signed-off-by: Andrew Wolfers <aswolfers@google.com>
Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms. So please bring on porting patches, bugfixes, improvements for documentation and new features.
A short list of contribution guidelines:
Submit changes via gitlab merge requests on gitlab.freedesktop.org.
drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/.
When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:
git diff | clang-format-diff-19 -p 1 -style=file
Hardware specific changes should be tested on relevant platforms before committing.
If you need inspiration, please checkout our TODO issues.
Happy hacking!