)]}' { "commit": "c1c270dba20afa63a5b7769646cf721d0fa7c431", "tree": "aed82b0aa13d4a7826f2713eda1b2a777c21cf43", "parents": [ "de806dfdb6dd3b9dec5d1d23c9029fb300799cf8" ], "author": { "name": "Erik Kline", "email": "ek@google.com", "time": "Sat Nov 15 04:24:40 2014 +0900" }, "committer": { "name": "Erik Kline", "email": "ek@google.com", "time": "Fri Nov 21 18:34:20 2014 +0900" }, "message": "Fun with buffer overrruns.\n\nIn get_option(): don\u0027t read past the end of the option buffer.\n\nAlso add a small unittest to verify sane behaviour for the above.\nThe dhcpcd code is not easily refactored into a library, nor is it\nentirely possible to include some header files directly since some\nstructures use C++ reserved keywords (\"new\") for variable names.\n\nIn print_option(): use of snprintf() returns the length that\n/would/ have been written. Add checks that the output buffer\nis not overrun when printing.\n\nBug: 18356137\nBug: 18356135\nChange-Id: I0f907b8a952208749226ba034a416d773e068f8a\n", "tree_diff": [ { "type": "modify", "old_id": "6b55f0d54238bea7c6a2b9fd2c4ba3b553bd923e", "old_mode": 33188, "old_path": "Android.mk", "new_id": "216ee3a918c78e7873956f8ff12116ced8b86165", "new_mode": 33188, "new_path": "Android.mk" }, { "type": "modify", "old_id": "53f479566a262bde95cf8943bcb251e2d8c5a84f", "old_mode": 33188, "old_path": "dhcp.c", "new_id": "0a1d220439796266e532bb8b49fedb07ec7cc396", "new_mode": 33188, "new_path": "dhcp.c" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "1fa829fc4102358d4985e3e7e5199143b4a5134e", "new_mode": 33188, "new_path": "dhcpcd_test.cpp" } ] }