commit 451bcc1a9187e0cfaca6a346e5e55695b68e1851
author Daniel Stenberg <daniel@haxx.se> Tue Jul 12 23:06:01 2022 +0200
committer Daniel Stenberg <daniel@haxx.se> Wed Jul 13 23:26:13 2022 +0200
tree dae1e6092276ace60170504683ea3560c53a3640
parent e0c68f02552511df57f2afec2e62bc3ee684e12f

asyn-thread: make getaddrinfo_complete return CURLcode

... as the only caller that cares about what it returns assumes that
anyway. This caused icc to warn:

asyn-thread.c(505): error #188: enumerated type mixed with another type
        result = getaddrinfo_complete(data);

Repoorted-by: Matthew Thompson
Bug: https://github.com/curl/curl/issues/9081#issuecomment-1182143076
Closes #9146

lib/asyn-thread.c

diff --git a/lib/asyn-thread.c b/lib/asyn-thread.c
index d0edc32..92c38f2 100644
--- a/lib/asyn-thread.c
+++ b/lib/asyn-thread.c
@@ -269,18 +269,18 @@
   return 0;
 }
 
-static int getaddrinfo_complete(struct Curl_easy *data)
+static CURLcode getaddrinfo_complete(struct Curl_easy *data)
 {
   struct thread_sync_data *tsd = conn_thread_sync_data(data);
-  int rc;
+  CURLcode result;
 
-  rc = Curl_addrinfo_callback(data, tsd->sock_error, tsd->res);
+  result = Curl_addrinfo_callback(data, tsd->sock_error, tsd->res);
   /* The tsd->res structure has been copied to async.dns and perhaps the DNS
      cache.  Set our copy to NULL so destroy_thread_sync_data doesn't free it.
   */
   tsd->res = NULL;
 
-  return rc;
+  return result;
 }