| commit | fececcbc3890955fd46f92036e9cb6ee7d0a60f4 | [log] [tgz] |
|---|---|---|
| author | Anna Zaks <ganna@apple.com> | Wed Apr 10 22:06:29 2013 +0000 |
| committer | Anna Zaks <ganna@apple.com> | Wed Apr 10 22:06:29 2013 +0000 |
| tree | 4659a7ad4bfd417105722deaa15492f267abaf91 | |
| parent | 7a87e520e42c1e58c358e3a9a436ef17f551fd13 [diff] |
[analyzer] Fix a crash in SyntaxCString checker when given a custom strncat. Fixes PR13476 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@179228 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp b/lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp index 3a57a56..92c0eef 100644 --- a/lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp +++ b/lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp
@@ -101,6 +101,8 @@ // - strncat(dst, src, sizeof(dst) - 1); // - strncat(dst, src, sizeof(dst)); bool WalkAST::containsBadStrncatPattern(const CallExpr *CE) { + if (CE->getNumArgs() != 3) + return false; const Expr *DstArg = CE->getArg(0); const Expr *SrcArg = CE->getArg(1); const Expr *LenArg = CE->getArg(2);
diff --git a/test/Analysis/cstring-syntax-cxx.cpp b/test/Analysis/cstring-syntax-cxx.cpp index bae3d0a..39c978a 100644 --- a/test/Analysis/cstring-syntax-cxx.cpp +++ b/test/Analysis/cstring-syntax-cxx.cpp
@@ -15,3 +15,8 @@ X c = a + b; } +// Ensure we don't crash on custom-defined strncat. +char strncat (); +int main () { + return strncat (); +} \ No newline at end of file