[analyzer] Rename addExtraInvalidatedRegions to get...Regions
Per Anna's comment that "add..." sounds like a method that modifies
the receiver, rather than its argument.
No functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@160460 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/include/clang/StaticAnalyzer/Core/PathSensitive/Calls.h b/include/clang/StaticAnalyzer/Core/PathSensitive/Calls.h
index 596716b..7944d7a 100644
--- a/include/clang/StaticAnalyzer/Core/PathSensitive/Calls.h
+++ b/include/clang/StaticAnalyzer/Core/PathSensitive/Calls.h
@@ -109,7 +109,7 @@
/// \brief Used to specify non-argument regions that will be invalidated as a
/// result of this call.
- void addExtraInvalidatedRegions(RegionList &Regions) const;
+ void getExtraInvalidatedRegions(RegionList &Regions) const;
QualType getDeclaredResultType() const;
@@ -281,7 +281,7 @@
: CallEvent(D, St, LCtx, K) {}
// Most function calls have no extra invalidated regions.
- void addExtraInvalidatedRegions(RegionList &Regions) const {}
+ void getExtraInvalidatedRegions(RegionList &Regions) const {}
QualType getDeclaredResultType() const;
@@ -367,7 +367,7 @@
friend class CallEvent;
protected:
- void addExtraInvalidatedRegions(RegionList &Regions) const;
+ void getExtraInvalidatedRegions(RegionList &Regions) const;
CXXInstanceCall(const CallExpr *CE, ProgramStateRef St,
const LocationContext *LCtx, Kind K)
@@ -435,7 +435,7 @@
friend class CallEvent;
protected:
- void addExtraInvalidatedRegions(RegionList &Regions) const;
+ void getExtraInvalidatedRegions(RegionList &Regions) const;
QualType getDeclaredResultType() const;
@@ -482,7 +482,7 @@
friend class CallEvent;
protected:
- void addExtraInvalidatedRegions(RegionList &Regions) const;
+ void getExtraInvalidatedRegions(RegionList &Regions) const;
public:
/// Represents a constructor call to a new or unknown region.
@@ -532,7 +532,7 @@
friend class CallEvent;
protected:
- void addExtraInvalidatedRegions(RegionList &Regions) const;
+ void getExtraInvalidatedRegions(RegionList &Regions) const;
public:
/// Creates an implicit destructor.
@@ -610,7 +610,7 @@
const LocationContext *LCtx, Kind K)
: CallEvent(Msg, St, LCtx, K) {}
- void addExtraInvalidatedRegions(RegionList &Regions) const;
+ void getExtraInvalidatedRegions(RegionList &Regions) const;
QualType getDeclaredResultType() const;
@@ -792,8 +792,8 @@
return cast<ObjCPropertyAccess>(this)->fn(arg); \
}
-inline void CallEvent::addExtraInvalidatedRegions(RegionList &Regions) const {
- DISPATCH_ARG(addExtraInvalidatedRegions, Regions);
+inline void CallEvent::getExtraInvalidatedRegions(RegionList &Regions) const {
+ DISPATCH_ARG(getExtraInvalidatedRegions, Regions);
}
inline QualType CallEvent::getDeclaredResultType() const {
diff --git a/lib/StaticAnalyzer/Core/Calls.cpp b/lib/StaticAnalyzer/Core/Calls.cpp
index 17627b3..ba56364 100644
--- a/lib/StaticAnalyzer/Core/Calls.cpp
+++ b/lib/StaticAnalyzer/Core/Calls.cpp
@@ -115,7 +115,7 @@
ProgramStateRef Result = (Orig ? Orig : getState());
SmallVector<const MemRegion *, 8> RegionsToInvalidate;
- addExtraInvalidatedRegions(RegionsToInvalidate);
+ getExtraInvalidatedRegions(RegionsToInvalidate);
// Indexes of arguments whose values will be preserved by the call.
llvm::SmallSet<unsigned, 1> PreserveArgs;
@@ -327,7 +327,7 @@
}
-void CXXInstanceCall::addExtraInvalidatedRegions(RegionList &Regions) const {
+void CXXInstanceCall::getExtraInvalidatedRegions(RegionList &Regions) const {
if (const MemRegion *R = getCXXThisVal().getAsRegion())
Regions.push_back(R);
}
@@ -420,7 +420,7 @@
return D->param_end();
}
-void BlockCall::addExtraInvalidatedRegions(RegionList &Regions) const {
+void BlockCall::getExtraInvalidatedRegions(RegionList &Regions) const {
// FIXME: This also needs to invalidate captured globals.
if (const MemRegion *R = getBlockRegion())
Regions.push_back(R);
@@ -441,7 +441,7 @@
return UnknownVal();
}
-void CXXConstructorCall::addExtraInvalidatedRegions(RegionList &Regions) const {
+void CXXConstructorCall::getExtraInvalidatedRegions(RegionList &Regions) const {
if (Data)
Regions.push_back(static_cast<const MemRegion *>(Data));
}
@@ -453,7 +453,7 @@
return UnknownVal();
}
-void CXXDestructorCall::addExtraInvalidatedRegions(RegionList &Regions) const {
+void CXXDestructorCall::getExtraInvalidatedRegions(RegionList &Regions) const {
if (Data)
Regions.push_back(static_cast<const MemRegion *>(Data));
}
@@ -500,7 +500,7 @@
}
void
-ObjCMethodCall::addExtraInvalidatedRegions(RegionList &Regions) const {
+ObjCMethodCall::getExtraInvalidatedRegions(RegionList &Regions) const {
if (const MemRegion *R = getReceiverSVal().getAsRegion())
Regions.push_back(R);
}
