| commit | 27f965a577262deb9182c6935f3af05bb52b817c | [log] [tgz] |
|---|---|---|
| author | mtklein <mtklein@google.com> | Wed Oct 29 08:33:38 2014 -0700 |
| committer | Commit bot <commit-bot@chromium.org> | Wed Oct 29 08:33:38 2014 -0700 |
| tree | f1caf99809406e41da7ae035326fa6193b5ea32f | |
| parent | 7aa4d349be08cd622b715b21dd1e7770f7db2c01 [diff] |
Revert of Use SkTypeface::getBounds() in bounding-box calculations. (patchset #3 id:40001 of https://codereview.chromium.org/680363003/) Reason for revert: http://build.chromium.org/p/client.skia/builders/Test-Win7-ShuttleA-HD2000-x86-Debug/builds/97/steps/nanobench/logs/stdio Original issue's description: > Use SkTypeface::getBounds() in bounding-box calculations. > > This should produce tighter conservative bounding boxes for text than the > approximation code it replaces. > > Recording performance is neutral on my desktop. Playback performance > improves by up to 15% on text heavy pages, e.g. > > desk_pokemonwiki.skp_1 3.24ms -> 2.83ms 0.87x > desk_baidu.skp_1 1.91ms -> 1.58ms 0.83x > > Committed: https://skia.googlesource.com/skia/+/bf8dc343df4fbdcb8af546eb68b640e011a33489 TBR=reed@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/685173002