097435d - platform/external/chromium_org/third_party/libaddressinput/src

commit	097435d61737dc832cd1a4ebbbacf62e6d39ec44	[log] [tgz]
author	Fredrik Roubert <roubert@google.com>	Wed Aug 06 01:41:35 2014 +0000
committer	Fredrik Roubert <roubert@google.com>	Mon Sep 01 19:20:50 2014 +0200
tree	8a175aa2b0e1d58894a613e5c6a341d3de88fc24
parent	a68fee4c34c39626284b861f34c4b6511961fbdd [diff]

Refactor the Downloader interface into the Source interface.

Most implementations of this interface don't actually download anything,
so it's more logical to name the interface something else and define it
in terms of lookup keys ("data/CH") instead of URLs, and let those
implementations that do perform network access handle the mapping from
keys to URLs instead.

This simplifies most implementations of this interface and also the
Retriever, which now no longer needs to keep track of the base URL
(which in most cases was bogus anyway).

This change will break all current users of the libaddressinput API.

Ad infinitum et ultra!

TBR=rouslan@chromium.org
BUG=

Review URL: https://codereview.appspot.com/115680043

cpp/include/libaddressinput/address_validator.h[diff]
cpp/include/libaddressinput/downloader.h[Deleted - diff]
cpp/include/libaddressinput/ondemand_supplier.h[diff]
cpp/include/libaddressinput/preload_supplier.h[diff]
cpp/include/libaddressinput/source.h[Added - diff]
cpp/include/libaddressinput/storage.h[diff]
cpp/libaddressinput.gypi[diff]
cpp/src/lookup_key_util.cc[Deleted - diff]
cpp/src/lookup_key_util.h[Deleted - diff]
cpp/src/ondemand_supplier.cc[diff]
cpp/src/preload_supplier.cc[diff]
cpp/src/retriever.cc[diff]
cpp/src/retriever.h[diff]
cpp/test/address_input_helper_test.cc[diff]
cpp/test/address_normalizer_test.cc[diff]
cpp/test/address_validator_test.cc[diff]
cpp/test/fake_downloader.h[Deleted - diff]
cpp/test/fake_downloader_test.cc[Deleted - diff]
cpp/test/fake_storage.h[diff]
cpp/test/fake_storage_test.cc[diff]
cpp/test/lookup_key_util_test.cc[Deleted - diff]
cpp/test/mock_downloader.cc[Deleted - diff]
cpp/test/mock_downloader.h[Deleted - diff]
cpp/test/mock_source.cc[Added - diff]
cpp/test/mock_source.h[Added - diff]
cpp/test/ondemand_supply_task_test.cc[diff]
cpp/test/preload_supplier_test.cc[diff]
cpp/test/region_data_builder_test.cc[diff]
cpp/test/retriever_test.cc[diff]
cpp/test/rule_retriever_test.cc[diff]
cpp/test/supplier_test.cc[diff]
cpp/test/testdata_source.cc[Renamed from cpp/test/fake_downloader.cc - diff]
cpp/test/testdata_source.h[Added - diff]
cpp/test/testdata_source_test.cc[Added - diff]

34 files changed

tree: 8a175aa2b0e1d58894a613e5c6a341d3de88fc24