Add "microsoft edge webdriver " as a valid prefix
Without this, running with Edge as the browser throws an error.
Change-Id: Ie442e1192284956f89f7704b4d1df27ab91cc776
Reviewed-on: https://chromium-review.googlesource.com/c/crossbench/+/6160974
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Luis Pardo <lpardosixtos@microsoft.com>
diff --git a/crossbench/browsers/chromium/version.py b/crossbench/browsers/chromium/version.py
index 17e268f..3f90e58 100644
--- a/crossbench/browsers/chromium/version.py
+++ b/crossbench/browsers/chromium/version.py
@@ -170,7 +170,8 @@
def _validate_prefix(cls, prefix: Optional[str]) -> bool:
if not prefix:
return False
- return prefix.lower() in ("chromedriver ", "chromedriver-")
+ return prefix.lower() in ("chromedriver ", "chromedriver-",
+ "microsoft edge webdriver ")
@classmethod
def _parse_default_channel(cls, full_version: str) -> BrowserVersionChannel:
diff --git a/tests/crossbench/browsers/test_version.py b/tests/crossbench/browsers/test_version.py
index 024ba53..44d1c1d 100644
--- a/tests/crossbench/browsers/test_version.py
+++ b/tests/crossbench/browsers/test_version.py
@@ -753,6 +753,14 @@
return ChromeDriverVersion.parse(value)
+class MicrosoftEdgeWebdriverVersionTestCase(_BrowserVersionTestCase):
+ STABLE_VERSION_STR = ("Microsoft Edge WebDriver 131.0.2903.112"
+ "(16ab910a6e75f1c7d2da060bbe9ac569dfe64f70)")
+ VERSION_CLS = ChromeDriverVersion
+
+ def parse(self, value: str) -> BrowserVersion:
+ return ChromeDriverVersion.parse(value)
+
class FirefoxVersionTestCase(_BrowserVersionTestCase):
ANY_VERSION_STR = "Mozilla Firefox 114.0.1 any"
LTS_VERSION_STR = "Mozilla Firefox 114.0.1esr"
