commit c786a67a6e1920366c49f989a01ef40efaa2f52b
author Sergio Giro <sgiro@google.com> Tue Jul 19 13:19:53 2016 +0100
committer Ted Meyer <tmathmeyer@google.com> Wed Jul 20 22:07:33 2016 +0000
tree 0903c5b48ac1e3d0e6c0d3ead6e13debc55478a0
parent 1a9fbece659182a6f18a74947e11352cca6e1d61

GCMParameters: in ASN1 encoding, use 12 when no value is specified

This reverts commit 4d0e19131da68053fe1a73d43052bedadb107c70

Bug: 26231099
Bug: 26234568
Bug: 29876633
Change-Id: I44c0c68f1e92caf6547c9e3b494ec5b82b8cff5f
(cherry picked from commit 48c093f131532fc163625304c60d0a8d07689327)

bcprov/src/main/java/org/bouncycastle/asn1/cms/GCMParameters.java

diff --git a/bcprov/src/main/java/org/bouncycastle/asn1/cms/GCMParameters.java b/bcprov/src/main/java/org/bouncycastle/asn1/cms/GCMParameters.java
index 7fcaa01..0f03c87 100644
--- a/bcprov/src/main/java/org/bouncycastle/asn1/cms/GCMParameters.java
+++ b/bcprov/src/main/java/org/bouncycastle/asn1/cms/GCMParameters.java
@@ -16,10 +16,7 @@
  * <pre>
  GCMParameters ::= SEQUENCE {
    aes-nonce        OCTET STRING, -- recommended size is 12 octets
-   // BEGIN android-changed
-   // Was: aes-ICVlen       AES-GCM-ICVlen DEFAULT 12 }
-   aes-ICVlen       AES-GCM-ICVlen DEFAULT 16 }
-   // END android-changed
+   aes-ICVlen       AES-GCM-ICVlen DEFAULT 12 }
  * </pre>
  */
 public class GCMParameters
@@ -67,10 +64,7 @@
         }
         else
         {
-            // BEGIN android-changed
-            // Was: this.icvLen = 12;
-            this.icvLen = 16;
-            // END android-changed
+            this.icvLen = 12;
         }
     }
 
@@ -98,10 +92,7 @@
 
         v.add(new DEROctetString(nonce));
 
-        // BEGIN android-changed
-        // Was: if (icvLen != 12)
-        if (icvLen != 16)
-        // END android-changed
+        if (icvLen != 12)
         {
             v.add(new ASN1Integer(icvLen));
         }