tree 34bb3b676feed221df5ceedfa867349e4335fcd8
parent 04a69f8f9aa6002c340bcee1fd14f5757b7251e4
author Gavin Howard <gavin@yzena.com> 1623988933 -0600
committer Gavin Howard <gavin@yzena.com> 1623989279 -0600
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQKTBAABCgB9FiEE4qMDJKRGWk1YgmkuwIA4vfKA0z4FAmDMHCJfFIAAAAAALgAo
 aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEUy
 QTMwMzI0QTQ0NjVBNEQ1ODgyNjkyRUMwODAzOEJERjI4MEQzM0UACgkQwIA4vfKA
 0z4LjBAAy9Bu4bxZRUshGOg10riE2a6DCGPd/cWID79IA8uPxelzCq7qB0fYs07b
 rlCB44QLQ/tV3KZ18RVEeicW5mVttJhr3qUsL/GDxA4Uu5+0NxWWmGq7EqQ9nAmV
 rGUkn/kgDY0dXUIreIDD9TI/kwvFHCeS8MPfxFh0I26IIz+ko4a6J1YqRH4l/119
 TIKZtPMbKZZ8cy1Wo3vSscNdmFHVZa+DmOlo7X/J5HwGNgdQwKDYNlXuX9p2bT9k
 LJQhVHinCxYXdh6R41RYNMgxSnUNt6e+BTr1LP1zYB8sN4I1338UKDV0nbhtrRuI
 vT7/ei1ddXxKeaOi2j1LmjHuUzhE5M+s3yzVW2SWxhmGB3AMgU47tIdW11IkpdF1
 g4+4yrX8hAZ/f89xCljyarUiPniyNJP6jckMTp/1FR+47O8L1yb3FXUUnL81CJe+
 yVghnYAn68KAUQkNPPv7/rsqUtypPuYym6jeY2hHf7gGJh3i64kBYsPVhvrHrLUp
 qU0aQmWEMOFEe68eTSYv59SWciLcdfDfmihIk+zg6cUkwawXJuteuKBrvIHdvuFw
 CmHgCFgNpXcQStLUxc9a0KNmxkNYDiuQ+vqkN8yImtG86IyqxxFmyEmmj9JFxTuo
 /Bal6nWkRhpp5AHlHMGfQ2Y/XS2Ky1jjNtuPr0Jaw+/eW9Zi9p4=
 =9Hog
 -----END PGP SIGNATURE-----

Fix a crash found by AFL++ and add its test

This crash was caused by invalid free on a fatal memory allocation
error, which I had decided to ignore when BcNum's needed to be unshifted
because of `bc_num_checkInt()`. Turns out, I can't ignore it.

So instead, I decided to do several things:

* Rename `bc_num_checkInt()` to bc_num_nonInt()`
* Make `bc_num_nonInt()` return true if the argument is not an integer.
* If it is an integer, return false and copy the argument to another
  argument, shifting just the copy.

With these steps, the original is never shifted. This has several
benefits, including:

* I don't need to worry about `setjmp()` for these arguments anymore.
* Thus, the code will be correct by default, rather than brittle.

I should have done it this way to start with.

Signed-off-by: Gavin Howard <gavin@yzena.com>