commit 31073ff8e672cbd899096e02cc42bc45a591b69b
author David Tolnay <dtolnay@gmail.com> Sat Dec 31 14:42:18 2022 -0800
committer GitHub <noreply@github.com> Sat Dec 31 14:42:18 2022 -0800
tree 7fc6148cdfcb1416487156fd7db01a52b137b415
parent d4e5586d0a525a3789b1f09d75edc09abf35c7db

Replace tera template with serde_starlark (#1734)

* Replace tera template with serde_starlark

* Move starlark data structures to crate::utils::starlark

* Fix compatibility with min rust version's clippy

Old clippy:

    warning: unknown lint: `clippy::overly_complex_bool_expr`
      --> src/utils/starlark/glob.rs:23:13
       |
    23 |     #[allow(clippy::overly_complex_bool_expr)]
       |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       |
       = note: `#[warn(unknown_lints)]` on by default

    error: this boolean expression contains a logic bug
      --> src/utils/starlark/glob.rs:28:12
       |
    28 |         if false && self.exclude.is_empty() {
       |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: it would look like the following: `false`
       |
       = note: `#[deny(clippy::logic_bug)]` on by default
    help: this expression can be optimized out by applying boolean operations to the outer expression
      --> src/utils/starlark/glob.rs:28:21
       |
    28 |         if false && self.exclude.is_empty() {
       |                     ^^^^^^^^^^^^^^^^^^^^^^^
       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#logic_bug

New clippy:

    warning: lint `clippy::logic_bug` has been renamed to `clippy::overly_complex_bool_expr`
      --> src/utils/starlark/glob.rs:24:13
       |
    24 |     #[allow(clippy::logic_bug)] // clippy 1.64 and older
       |             ^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::overly_complex_bool_expr`
       |
       = note: `#[warn(renamed_and_removed_lints)]` on by default