| commit | 8fba377b0bc90ae6f852a621bb657213a1dd0066 | [log] [tgz] |
|---|---|---|
| author | Thomas Lam <thomaslam@canva.com> | Wed Jan 31 16:48:58 2024 +1100 |
| committer | GitHub <noreply@github.com> | Wed Jan 31 05:48:58 2024 +0000 |
| tree | 364313371ee0711b8b98d4d5cbc09ed7f40ef0fd | |
| parent | 8f114a5326e8940702e7e701a4cedd22ea4c1403 [diff] |
Ensure regular file bit set in wheel archives (#1731) #1453 added logic to manually set zipinfo for each file in the wheel archive. When wheel archives generated by `_Whlfile` are installed by the `installer` module (or `pip`), the file mode is inspected as such: * `installer`: https://github.com/pypa/installer/blob/fcc0d6f14f99974316c2e490cead07a9a0b7a6ac/src/installer/sources.py#L318-L321 * `pip`: https://github.com/pypa/pip/blob/0f21fb92/src/pip/_internal/utils/unpacking.py#L96-L100 as you can tell, if the regular file bit is not set, the installer thinks that the file being installed is not an executable and therefore the executable bit will not be preserved when the file from wheel is extracted onto the host filesystem. Since all files being archived into Whlfile are regular files anyway, we set `S_IFREG` on the file mode for all files in the zip archive. Fixes #1711 --------- Signed-off-by: Thomas Lam <thomaslam@canva.com> Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com>
This repository is the home of the core Python rules -- py_library, py_binary, py_test, py_proto_library, and related symbols that provide the basis for Python support in Bazel. It also contains package installation rules for integrating with PyPI and other indices.
Documentation for rules_python is at https://rules-python.readthedocs.io and in the Bazel Build Encyclopedia.
Examples live in the examples directory.
Currently, the core rules build into the Bazel binary, and the symbols in this repository are simple aliases. However, we are migrating the rules to Starlark and removing them from the Bazel binary. Therefore, the future-proof way to depend on Python rules is via this repository. SeeMigrating from the Bundled Rules below.
The core rules are stable. Their implementation in Bazel is subject to Bazel's backward compatibility policy. Once migrated to rules_python, they may evolve at a different rate, but this repository will still follow semantic versioning.
The Bazel community maintains this repository. Neither Google nor the Bazel team provides support for the code. However, this repository is part of the test suite used to vet new Bazel releases. See How to contribute page for information on our development workflow.
For detailed documentation, see https://rules-python.readthedocs.io
See Bzlmod support for more details.