| commit | 7345690cdcd82e8357416199b237b1e52305484f | [log] [tgz] |
|---|---|---|
| author | Brian Norris <briannorris@chromium.org> | Thu Dec 06 10:05:33 2018 -0800 |
| committer | chrome-bot <chrome-bot@chromium.org> | Thu Dec 06 22:06:30 2018 -0800 |
| tree | ca04f363e7730ca85f6b7171d9d6ea76ac5ac477 | |
| parent | 58776db61d728bdfd12c37bee1b2cf5d20a86018 [diff] |
[autotest] site_linux_router: increase hostapd startup timeout
It doesn't actually take hostapd very long to start up (I see 3-5
seconds in the longest cases), but it can take a little while to
check whether or not it has started up. This is partly because we use 3
different methods in _has_hostapd_started(), and each is run over a new
SSH session. Additionally, poll_for_condition() is not very forgiving --
when we use a 10 second timeout, it decides to cut us off even if (due
to, e.g., network delays, autoserv load, etc.) the last time we started
a "check for liveness" was much earlier in the 10 second window. This is
apparently how the function was designed, despite its flaws. Perhaps
we'll change that in CL:1364090.
But regardless, it's fair to increase this timeout significantly.
Looking through recent failures in startup, there are exactly zero
legitimate instances of hitting this timeout condition. In all cases,
hostapd started relatively quickly, but the last time we checked in was
1 to 2 seconds before it finished starting up. If we triple the timeout,
we are likely to get at least one or two more chances to check in with
hostapd, and we can hopefully avoid the spurious timeout.
Another reason a large timeout is no problem here: we also have negative
checks in _has_hostapd_started() which can detect whether
(a) hostapd terminated early (i.e., PID is not running) or
(b) hostapd logged some known errors already and is preparing to shut
down.
With those two cases, we will short-circuit and raise TestFail() anyway,
so we won't hit the timeout. So the only legitamite use of this timeout
is for very exceptional cases, which we aren't hitting in the lab today.
Side note: I spot-checked every recent "timeout" we've seen in the lab,
and all of them are spurious cases of
poll_for_condition()/_has_hostapd_started() declaring premature timeout.
BUG=chromium:811975
TEST=a few network_WiFi_... tests, even with 10 seconds of delay added
to _has_hostapd_started()
Change-Id: If814ae8b17435998fdcb4a74073ecab04b202feb
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1366335
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>
Autotest is a framework for fully automated testing. It was originally designed to test the Linux kernel, and expanded by the Chrome OS team to validate complete system images of Chrome OS and Android.
Autotest is composed of a number of modules that will help you to do stand alone tests or setup a fully automated test grid, depending on what you are up to. A non extensive list of functionality is:
A body of code to run tests on the device under test. In this setup, test logic executes on the machine being tested, and results are written to files for later collection from a development machine or lab infrastructure.
A body of code to run tests against a remote device under test. In this setup, test logic executes on a development machine or piece of lab infrastructure, and the device under test is controlled remotely via SSH/adb/some combination of the above.
Developer tools to execute one or more tests. test_that for Chrome OS and test_droid for Android allow developers to run tests against a device connected to their development machine on their desk. These tools are written so that the same test logic that runs in the lab will run at their desk, reducing the number of configurations under which tests are run.
Lab infrastructure to automate the running of tests. This infrastructure is capable of managing and running tests against thousands of devices in various lab environments. This includes code for both synchronous and asynchronous scheduling of tests. Tests are run against this hardware daily to validate every build of Chrome OS.
Infrastructure to set up miniature replicas of a full lab. A full lab does entail a certain amount of administrative work which isn't appropriate for a work group interested in automated tests against a small set of devices. Since this scale is common during device bringup, a special setup, called Moblab, allows a natural progressing from desk -> mini lab -> full lab.
See the guides to test_that and test_droid:
See the best practices guide, existing tests, and comments in the code.
git clone https://chromium.googlesource.com/chromiumos/third_party/autotest
See the coding style guide for guidance on submitting patches.
You need to run utils/build_externals.py to set up the dependencies for pre-upload hook tests.