Add method to get all tokens as a list as well as an array
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@424596 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/java/org/apache/commons/lang/text/StrTokenizer.java b/src/java/org/apache/commons/lang/text/StrTokenizer.java
index dbb05c1..cfe6b11 100644
--- a/src/java/org/apache/commons/lang/text/StrTokenizer.java
+++ b/src/java/org/apache/commons/lang/text/StrTokenizer.java
@@ -446,16 +446,30 @@
}
/**
- * Gets a copy of the full token list.
+ * Gets a copy of the full token list as an independent modifiable array.
*
* @return the tokens as a String array
*/
- public String[] getAllTokens() {
+ public String[] getTokenArray() {
tokenize();
return (String[]) tokens.clone();
}
/**
+ * Gets a copy of the full token list as an independent modifiable list.
+ *
+ * @return the tokens as a String array
+ */
+ public List getTokenList() {
+ tokenize();
+ List list = new ArrayList(tokens.length);
+ for (int i = 0; i < tokens.length; i++) {
+ list.add(tokens[i]);
+ }
+ return list;
+ }
+
+ /**
* Resets this tokenizer, forgetting all parsing and iteration already completed.
* <p>
* This method allows the same tokenizer to be reused for the same String.
diff --git a/src/test/org/apache/commons/lang/text/StrTokenizerTest.java b/src/test/org/apache/commons/lang/text/StrTokenizerTest.java
index cc1c043..47c3aa2 100644
--- a/src/test/org/apache/commons/lang/text/StrTokenizerTest.java
+++ b/src/test/org/apache/commons/lang/text/StrTokenizerTest.java
@@ -16,6 +16,8 @@
package org.apache.commons.lang.text;
+import java.util.Arrays;
+import java.util.List;
import java.util.NoSuchElementException;
import junit.framework.Test;
@@ -70,7 +72,7 @@
tok.setQuoteChar('"');
tok.setIgnoredMatcher(StrMatcher.trimMatcher());
tok.setIgnoreEmptyTokens(false);
- String tokens[] = tok.getAllTokens();
+ String tokens[] = tok.getTokenArray();
String expected[] = new String[]{"a", "b", "c", "d;\"e", "f", "", "", "",};
@@ -90,7 +92,7 @@
tok.setQuoteChar('"');
tok.setIgnoredMatcher(StrMatcher.noneMatcher());
tok.setIgnoreEmptyTokens(false);
- String tokens[] = tok.getAllTokens();
+ String tokens[] = tok.getTokenArray();
String expected[] = new String[]{"a", "b", "c ", "d;\"e", "f", " ", " ", "",};
@@ -110,7 +112,7 @@
tok.setQuoteChar('"');
tok.setIgnoredMatcher(StrMatcher.noneMatcher());
tok.setIgnoreEmptyTokens(false);
- String tokens[] = tok.getAllTokens();
+ String tokens[] = tok.getTokenArray();
String expected[] = new String[]{"a", "b", " c", "d;\"e", "f", " ", " ", "",};
@@ -130,7 +132,7 @@
tok.setQuoteChar('"');
tok.setIgnoredMatcher(StrMatcher.trimMatcher());
tok.setIgnoreEmptyTokens(true);
- String tokens[] = tok.getAllTokens();
+ String tokens[] = tok.getTokenArray();
String expected[] = new String[]{"a", "b", "c", "d;\"e", "f",};
@@ -151,7 +153,7 @@
tok.setIgnoredMatcher(StrMatcher.trimMatcher());
tok.setIgnoreEmptyTokens(false);
tok.setEmptyTokenAsNull(true);
- String tokens[] = tok.getAllTokens();
+ String tokens[] = tok.getTokenArray();
String expected[] = new String[]{"a", "b", "c", "d;\"e", "f", null, null, null,};
@@ -172,7 +174,7 @@
tok.setIgnoredMatcher(StrMatcher.trimMatcher());
tok.setIgnoreEmptyTokens(false);
// tok.setTreatingEmptyAsNull(true);
- String tokens[] = tok.getAllTokens();
+ String tokens[] = tok.getTokenArray();
String expected[] = new String[]{"a", "b", " c", "d;\"e", "f", null, null, null,};
@@ -206,7 +208,7 @@
tok.setQuoteMatcher(StrMatcher.doubleQuoteMatcher());
tok.setIgnoredMatcher(StrMatcher.noneMatcher());
tok.setIgnoreEmptyTokens(false);
- String tokens[] = tok.getAllTokens();
+ String tokens[] = tok.getTokenArray();
String expected[] = new String[]{"a", "", "", "b", "c", "d e", "f", "",};
@@ -226,7 +228,7 @@
tok.setQuoteMatcher(StrMatcher.doubleQuoteMatcher());
tok.setIgnoredMatcher(StrMatcher.noneMatcher());
tok.setIgnoreEmptyTokens(true);
- String tokens[] = tok.getAllTokens();
+ String tokens[] = tok.getTokenArray();
String expected[] = new String[]{"a", "b", "c", "d e", "f",};
@@ -483,6 +485,17 @@
}
//-----------------------------------------------------------------------
+ public void testListArray() {
+ String input = "a b c";
+ StrTokenizer tok = new StrTokenizer(input);
+ String[] array = tok.getTokenArray();
+ List list = tok.getTokenList();
+
+ assertEquals(Arrays.asList(array), list);
+ assertEquals(3, list.size());
+ }
+
+ //-----------------------------------------------------------------------
public void testCSV(String data) {
this.testXSVAbc(StrTokenizer.getCSVInstance(data));
this.testXSVAbc(StrTokenizer.getCSVInstance(data.toCharArray()));