Apply generics
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@829352 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/java/org/apache/commons/lang/builder/CompareToBuilder.java b/src/java/org/apache/commons/lang/builder/CompareToBuilder.java
index ebb29bb..2ad570e 100644
--- a/src/java/org/apache/commons/lang/builder/CompareToBuilder.java
+++ b/src/java/org/apache/commons/lang/builder/CompareToBuilder.java
@@ -438,7 +438,8 @@
* with <code>lhs</code>
* @since 2.0
*/
- public CompareToBuilder append(Object lhs, Object rhs, Comparator comparator) {
+ @SuppressWarnings("unchecked")
+ public CompareToBuilder append(Object lhs, Object rhs, Comparator<?> comparator) {
if (comparison != 0) {
return this;
}
@@ -483,7 +484,7 @@
if (comparator == null) {
comparison = ((Comparable) lhs).compareTo(rhs);
} else {
- comparison = comparator.compare(lhs, rhs);
+ comparison = ((Comparator) comparator).compare(lhs, rhs);
}
}
return this;
diff --git a/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java b/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java
index 51ef7bd..6dcbd38 100644
--- a/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java
+++ b/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java
@@ -179,7 +179,7 @@
try {
register(object);
Field[] fields = clazz.getDeclaredFields();
- List<String> excludedFieldList = excludeFields != null ? Arrays.asList(excludeFields) : Collections.EMPTY_LIST;
+ List<String> excludedFieldList = excludeFields != null ? Arrays.asList(excludeFields) : Collections.<String>emptyList();
AccessibleObject.setAccessible(fields, true);
for (Field field : fields) {
if (!excludedFieldList.contains(field.getName())
diff --git a/src/java/org/apache/commons/lang/builder/ToStringStyle.java b/src/java/org/apache/commons/lang/builder/ToStringStyle.java
index 56045f1..d678e58 100644
--- a/src/java/org/apache/commons/lang/builder/ToStringStyle.java
+++ b/src/java/org/apache/commons/lang/builder/ToStringStyle.java
@@ -461,18 +461,18 @@
register(value);
try {
- if (value instanceof Collection) {
+ if (value instanceof Collection<?>) {
if (detail) {
- appendDetail(buffer, fieldName, (Collection) value);
+ appendDetail(buffer, fieldName, (Collection<?>) value);
} else {
- appendSummarySize(buffer, fieldName, ((Collection) value).size());
+ appendSummarySize(buffer, fieldName, ((Collection<?>) value).size());
}
- } else if (value instanceof Map) {
+ } else if (value instanceof Map<?, ?>) {
if (detail) {
- appendDetail(buffer, fieldName, (Map) value);
+ appendDetail(buffer, fieldName, (Map<?, ?>) value);
} else {
- appendSummarySize(buffer, fieldName, ((Map) value).size());
+ appendSummarySize(buffer, fieldName, ((Map<?, ?>) value).size());
}
} else if (value instanceof long[]) {
@@ -587,7 +587,7 @@
* @param coll the <code>Collection</code> to add to the
* <code>toString</code>, not <code>null</code>
*/
- protected void appendDetail(StringBuffer buffer, String fieldName, Collection coll) {
+ protected void appendDetail(StringBuffer buffer, String fieldName, Collection<?> coll) {
buffer.append(coll);
}
@@ -599,7 +599,7 @@
* @param map the <code>Map</code> to add to the <code>toString</code>,
* not <code>null</code>
*/
- protected void appendDetail(StringBuffer buffer, String fieldName, Map map) {
+ protected void appendDetail(StringBuffer buffer, String fieldName, Map<?, ?> map) {
buffer.append(map);
}
@@ -1570,7 +1570,7 @@
* @param cls the <code>Class</code> to get the short name of
* @return the short name
*/
- protected String getShortClassName(Class cls) {
+ protected String getShortClassName(Class<?> cls) {
return ClassUtils.getShortClassName(cls);
}
diff --git a/src/test/org/apache/commons/lang/builder/CompareToBuilderTest.java b/src/test/org/apache/commons/lang/builder/CompareToBuilderTest.java
index 016b4c7..77d56f6 100644
--- a/src/test/org/apache/commons/lang/builder/CompareToBuilderTest.java
+++ b/src/test/org/apache/commons/lang/builder/CompareToBuilderTest.java
@@ -57,7 +57,7 @@
//-----------------------------------------------------------------------
- static class TestObject implements Comparable {
+ static class TestObject implements Comparable<TestObject> {
private int a;
public TestObject(int a) {
this.a = a;
@@ -81,8 +81,7 @@
public int getA() {
return a;
}
- public int compareTo(Object o) {
- TestObject rhs = (TestObject) o;
+ public int compareTo(TestObject rhs) {
return (a < rhs.a) ? -1 : (a > rhs.a) ? +1 : 0;
}
}
