Google GitGoogle Git
Sign in
android/platform/external/angle/f7eb7efb14
commit
f7eb7efb1472e0d767a154f9ba1b67ec5315da4b
[log]
author
Charlie Lao <cclao@google.com>
Tue Nov 28 11:20:57 2023 -0800
committer
Angle LUCI CQ <angle-scoped@luci-project-accounts.iam.gserviceaccount.com>
Wed Nov 29 20:33:38 2023 +0000
tree
3f68a761f9d03b6f30684f281eca61395665c040
parent
05e9ec1135b6e28ef27052ff4d6172f2e732a911 [diff]
Vulkan: Fix camera panorama hang

When EGL attributes does not speficy color space, right now we pick
VK_COLOR_SPACE_SRGB_NONLINEAR_KHR. This overwrites the color space
people set via ANativeWindow. This causes camera goes into CSC
conversion and errors out and stops media codec pipeline and causes
camera to hang. This CL enables mapUnspecifiedColorSpaceToPassThrough
feature flag for all platform that supports VK_EXT_swapchain_colorspace
so that it will pick VK_COLOR_SPACE_PASS_THROUGH_EXT and vulkan
swapchain code will try to keep whatever color space surface already
has. The feature flag is still kept here in case there is regression and
we need to experiment this feature flag again. We can remove it once
everything settles down.

This CL also adds updateColorSpace() and getActualFormatID() to
de-duplicate the logic of R8G8B8_UNORM overriding and use of
VK_COLOR_SPACE_PASS_THROUGH_EXT.

Bug: b/309480316
Bug: b/302196568
Change-Id: I0952fe78c2bfd59446391c553745b2b5cb152a9d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5066801
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
3 files changed
tree: 3f68a761f9d03b6f30684f281eca61395665c040
  1. android/
  2. build_overrides/
  3. doc/
  4. extensions/
  5. gni/
  6. include/
  7. infra/
  8. samples/
  9. scripts/
  10. src/
  11. third_party/
  12. tools/
  13. util/
  14. build
  15. buildtools
  16. testing
  17. .clang-format
  18. .gitattributes
  19. .gitignore
  20. .gitmodules
  21. .gn
  22. .style.yapf
  23. .vpython
  24. .vpython3
  25. .yapfignore
  26. additional_readme_paths.json
  27. Android.mk
  28. AUTHORS
  29. BUILD.gn
  30. codereview.settings
  31. CONTRIBUTORS
  32. DEPS
  33. DIR_METADATA
  34. dotfile_settings.gni
  35. LICENSE
  36. OWNERS
  37. PRESUBMIT.py
  38. README.chromium
  39. README.md
  40. WATCHLISTS
README.md

ANGLE - Almost Native Graphics Layer Engine

The goal of ANGLE is to allow users of multiple operating systems to seamlessly run WebGL and other OpenGL ES content by translating OpenGL ES API calls to one of the hardware-supported APIs available for that platform. ANGLE currently provides translation from OpenGL ES 2.0, 3.0 and 3.1 to Vulkan, desktop OpenGL, OpenGL ES, Direct3D 9, and Direct3D 11. Future plans include ES 3.2, translation to Metal and MacOS, Chrome OS, and Fuchsia support.

Level of OpenGL ES support via backing renderers

Direct3D 9Direct3D 11Desktop GLGL ESVulkanMetal
OpenGL ES 2.0completecompletecompletecompletecompletecomplete
OpenGL ES 3.0completecompletecompletecompletecomplete
OpenGL ES 3.1incompletecompletecompletecomplete
OpenGL ES 3.2in progressin progresscomplete

Additionally, OpenGL ES 1.1 is implemented in the front-end using OpenGL ES 3.0 features. This version of the specification is thus supported on all platforms specified above that support OpenGL ES 3.0 with known issues.

Platform support via backing renderers

Direct3D 9Direct3D 11Desktop GLGL ESVulkanMetal
Windowscompletecompletecompletecompletecomplete
Linuxcompletecomplete
Mac OS Xcompletecomplete [1]
iOScomplete [2]
Chrome OScompleteplanned
Androidcompletecomplete
GGP (Stadia)complete
Fuchsiacomplete

[1] Metal is supported on macOS 10.14+

[2] Metal is supported on iOS 12+

ANGLE v1.0.772 was certified compliant by passing the OpenGL ES 2.0.3 conformance tests in October 2011.

ANGLE has received the following certifications with the Vulkan backend:

  • OpenGL ES 2.0: ANGLE 2.1.0.d46e2fb1e341 (Nov, 2019)
  • OpenGL ES 3.0: ANGLE 2.1.0.f18ff947360d (Feb, 2020)
  • OpenGL ES 3.1: ANGLE 2.1.0.f5dace0f1e57 (Jul, 2020)
  • OpenGL ES 3.2: ANGLE 2.1.2.21688.59f158c1695f (Sept, 2023)

ANGLE also provides an implementation of the EGL 1.5 specification.

ANGLE is used as the default WebGL backend for both Google Chrome and Mozilla Firefox on Windows platforms. Chrome uses ANGLE for all graphics rendering on Windows, including the accelerated Canvas2D implementation and the Native Client sandbox environment.

Portions of the ANGLE shader compiler are used as a shader validator and translator by WebGL implementations across multiple platforms. It is used on Mac OS X, Linux, and in mobile variants of the browsers. Having one shader validator helps to ensure that a consistent set of GLSL ES shaders are accepted across browsers and platforms. The shader translator can be used to translate shaders to other shading languages, and to optionally apply shader modifications to work around bugs or quirks in the native graphics drivers. The translator targets Desktop GLSL, Vulkan GLSL, Direct3D HLSL, and even ESSL for native GLES2 platforms.

Sources

ANGLE repository is hosted by Chromium project and can be browsed online or cloned with

git clone https://chromium.googlesource.com/angle/angle

Building

View the Dev setup instructions.

Contributing