)]}' { "commit": "f22f16d3c0a80ce7bbc4a8eeff81fde63aa6ad40", "tree": "e40953baedbefd9f40c4d82b8d1eff725f12c150", "parents": [ "377b16792f7af5ae336285cacc4ca44cfe425b56" ], "author": { "name": "Tobin Ehlis", "email": "tobine@google.com", "time": "Thu Jul 18 15:10:49 2019 -0600" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Oct 01 21:51:34 2019 +0000" }, "message": "Reland \"Vulkan: Use VK repos\u0027 internal BUILD.gn files\"\n\nThis is a reland of 552f5fcb0d8fcc615856ce3b678190e1cbdd38e6\nThere was a missing build dependence causing a build no-op\nissue which has now been fixed in the upstream Vulkan Validation\nLayer repo.\n\nPrimary workaround that need to be re-visted and fixed are:\n1. Disabled validation layers on 32-bit Windows\n2. Disabled validation layers on 32-bit Android\n3. Disabled DebugUtils on Android, using DebugReport instead\n4. Using custom VK Loader branch to avoid WDK dependence\n\nOriginal change\u0027s description:\n\u003e Vulkan: Use VK repos\u0027 internal BUILD.gn files\n\u003e\n\u003e This retires custom BUILD.gn files for the Vulkan Headers, Tools,\n\u003e Validation-Layers, and Loader repos. They now have integrated BUILD.gn\n\u003e files so switched ANGLE to use those by default.\n\u003e Also Validation Layer, Loader, and Tools repos no longer uses codegen\n\u003e so this speeds up the build overall.\n\u003e Switched over from old VK_LAYER_LUNARG_standard_validation meta-layer\n\u003e to VK_LAYER_KHRONOS_validation unified layer.\n\u003e\n\u003e This changes includes a temporary workaround to the Vulkan-Loader repo\n\u003e to remove its Window\u0027s build dependence on WDK. There are plans to\n\u003e remove that depenedence in Loader master, but until then we can use\n\u003e our custom branch workaround.\n\u003e It also includes a custom branch for validation layers that includes\n\u003e some build fixes for ANGLE.\n\u003e Finally, the layers were crashing on Android when attempting to use\n\u003e DebugUtils extension so forcing DebugReport on Android for now.\n\u003e\n\u003e Bug: angleproject:2449\n\u003e Bug: angleproject:3320\n\u003e Bug: angleproject:3852\n\u003e Bug: angleproject:3924\n\u003e Bug: angleproject:3925\n\u003e Bug: angleproject:3946\n\u003e Bug: chromium:997009\n\u003e Bug: chromium:997016\n\u003e Change-Id: I48b36acefcc7f2bc930eb72d6fdbc87bca24f833\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1610438\n\u003e Reviewed-by: Shahbaz Youssefi \u003csyoussefi@chromium.org\u003e\n\u003e Reviewed-by: Jamie Madill \u003cjmadill@chromium.org\u003e\n\u003e Commit-Queue: Tobin Ehlis \u003ctobine@google.com\u003e\n\nBug: angleproject:2449, angleproject:3320, angleproject:3852\nChange-Id: I373ada091a1329db5e304874079428d01ba21d52\nReviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1778302\nReviewed-by: Tobin Ehlis \u003ctobine@google.com\u003e\nCommit-Queue: Tobin Ehlis \u003ctobine@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "3ff8b7cce3df1f088a98492412bc3e2e6b0c8048", "old_mode": 33188, "old_path": "BUILD.gn", "new_id": "18fa67ac6c40069d46b642038511ce3028153d59", "new_mode": 33188, "new_path": "BUILD.gn" }, { "type": "modify", "old_id": "e20f56bfd9b2075e33e86ad47d81018848fa4553", "old_mode": 33188, "old_path": "DEPS", "new_id": "54423c280ea070d8fbfb1315583a58719f4cede1", "new_mode": 33188, "new_path": "DEPS" }, { "type": "modify", "old_id": "39f3c8a8d0938aaa4ec3501fb68f3f9e76bdabf4", "old_mode": 33188, "old_path": "android/angle_apk.gni", "new_id": "c561c4050d51d753553619c7e2e14f1d6d197df5", "new_mode": 33188, "new_path": "android/angle_apk.gni" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "580eda1dd5436c2f51e81e55532aacfa90999ff6", "new_mode": 33188, "new_path": "build_overrides/vulkan_loader.gni" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "4691eae7a6eefff8cd93eb08d325c3a050d7d880", "new_mode": 33188, "new_path": "build_overrides/vulkan_tools.gni" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "5d691b90bca10b1076281f8b6cc759c65ce10f41", "new_mode": 33188, "new_path": "build_overrides/vulkan_validation_layers.gni" }, { "type": "modify", "old_id": "8c370c36f51b7dbb986ea346227a49180bf2c7ac", "old_mode": 33188, "old_path": "dotfile_settings.gni", "new_id": "baf6e60467e4890806e784c4c2dd836c3c0dd87f", "new_mode": 33188, "new_path": "dotfile_settings.gni" }, { "type": "modify", "old_id": "3ba56240c0d182268d9e19207f854c01e1fed42a", "old_mode": 33188, "old_path": "scripts/code_generation_hashes/Vulkan_mandatory_format_support_table.json", "new_id": "d5f8ef73722a12af601d0106f69bcd86d619e0fa", "new_mode": 33188, "new_path": "scripts/code_generation_hashes/Vulkan_mandatory_format_support_table.json" }, { "type": "modify", "old_id": "e34f3fbbd3fd88fa1ca146afad97486b9b2fc7b5", "old_mode": 33188, "old_path": "src/libANGLE/renderer/renderer_utils.cpp", "new_id": "c5b7eee5f485f29c8c9bf26413e36b4d65d43f54", "new_mode": 33188, "new_path": "src/libANGLE/renderer/renderer_utils.cpp" }, { "type": "modify", "old_id": "e560618d5d6a8be80e80da835f6d169d7c8e90f8", "old_mode": 33188, "old_path": "src/libANGLE/renderer/vulkan/RendererVk.cpp", "new_id": "ecdabff7d5915e50e14d6eb8e3e18fee1760048e", "new_mode": 33188, "new_path": "src/libANGLE/renderer/vulkan/RendererVk.cpp" }, { "type": "modify", "old_id": "7427c92eddd11409b1394f68c885226a1983a0ef", "old_mode": 33188, "old_path": "src/libANGLE/renderer/vulkan/vk_utils.cpp", "new_id": "178aed614b67462a6bc9a479f8e7963335d04a23", "new_mode": 33188, "new_path": "src/libANGLE/renderer/vulkan/vk_utils.cpp" }, { "type": "modify", "old_id": "210a0a9617c98061e5d93ca932f39e5e75e76832", "old_mode": 33188, "old_path": "src/tests/test_utils/angle_test_configs.cpp", "new_id": "ccd67b8024bc6b43a323b6c0ba82fd0c2d13e41a", "new_mode": 33188, "new_path": "src/tests/test_utils/angle_test_configs.cpp" }, { "type": "delete", "old_id": "e61be5643f2c0e42a1e4a48d668d9e083c90192f", "old_mode": 33188, "old_path": "third_party/vulkan-headers/BUILD.gn", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "552bf6edf45807e6a279b37e72db58805b05e230", "old_mode": 33188, "old_path": "third_party/vulkan-headers/vulkan_headers_script_deps.gni", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "0fe1abd18ec596fde9611d0e2a096dfea029f09d", "old_mode": 33188, "old_path": "third_party/vulkan-tools/BUILD.gn", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "36e0800d42e98497407d08228af8f43df10e6858", "old_mode": 33188, "old_path": "third_party/vulkan-validation-layers/BUILD.gn", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "e1793bdff59e41baea2e490454c8cbafb97f9134", "old_mode": 33188, "old_path": "third_party/vulkan-validation-layers/dummy_spirv_tools_commit_id.h", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" } ] }