tree b85979e79a19805c5f8cb062f967c9880ea9b9c7
parent eaef7c1786ceb5db723619ff3b4d99cfe1c55986
author Olli Etuaho <oetuaho@nvidia.com> 1437653259 +0530
committer Olli Etuaho <oetuaho@nvidia.com> 1456847036 +0000

Names of built-in functions cannot be redeclared as functions

With ESSL 3.00, names of built-in functions cannot be redeclared as
functions, and therefore an error needs to be generated if a built-in
function is overloaded.

This is fixed by inserting unmangled built-ins into a special set in
the symbol table and checking if function declarations match any of
the built-ins in the set.

The regular symbol table structures can't be used for storing the
unmangled names because that interferes with name hashing in
OutputGLSL.

Credit goes to Arun Patole, apatole@nvidia.com for initially
investigating this issue and developing the first version of the
patch.

BUG=angleproject:1066
TEST=angle_unittests,
dEQP-GLES3.functional.shaders.functions.invalid.overload_builtin_function*
(2 tests started passing with this change)

Change-Id: I28c8325f5a3a8f4a97226b0dfdbb9762724fa609
Reviewed-on: https://chromium-review.googlesource.com/328994
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>