commit 30afc25e1fe1d729a6418c0b3f7ede5be67dd659
author Sylvain Defresne <sdefresne@chromium.org> Wed Nov 03 17:59:19 2021 +0100
committer Angle LUCI CQ <angle-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Nov 04 19:57:28 2021 +0000
tree 85457928b23f8d9ad15d43f4cdf26525361e4254
parent 8c9b8f03e0f3bfb58f2023231337db6d03b6fc84

[ios] Remove support for building with Xcode clang

Chromium //build will soon remove the `use_xcode_clang` variable.
Remove it from Angle to avoid breakage when the variable is gone.

Bug: chromium:1266466
Change-Id: I3f95ffe611cc38c9de76e9744186efff3332d539
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3259713
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn
index 6126161..42624b0 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -200,6 +200,8 @@
       "-Wundefined-reinterpret-cast",
       "-Wunneeded-internal-declaration",
       "-Wunused-but-set-variable",
+      "-Wsuggest-destructor-override",
+      "-Wsuggest-override",
 
       # The below warnings are used by WebKit. We enable them to make rolling
       # ANGLE in WebKit easier.
@@ -209,13 +211,6 @@
       "-Wunreachable-code-aggressive",
       "-Wshorten-64-to-32",
     ]
-    if (!use_xcode_clang) {
-      # Mac catalyst uses a clang version that doesn't have these.
-      cflags += [
-        "-Wsuggest-destructor-override",
-        "-Wsuggest-override",
-      ]
-    }
   }
 
   if (is_gcc) {

gni/angle.gni

diff --git a/gni/angle.gni b/gni/angle.gni
index 9b024e3..3c3fa71 100644
--- a/gni/angle.gni
+++ b/gni/angle.gni
@@ -55,7 +55,6 @@
     ozone_platform_gbm = false
     ozone_platform_headless = false
     use_fuzzing_engine = false
-    use_xcode_clang = false
     is_apple = is_mac || is_ios
   }