Google GitGoogle Git
Sign in
android/platform/external/angle/1a8b7758e2
commit
1a8b7758e2ff0b64081b501c69f7577491333994
[log]
author
Tim Van Patten <timvp@google.com>
Tue Feb 11 10:34:00 2020 -0700
committer
Commit Bot <commit-bot@chromium.org>
Tue Feb 11 19:41:54 2020 +0000
tree
7fbfe526cbd87b3d6a0aaae35d85407842fc6b72
parent
b40d48a67c932625f349c6e58036c2d96b62489b [diff]
Fix assignment of CacheOpResult::EnumCount

The special enum value 'EnumCount' is used by EnumSize() to determine
how large to make the PackedEnumMap::mPrivateData array. However, that
enum entry was being assigned an incorrect value, leading to the array
being constructed too small and causing a crash in PackedEnumMap's
std::initializer_list constructor when it went beyond the size of the
array to assign each of the necessary values.

The fix is to remove the assignment of CacheOpResult::EnumCount and let
it indicate the real number of entries in the enum.

Bug: angleproject:4393
Test: end2end
Change-Id: If9635c61e72aadc6527d416f83be18add8b24572
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050026
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
1 file changed
tree: 7fbfe526cbd87b3d6a0aaae35d85407842fc6b72
  1. android/
  2. build_overrides/
  3. doc/
  4. extensions/
  5. gni/
  6. include/
  7. infra/
  8. samples/
  9. scripts/
  10. src/
  11. third_party/
  12. tools/
  13. util/
  14. .clang-format
  15. .gitattributes
  16. .gitignore
  17. .gn
  18. .style.yapf
  19. .yapfignore
  20. additional_readme_paths.json
  21. AUTHORS
  22. BUILD.gn
  23. codereview.settings
  24. CONTRIBUTORS
  25. DEPS
  26. dotfile_settings.gni
  27. LICENSE
  28. OWNERS
  29. PRESUBMIT.py
  30. README.chromium
  31. README.md
  32. WATCHLISTS
README.md

ANGLE - Almost Native Graphics Layer Engine

The goal of ANGLE is to allow users of multiple operating systems to seamlessly run WebGL and other OpenGL ES content by translating OpenGL ES API calls to one of the hardware-supported APIs available for that platform. ANGLE currently provides translation from OpenGL ES 2.0 and 3.0 to desktop OpenGL, OpenGL ES, Direct3D 9, and Direct3D 11. Support for translation from OpenGL ES to Vulkan is underway, and future plans include compute shader support (ES 3.1) and MacOS support.

Level of OpenGL ES support via backing renderers

Direct3D 9Direct3D 11Desktop GLGL ESVulkanMetal
OpenGL ES 2.0completecompletecompletecompletecompletein progress
OpenGL ES 3.0completecompletecompletein progress
OpenGL ES 3.1in progresscompletecompletein progress
OpenGL ES 3.2plannedplannedplanned

Platform support via backing renderers

Direct3D 9Direct3D 11Desktop GLGL ESVulkanMetal
Windowscompletecompletecompletecompletecomplete
Linuxcompletecomplete
Mac OS Xcompletein progress
iOSplanned
Chrome OScompleteplanned
Androidcompletecomplete
Fuchsiain progress

ANGLE v1.0.772 was certified compliant by passing the ES 2.0.3 conformance tests in October 2011. ANGLE also provides an implementation of the EGL 1.4 specification.

ANGLE is used as the default WebGL backend for both Google Chrome and Mozilla Firefox on Windows platforms. Chrome uses ANGLE for all graphics rendering on Windows, including the accelerated Canvas2D implementation and the Native Client sandbox environment.

Portions of the ANGLE shader compiler are used as a shader validator and translator by WebGL implementations across multiple platforms. It is used on Mac OS X, Linux, and in mobile variants of the browsers. Having one shader validator helps to ensure that a consistent set of GLSL ES shaders are accepted across browsers and platforms. The shader translator can be used to translate shaders to other shading languages, and to optionally apply shader modifications to work around bugs or quirks in the native graphics drivers. The translator targets Desktop GLSL, Direct3D HLSL, and even ESSL for native GLES2 platforms.

Sources

ANGLE repository is hosted by Chromium project and can be browsed online or cloned with

git clone https://chromium.googlesource.com/angle/angle

Building

View the Dev setup instructions.

Contributing