)]}'
{
  "commit": "39fa6e6d1b8c7c6c8ef6a411c2ed162c17dc91a5",
  "tree": "97abbed6c56a98c722c9a6a53ea4b14121eb4b90",
  "parents": [
    "8558eb88d7861c7751004e39a183b870310722c7"
  ],
  "author": {
    "name": "Sven van Haastregt",
    "email": "sven.vanhaastregt@arm.com",
    "time": "Tue Jul 16 18:53:18 2024 +0200"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Tue Jul 16 09:53:18 2024 -0700"
  },
  "message": "math_brute_force: remove spurious tan skip check (#1992)\n\nThe `skipTestingRelaxed` check suffers the following problems:\r\n\r\n- The use of `skipTestingRelaxed` in the `if` seems reversed: when\r\nskipping correctness testing using the `-l` command line option, this\r\nvariable causes correctness testing to be run for relaxed-mode `tan`\r\nregardless.\r\n\r\n- Accuracy testing should only be skipped for derived `tan`\r\nimplementations. Non-derived `tan` implementations must still be tested\r\nfor accuracy, so the condition for setting the `skipTestingRelaxed`\r\nvariable is incomplete.\r\n\r\n- It is unclear why only `tan` is conditionalized here. There are other\r\nfunctions such as `tanpi` for which one would expect identical\r\nbehaviour.\r\n\r\nThe actual skipping of accuracy checks for derived implementations\r\nhappens in `Test()`, so just remove `skipTestingRelaxed` as it does not\r\nseem to add any value.\r\n\r\nSigned-off-by: Sven van Haastregt \u003csven.vanhaastregt@arm.com\u003e",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "9666d5ea49a1dabc8a462283897d305107dda443",
      "old_mode": 33188,
      "old_path": "test_conformance/math_brute_force/unary_float.cpp",
      "new_id": "cd93d3c97222ab8f996a15e8656412e893be5514",
      "new_mode": 33188,
      "new_path": "test_conformance/math_brute_force/unary_float.cpp"
    }
  ]
}
