tree 44ac4f8fd3536f4beeb13da66f9ee1fc3233aff6
parent 3b863f24b4eff0a2dc5d3e0edcf20c0b0989b940
author David Pursell <dpursell@google.com> 1445362074 -0700
committer David Pursell <dpursell@google.com> 1445362161 -0700

device.py: fix _subprocess_Popen cleanup.

Every time gdbclient.py finishes it's giving this error:

Exception TypeError: 'must be type, not None' in <bound method
_subprocess_Popen.__del__ of <adb.device._subprocess_Popen object at
0x7fdd48e76850>> ignored

Basically super(_subprocess_Popen, self) was failing because at that
point _subprocess_Popen is None since global teardown had already
deleted the reference.

This fix saves local references to required global objects so that they
stick around until we're done with them. We may want to start looking
into making _subprocess_Popen a context manager instead, usage won't be
as convenient but __del__() does not scale to general use well. For now
though this CL seems to solve the problem for gdbclient.py.

Change-Id: I6c2a9fe0c108ae600cf05eb3b887d56959c7308e